1799393 - "Confirm before closing multiple tabs" asks for confirmation when closing the last window with just Firefox View and one tab (on Windows/Linux)

Status: VERIFIED FIXED

(Firefox :: Firefox View, defect, P3)

Description

Attachment: Firefox Bug.png

+++ This bug was initially created as a clone of Bug #1784323 +++

STR:

1. Enable the "Confirm before closing multiple tabs" setting in about:preferences.
2. Ensure you have 1 open window. It should have two tabs: the Firefox View tab and the newtab tab.
3. Switch focus from the newtab tab to the Firefox View tab.
4. Switch focus from Firefox View back to the newtab tab.**
5. Try to close the window (using the Ctrl+W keyboard shortcut or clicking the X window button).

Expected result:

The window should close without interruption. The Firefox View tab should not be considered a "blocking tab" for closing a window.

Actual result

Firefox shows the "Confirm before closing multiple tabs" dialog. See the attached screenshot.

The bug is still present in nightly v108.0a1 but only show up sometimes (cannot be reproduce easily).

Comment 1

[progress2048]

Attachment: image.png

Comment 2

[Sarah Clements [:sclements]]

I tried this probably around ten times or so and only once was I able to reproduce it once. Bernard, can you look into this since you worked on bug 1784323?

Comment 3

[Bernard Igiri]

I'm having trouble reproducing this as well. Do you have any more information on how to reproduce this? Maybe a screen recording can help?

Comment 4

[progress2048]

Attachment: 2022-11-08 14-37-35.mkv

I found the bug only appear when only one window is opened, when more then one windows is opened, the bug does not appear.
And here is the video:

Comment 5

[Raluca Popovici, Desktop QA]

I was able to reproduce this issue with only one window(switching from Fx view to new tab) on win 10x64 using Fx 106.0.5, Fx Beta 107.0, Nightly 108.0a1(2022-11-08).

Comment 6

[Bernard Igiri]

This bug is reproduceable on Windows and Linux, but not on MacOS.

Comment 7

[Bernard Igiri]

Attachment: Bug 1799393 - Prevent hidden Fx View tab from triggering the closing multiple tabs warning in Windows and Linux r=gijs!

Updated the tab closing prompt logic to use the number of visible tabs open to determine if the prompt should show in Windows and Linux.

Comment 8

[Sarah Clements [:sclements]]

(In reply to Bernard Igiri from comment #6)

This bug is reproduceable on Windows and Linux, but not on MacOS.

I did see it reproduce at least once on mac, but it took several tries. But it looks like your solution is platform agnostic anyways?

Comment 9

[Bernard Igiri]

This is where the behavior changes for Windows/Linux vs Mac: https://searchfox.org/mozilla-central/source/toolkit/content/globalOverlay.js#11
Eventually that code triggers: https://searchfox.org/mozilla-central/source/toolkit/content/globalOverlay.js#63
Followed by this: https://searchfox.org/mozilla-central/source/browser/components/BrowserGlue.jsm#942

Comment 10

[:Gijs (he/him)]

This bug is kind of confusing given the steps in comment 0 are just not right in light of comment #4 / comment #5. I will go and edit comment 0 but please let me know if the edit is inaccurate.

Comment 11

[:Gijs (he/him)]

(It'd be useful if someone could confirm if the tab that is selected when closing the window still makes a difference to whether this bug reproduces or not, in the scenario described in comment 0/4/5.)

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/300b0ac8eb7b
Prevent hidden Fx View tab from triggering the closing multiple tabs warning in Windows and Linux r=Gijs

Comment 14

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/300b0ac8eb7b

Comment 15

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:bigiri, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox109 to wontfix.

For more information, please visit auto_nag documentation.

Comment 16

[Bernard Igiri]

Comment on attachment 9304572 [details]
Bug 1799393 - Prevent hidden Fx View tab from triggering the closing multiple tabs warning in Windows and Linux r=gijs!

Beta/Release Uplift Approval Request

• User impact if declined: Closing a Firefox browser window in Windows or Linux after the Firefox View tab has been opened, will show the "Closing Multiple Tabs" warning when it should not, if the user has that warning enabled.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: 1. Enable the "Confirm before closing multiple tabs" setting in about:preferences.

2. Ensure you have 1 open window. It should have two tabs: the Firefox View tab and the newtab tab.
3. Switch focus from the newtab tab to the Firefox View tab.
4. Switch focus from Firefox View back to the newtab tab.
5. Try to close the window (using the Ctrl+W keyboard shortcut or clicking the X window button).

Expected result:

The window should close without interruption. The Firefox View tab should not be considered a "blocking tab" for closing a window.

• List of other uplifts needed: None
• Risk to taking this patch: Medium
• Why is the change risky/not risky? (and alternatives if risky): This change alters the logic for determining when to show the warning prompt for closing multiple tabs. The logic used in this patch mostly mirrors the logic used in previously landed patch for this same issue on MacOS (bug 1784323), as both rely on visibleTabs.length to count the number of open tabs. There is also an automated test to verify this functionality that mirrors the same test for the MacOS patch.
• String changes made/needed:
• Is Android affected?: No

Comment 17

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9304572 [details]
Bug 1799393 - Prevent hidden Fx View tab from triggering the closing multiple tabs warning in Windows and Linux r=gijs!

Approved for 109.0b3.

Comment 18

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/0ba3401ddcc4

Comment 19

[Peter Magyari (Desktop QA)]

I have verified the fix using Beta 109.0b3 (20221215185833) and Nightly 110.0a1 (20221216093922) on Windows 10 and Ubuntu 20.04.