Closed Bug 1799484 Opened 2 years ago Closed 1 year ago

Ensure that mozlint/source-test jobs are configured for Phabricator code-review

Categories

(Thunderbird :: Build Config, task)

Tracking

(thunderbird_esr102 wontfix, thunderbird107 wontfix)

RESOLVED FIXED
109 Branch
Tracking Status
thunderbird_esr102 --- wontfix
thunderbird107 --- wontfix

People

(Reporter: rjl, Assigned: rjl)

References

Details

Attachments

(3 files, 1 obsolete file)

In order to see automated linting results in Phabricator, "source-test" jobs need to be configured so the code-review bot can find and process results.

See https://github.com/mozilla/code-review/blob/master/docs/trigger.md
and https://github.com/mozilla/code-review/blob/master/docs/publication.md

Prep work for getting code-review results for comm-central code reviews in
Phabricator.

Target Milestone: --- → 108 Branch

Pushed by alessandro@thunderbird.net:
https://hg.mozilla.org/comm-central/rev/1caf9cdb9acc
Ensure mozlint jobs have code-review attribute set. r=dandarnell,linter-reviewers,sylvestre

Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED

Except the patch doesn't actually set "code-review: true" for most of the mozlint jobs...

Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Depends on: 1800472, 1799954
Target Milestone: 108 Branch → 109 Branch

Pushed by thunderbird@calypsoblue.org:
https://hg.mozilla.org/comm-central/rev/b4880718f18e
Add code-review job kind and really set code-review attributes. r=dandarnell,linter-reviewers,marco

Status: REOPENED → RESOLVED
Closed: 2 years ago1 year ago
Resolution: --- → FIXED
Attachment #9304113 - Attachment is obsolete: true
Status: RESOLVED → REOPENED
Resolution: FIXED → ---

Pushed by thunderbird@calypsoblue.org:
https://hg.mozilla.org/comm-central/rev/af9c8ba2c225
Produce a mozlint.json artifact for code-review bot to consume. rs=me

Status: REOPENED → RESOLVED
Closed: 1 year ago1 year ago
Resolution: --- → FIXED
Pushed by thunderbird@calypsoblue.org:
https://hg.mozilla.org/comm-central/rev/903fa1be48e0
Backed out changeset af9c8ba2c225 for mozlint errors. r=backout
https://hg.mozilla.org/comm-central/rev/a287b3c08ccb
Produce a mozlint.json artifact for code-review bot to consume. r=freaktechnik DONTBUILD
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: