1799542 - [wpt-sync] Sync PR 36829 - Reland "Only allow trusted events for light dismiss"

Status: RESOLVED FIXED

(Testing :: web-platform-tests, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 36829 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/36829
Details from upstream follow.

Mason Freed <[e-mail]> wrote:

Reland "Only allow trusted events for light dismiss"

This is a reland of commit 7e949f5b25185bc150afedadac93ade7780d2b0b

The [2] CL made some small changes to the
popover-attribute-basic.tentative.html test, adding a call to
getElementById. Since [2] was reported to cause flakiness on the
Mac bots, this CL wraps the tests in a window.onload. Hopefully this fixes the flakiness. I was unable to reproduce flakiness (in 100
iterations) locally on my Mac.

Patchset 1 shows the original CL, for reference.

ATTENTION SHERIFFS: if this CL causes flakiness, go ahead and revert
it again, but PLEASE file a bug with links to the flakes, so I can
track down what's going on.

[2] https://chromium-review.googlesource.com/c/chromium/src/+/4000687

Original change's description:

Only allow trusted events for light dismiss

Per the conversation at [1], only trusted (i.e. non-synthetic)
events should be used to trigger light dismiss behaviors.

[1] https://github.com/whatwg/html/issues/7785#issuecomment-1299403287

Bug: 1307772
Change-Id: Ia5da594997437a5a620dc2e2b9e928633deabd9f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4000687
Auto-Submit: Mason Freed \<[e-mail]>
Reviewed-by: Joey Arhar \<[e-mail]>
Commit-Queue: Joey Arhar \<[e-mail]>
Cr-Commit-Position: refs/heads/main@{#1067199}

Bug: 1307772
Change-Id: I62f3431bc1b9d667ed7006e79b7b8bee6a9f0ec3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4007175
Auto-Submit: Mason Freed \<[e-mail]>
Reviewed-by: Joey Arhar \<[e-mail]>
Commit-Queue: Mason Freed \<[e-mail]>
Commit-Queue: Joey Arhar \<[e-mail]>
Cr-Commit-Position: refs/heads/main@{#1068295}

Comment 1

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ca75ec466a9f
[wpt PR 36829] - Reland "Only allow trusted events for light dismiss", a=testonly

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Test result changes from PR not available.

Comment 3

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/ca75ec466a9f