Closed Bug 1799543 Opened 3 years ago Closed 3 years ago

[wpt-sync] Sync PR 36851 - Reland "Implement new dialog shadow focus behavior"

Categories

(Core :: DOM: Core & HTML, task, P4)

task

Tracking

()

RESOLVED FIXED
108 Branch
Tracking Status
firefox108 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 36851 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/36851
Details from upstream follow.

Joey Arhar <jarhar@chromium.org> wrote:

Reland "Implement new dialog shadow focus behavior"

This implements the new dialog initial focus behavior specified in these
changes:
https://github.com/whatwg/html/pull/7079
https://github.com/whatwg/html/pull/7284
https://github.com/whatwg/html/pull/7361
https://github.com/whatwg/html/pull/8174

The gist of the changes are:

  1. Use the DOM tree instead of the flat tree to search for an element to
    give initial focus.
  2. Don't traverse into shadow roots when looking for elements to give
    initial focus unless the shadow root has delegatesFocus.

This will stay experimental until I have also made the other changes for
dialog initial focus: https://github.com/whatwg/html/pull/8199
After those changes have been made as well, I will carefully enable the
flag by default.

Fixed: 383230, 670130, 1292852
Change-Id: If024ab0f22716c55b439e44b2298e39897ee844e

Reviewed-on: https://chromium-review.googlesource.com/4009903
WPT-Export-Revision: d9045e31382f4b516e47c03c991f9666c7ad9ef2

Component: web-platform-tests → DOM: Core & HTML
Product: Testing → Core
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/aeba6d224802 [wpt PR 36851] - Reland "Implement new dialog shadow focus behavior", a=testonly
Test result changes from PR not available.
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → 108 Branch
You need to log in before you can comment on or make changes to this bug.