179955 - Missing call nsIUnicodeEncoder::Finish

Status: RESOLVED WORKSFORME

(Core :: Internationalization, defect)

Description

[nhottanscp]

There are code which may need to call nsIUnicodeEncoder::Finish after the
conversion (see bug 179392). 

Here is a list of code which do not call Finish after Convert.
I did not check in detail so there may be cases which no change is needed. For
example, converting to system charset (I assume no stateful system charset), or
handling stream data.

http://lxr.mozilla.org/seamonkey/source/extensions/xmlextras/base/src/nsXMLHttpRequest.cpp#778
http://lxr.mozilla.org/seamonkey/source/embedding/browser/powerplant/source/UMacUnicode.cpp#157
http://lxr.mozilla.org/seamonkey/source/gfx/src/gtk/nsFontMetricsGTK.cpp#2080
http://lxr.mozilla.org/seamonkey/source/gfx/src/mac/nsUnicodeFontMappingMac.cpp#118
http://lxr.mozilla.org/seamonkey/source/gfx/src/os2/nsFontMetricsOS2.cpp#164
http://lxr.mozilla.org/seamonkey/source/gfx/src/ps/nsPostScriptObj.cpp#2186
http://lxr.mozilla.org/seamonkey/source/gfx/src/qt/nsFontMetricsQT.cpp#1846
http://lxr.mozilla.org/seamonkey/source/gfx/src/windows/nsFontMetricsWin.cpp#3853
http://lxr.mozilla.org/seamonkey/source/gfx/src/windows/nsFontMetricsWin.cpp#3877
http://lxr.mozilla.org/seamonkey/source/gfx/src/windows/nsFontMetricsWin.cpp#3902
http://lxr.mozilla.org/seamonkey/source/gfx/src/xlib/nsFontMetricsXlib.cpp#2260
http://lxr.mozilla.org/seamonkey/source/widget/src/gtk/nsClipboard.cpp#989
http://lxr.mozilla.org/seamonkey/source/widget/src/gtk/nsWindow.cpp#2343
http://lxr.mozilla.org/seamonkey/source/widget/src/mac/nsMacControl.cpp#420
http://lxr.mozilla.org/seamonkey/source/widget/src/cocoa/nsFilePicker.cpp#100
http://lxr.mozilla.org/seamonkey/source/widget/src/xlib/nsWindow.cpp#816
http://lxr.mozilla.org/seamonkey/source/mailnews/base/util/nsMsgUtf7Utils.cpp#115
http://lxr.mozilla.org/seamonkey/source/mailnews/import/src/nsImportService.cpp#374

Comment 1

[nhottanscp]

* filed as bug 180166
http://lxr.mozilla.org/seamonkey/source/mailnews/base/util/nsMsgUtf7Utils.cpp#115

* this is converting to ACP, no need to change
http://lxr.mozilla.org/seamonkey/source/mailnews/import/src/nsImportService.cpp#374

Comment 2

[Frank Tang]

I believe this is a NONE issue for GFX or widget because the target encoding
won't be ISO-2022-JP or HZ. I think this will be problem for any target encoding
which could be ISO-2022-JP, ISO-2022-CN, or HZ

Comment 3

[Roland Mainz]

Frank Tang wrote:
> I believe this is a NONE issue for GFX or widget because the target encoding
> won't be ISO-2022-JP or HZ. I think this will be problem for any target 
> encoding which could be ISO-2022-JP, ISO-2022-CN, or HZ

... but isn't it usefull to call |nsIUnicodeEncoder::Finish| for correctness (it
may not be neccesary for _now_ - but maybe we get encoders in the future which
rely on that) ?

Comment 4

[Henri Sivonen (:hsivonen)]

These files are gone.