Closed Bug 1799580 Opened 2 years ago Closed 2 years ago

Remove display: -moz-popup.

Categories

(Core :: Layout, task)

task

Tracking

()

RESOLVED FIXED
108 Branch
Tracking Status
firefox108 --- fixed

People

(Reporter: emilio, Assigned: emilio)

References

Details

Attachments

(1 file)

No description provided.

We already rely on it applying only to XULPopupElement's. Make it
explicit and remove the CSS value.

Assignee: nobody → emilio
Status: NEW → ASSIGNED
Pushed by ealvarez@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/fb0df93a4719
Remove display: -moz-popup. r=TYLin

Backed out for causing mochitest failures on win7

Flags: needinfo?(emilio)
Flags: needinfo?(emilio)
Pushed by ealvarez@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/713e6f0fbd20
Remove display: -moz-popup. r=TYLin

Backed out for causing failures on browser_history_after_appMenu.js

[task 2022-11-09T18:01:42.041Z] 18:01:42     INFO - TEST-START | browser/components/customizableui/test/browser_history_after_appMenu.js
[task 2022-11-09T18:02:27.053Z] 18:02:27     INFO - TEST-INFO | started process screenshot
[task 2022-11-09T18:02:27.110Z] 18:02:27     INFO - TEST-INFO | screenshot: exit 0
[task 2022-11-09T18:02:27.111Z] 18:02:27     INFO - Buffered messages logged at 18:01:42
[task 2022-11-09T18:02:27.111Z] 18:02:27     INFO - Entering test bound test_history_after_appMenu
[task 2022-11-09T18:02:27.112Z] 18:02:27     INFO - Checking if element has non-0 size
[task 2022-11-09T18:02:27.112Z] 18:02:27     INFO - TEST-PASS | browser/components/customizableui/test/browser_history_after_appMenu.js | The panel is closed to begin with. - "closed" == "closed" - 
[task 2022-11-09T18:02:27.113Z] 18:02:27     INFO - Buffered messages finished
[task 2022-11-09T18:02:27.114Z] 18:02:27     INFO - TEST-UNEXPECTED-FAIL | browser/components/customizableui/test/browser_history_after_appMenu.js | Test timed out - 
[task 2022-11-09T18:02:27.114Z] 18:02:27     INFO - Not taking screenshot here: see the one that was previously logged
[task 2022-11-09T18:02:27.115Z] 18:02:27     INFO - TEST-UNEXPECTED-FAIL | browser/components/customizableui/test/browser_history_after_appMenu.js | Uncaught exception received from previously timed out test - ViewShown listener on #appMenu-protonMainView not removed before the end of test
[task 2022-11-09T18:02:27.381Z] 18:02:27     INFO - GECKO(4816) | MEMORY STAT | vsize 1481MB | vsizeMaxContiguous 131MB | residentFast 447MB | heapAllocated 506MB
[task 2022-11-09T18:02:27.382Z] 18:02:27     INFO - TEST-OK | browser/components/customizableui/test/browser_history_after_appMenu.js | took 45337ms
Flags: needinfo?(emilio)

Bug 1799925 fixes that (via the NS_FRAME_IS_DIRTY fix, presumably)

Flags: needinfo?(emilio)
Pushed by ealvarez@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/d822ff58de6b
Remove display: -moz-popup. r=TYLin
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → 108 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: