1799690 - `./mach clang-format` fails: bootstrap gives 15.0.4 but mach requires 15.0.3

Status: RESOLVED FIXED

(Developer Infrastructure :: Lint and Formatting, defect)

Description

[Kagami Rosylight [:saschanaz] (they/them)]

> ./mach clang-format --outgoing
 0:04.76 Setting up artifact clang-tidy.tar.zst
 0:04.76 Using artifact from local cache: C:\Users\sasch\.mozbuild\toolchains\a7b8f5adc1919369-clang-tidy.tar.zst
 0:04.82 untarring "C:\Users\sasch\.mozbuild\clang-tools\clang-tidy.tar.zst"
 0:06.91 ERROR: You're using an old or incorrect version (clang-format version 15.0.4 (taskcluster-fdElb-6jR76Wxcy-XUBKzg)) of clang-format binary. Please update to a more recent one (at least > 15.0.3) by running: './mach bootstrap'

https://searchfox.org/mozilla-central/rev/b6d0ad6ba24b3d075e357e52160cd8fc7f911ba9/tools/clang-tidy/config.yaml#22 still points to 15.0.3.

Comment 1

[Kagami Rosylight [:saschanaz] (they/them)]

https://searchfox.org/mozilla-central/rev/b6d0ad6ba24b3d075e357e52160cd8fc7f911ba9/python/mozbuild/mozbuild/code_analysis/mach_commands.py#523-525 explicitly requires the pinned version although the error message implies newer versions are allowed.

Comment 2

[Kagami Rosylight [:saschanaz] (they/them)]

Not sure it's a regression, but let's see:

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1784202

:glandium, since you are the author of the regressor, bug 1784202, could you take a look? Also, could you set the severity field?

For more information, please visit auto_nag documentation.

Comment 4

[Mike Hommey [:glandium]]

Attachment: Bug 1799690 - Update clang-tidy version after clang update.

Comment 5

[BugBot [:suhaib / :marco/ :calixte]]

This bug has the keyword regression, so its type should be defect.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/bd8ff70b6fd4
Update clang-tidy version after clang update. r=firefox-build-system-reviewers,andi

Comment 8

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/bd8ff70b6fd4

Comment 9

[Intermittent Failures Robot]

1 failures in 3445 pushes (0.0 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• comm-central: 1

Platform and build breakdown:

• linux64: 1
  • debug: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1799690&startday=2022-11-07&endday=2022-11-13&tree=all