1799726 - [Thunderbird Telemetry] Add Probe to count number of oAuth accounts in profile

Status: RESOLVED FIXED

(Thunderbird :: Account Manager, task)

Description

[Andrei Hajdukewycz [:sancus]]

We should add a probe to count the number of oAuth accounts along with the provider, out of the major providers that we support. This will help us determine impact and how much support is necessary in case of oAuth issues with a particular provider, which happen on a regular basis.

Comment 1

[Sean Burke [:leftmostcat]]

Attachment: Bug 1799726 - add probe to count oauth2 accounts by provider. r=#thunderbird-reviewers

Comment 2

[Sean Burke [:leftmostcat]]

Attachment: data collection review

Comment 3

[Magnus Melin [:mkmelin]]

I wonder if we shouldn't just generalize the scope on this one a bit. It would be useful to know the distribution of authMethod in general. Also for SMTP which isn't currently accounted for in the patch.

Comment 4

[Sean Burke [:leftmostcat]]

A probe for auth method doesn't sound unreasonable, but that sounds like a separate probe/body of work. I think we definitely don't want to try to gather any details on mail servers for non-OAuth2 accounts, for one thing.

Comment 5

[Andrei Hajdukewycz [:sancus]]

Lets file a more general auth method probe as a follow up bug, I would like to get this in as quickly as possible so we can measure the uptake on the migration in Bug 1798875.

And I agree, we definitely will not be collecting data on mail server domains, absolutely not. That would have actual PII in it.

Comment 6

[Andrei Hajdukewycz [:sancus]]

Comment on attachment 9302731 [details]
data collection review

Good to go.

Data Review Form:

1. Is there or will there be documentation that describes the schema for the ultimate data set in a public, complete, and accurate way?

Yes, in the comm-central Scalars.yaml file.

2. Is there a control mechanism that allows the user to turn the data collection on and off?

Yes, using standard Telemetry opt-out.

3. If the request is for permanent data collection, is there someone who will monitor the data over time?

Yes, Andrei Hajdukewycz (:sancus) will.

4. Using the category system of data types on the Mozilla wiki, what collection type of data do the requested measurements fall under?

Category 2.

5. Is the data collection request for default-on or default-off?

Default on for all channels, countries, and locales.

6. Does the instrumentation include the addition of any new identifiers?

No.

7. Is the data collection covered by the existing Thunderbird privacy notice?

Yes.

8. Does the data collection use a third-party collection tool? If yes, escalate to legal.

No.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/a912be95f46a
add probe to count oauth2 accounts by provider. r=freaktechnik,mkmelin

Comment 8

[Andrei Hajdukewycz [:sancus]]

Comment on attachment 9302730 [details]
Bug 1799726 - add probe to count oauth2 accounts by provider. r=#thunderbird-reviewers

[Approval Request Comment]
Regression caused by (bug #): N/A
User impact if declined: N/A

Testing completed (on c-c, etc.): c-c

Risk to taking this patch (and alternatives if risky):
It's very unlikely this probe would cause any issue except itself not working.

Comment 9

[Rob Lemley [:rjl]]

Comment on attachment 9302730 [details]
Bug 1799726 - add probe to count oauth2 accounts by provider. r=#thunderbird-reviewers

[Triage Comment]
Approved for 102.5.0 per wsmwk via Matrix

Comment 10

[Rob Lemley [:rjl]]

Attachment: 1799726_esr102.patch

Rebased to comm-esr102. Ran ESLint and browser_accountTelemetry.js tests locally w/o issues.

Comment 11

[Martin Giger [:freaktechnik]]

Comment on attachment 9303482 [details] [diff] [review]
1799726_esr102.patch

Review of attachment 9303482 [details] [diff] [review]:
-----------------------------------------------------------------

Looks fine to me, I assume there were conflicts while rebasing that had to be resolved?

::: mail/components/telemetry/Scalars.yaml
@@ +176,5 @@
>        - "[e-mail]"
>      record_in_processes:
>        - 'main'
>  
> +

Extra new line

Comment 12

[Rob Lemley [:rjl]]

(In reply to Martin Giger [:freaktechnik] from comment #11)

Looks fine to me, I assume there were conflicts while rebasing that had to
be resolved?

The account telemetry is now in MailGlue.jsm rather than nsMsg3PaneWindow.js. Once I figured that out, the rest was dealing with lazy import differences and such.

Comment 13

[Rob Lemley [:rjl]]

Attachment: 1799726_esr102_v2.patch

Removed extra line from Scalars.yaml.

Comment 14

[Rob Lemley [:rjl]]

Comment on attachment 9303492 [details] [diff] [review]
1799726_esr102_v2.patch

[Triage Comment]
ESR102 version of same patch previously approved by wsmwk.

Comment 15

[Rob Lemley [:rjl]]

Thunderbird 102.5.0:
https://hg.mozilla.org/releases/comm-esr102/rev/b3bca04b7520