1799889 - [wpt-sync] Sync PR 36886 - [@container] Incorrect early out for closest ::part() container

Status: RESOLVED FIXED

(Core :: Layout, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 36886 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/36886
Details from upstream follow.

Rune Lillesveen <[e-mail]> wrote:

[@container] Incorrect early out for closest ::part() container

Pseudo elements must use the ultimate originating element. We
incorrectly re-used an ancestor for the part element inside the shadow
tree when a container was not found from the host and up.

Bug: 1382704
Change-Id: Ib00666520d5a929119ac8cec67d361da842b2a64
Reviewed-on: https://chromium-review.googlesource.com/4016368
WPT-Export-Revision: 98f42c63256c591e89b8546e24b4b3514d57f969

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=0a0d55ae19d766c4eb0db4231ada15dd90130747

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests and 11 subtests

Status Summary

Firefox

OK : 1
PASS : 5
FAIL : 6
ERROR: 1

Chrome

OK : 1
PASS : 10
FAIL : 1

Safari

OK : 1
PASS : 11

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

• /css/css-contain/container-queries/container-for-shadow-dom.html [wpt.fyi]: ERROR [GitHub], OK [Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows10-32-2004-qr-debug, Gecko-windows10-32-2004-qr-opt, Gecko-windows10-64-2004-qr-debug, Gecko-windows10-64-2004-qr-opt] (Chrome: OK, Safari: OK)
  • Match container in same tree, not walking flat tree ancestors: FAIL (Chrome: PASS, Safari: PASS)
  • Match container in ::part selector's originating element tree: FAIL (Chrome: PASS, Safari: PASS)
  • Match container in outer tree for :host::before: FAIL (Chrome: PASS, Safari: PASS)
  • Match container for ::before in ::part selector's originating element tree: FAIL (Chrome: PASS, Safari: PASS)
  • Match container for ::part selector's originating element tree for exportparts: FAIL (Chrome: PASS, Safari: PASS)
  • Should not match container inside shadow tree for ::part(): FAIL (Chrome: FAIL, Safari: PASS)

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2702c7c230e9
[wpt PR 36886] - [@container] Incorrect early out for closest ::part() container, a=testonly
https://hg.mozilla.org/integration/autoland/rev/d3a74bdd8084
[wpt PR 36886] - Update wpt metadata, a=testonly

Comment 4

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/2702c7c230e9
https://hg.mozilla.org/mozilla-central/rev/d3a74bdd8084