1799932 - Frequent crashes related to changing the extmap for mid

Status: RESOLVED FIXED

(Core :: WebRTC: Signaling, defect, P2)

Description

[Byron Campen [:bwc]]

I'm seeing stuff like the following fairly frequently on crash-stats:

https://crash-stats.mozilla.org/report/index/c8f28f85-44af-42a9-8080-ffc180221109

It is hard to search for these, since the top 5 frames are pretty generic.

I think this is just a case where libwebrtc is getting sad because we don't deregister the old extmap before registering the new one. This probably makes it pretty easy to cause tab crashes deliberately, so pretty high priority.

Comment 1

[Byron Campen [:bwc]]

https://treeherder.mozilla.org/jobs?repo=try&revision=3e18a58165206acd1b5f8065141b442d9818bf1d
https://treeherder.mozilla.org/jobs?repo=try&revision=3ab93069317d329a0c84d0ea4ef0f043a52a4ec1
https://treeherder.mozilla.org/jobs?repo=try&revision=8a92c05c6e16f00e55e0b80501fcdc9d16078e25

Comment 2

[Byron Campen [:bwc]]

Attachment: Bug 1799932: Test-case for bug. r?pehrsons

Comment 3

[Byron Campen [:bwc]]

Attachment: Bug 1799932: Ensure that we re-create the send audio stream if the extmap changes. r?pehrsons

Depends on D161816

Comment 4

[Byron Campen [:bwc]]

Try looks normal.

Comment 5

[Byron Campen [:bwc]]

Attachment: Bug 1799932: Disallow reuse of extmap ids in JSEP. r?mjf

Depends on D161817

Comment 6

[Byron Campen [:bwc]]

Try looks good.

https://treeherder.mozilla.org/jobs?repo=try&revision=f93281b93f891e4e7626d5f8e7581df5e80a8359
https://treeherder.mozilla.org/jobs?repo=try&revision=72e9e5038d00d7e57746ccc0d4d4e16729369bd0
https://treeherder.mozilla.org/jobs?repo=try&revision=dbd65c1f479493127f97335978792cb74b05b769

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/90d6fd913765
Test-case for bug. r=pehrsons,mjf
https://hg.mozilla.org/integration/autoland/rev/8620d07f8054
Ensure that we re-create the send audio stream if the extmap changes. r=pehrsons
https://hg.mozilla.org/integration/autoland/rev/ddda7a3ecb4e
Disallow reuse of extmap ids in JSEP. r=mjf

Comment 8

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/90d6fd913765
https://hg.mozilla.org/mozilla-central/rev/8620d07f8054
https://hg.mozilla.org/mozilla-central/rev/ddda7a3ecb4e