1799958 - [wpt-sync] Sync PR 36894 - Simplify RunWithUserGesture helper.

Status: RESOLVED FIXED

(Testing :: web-platform-tests, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 36894 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/36894
Details from upstream follow.

Chris Fredrickson <[e-mail]> wrote:

Simplify RunWithUserGesture helper.

It turns out that test_driver.bless already creates a button, so
there's no point in creating our own button as well. Next,
test_driver.bless already returns a promise, so we can just use that
instead of creating our own around it. Finally, all of the tests
unconditionally await the wrapped promise that we return, so we should
just take advantage of promise auto-flattening instead.

Change-Id: Ib6f36ac6bbecddf247282f31c10eae4af07d8f1e

Reviewed-on: https://chromium-review.googlesource.com/4017034
WPT-Export-Revision: d6a0bdd2891e698891bcd0f291dfe9f2bef1a46d

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

PR 36894 applied with additional changes from upstream: 5098f818e7fb02aa1c288b42085cc1b9dcda12cd, 72b8989a676d49507a16665ae534836d7121b9d1, 2b0e3c6158f6cf7d06937ed1010e1289fc4ef898, f9d5e9475ede2e2d0b0410c55c4b8618d7a4d9ef

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

PR 36894 applied with additional changes from upstream: 5098f818e7fb02aa1c288b42085cc1b9dcda12cd, 72b8989a676d49507a16665ae534836d7121b9d1, 2b0e3c6158f6cf7d06937ed1010e1289fc4ef898, f9d5e9475ede2e2d0b0410c55c4b8618d7a4d9ef, d86be3e36f0b24ab0632c2135e39bfdaa0aa42af, 5738d0254a247e349e08b73c53c4685167453d5c, fda7f3a6ff0c16957f59181cc86aaece404414e0, 21300c4874267d3942ef5b20f13f059c9d0822ff

Comment 3

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=c30e8506f73eaaa00595d1c40f2fe3e07fb7bf56

Comment 4

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 10 tests and 5 subtests

Status Summary

Firefox

OK : 8
PASS : 47
FAIL : 16
TIMEOUT: 4
NOTRUN : 3

Chrome

OK : 9
PASS : 2
FAIL : 63
ERROR : 1

Safari

OK : 10
PASS : 37
FAIL : 31

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

Firefox-only Failures

• /storage-access-api/requestStorageAccess-insecure.sub.window.html [wpt.fyi]: TIMEOUT
• /storage-access-api/requestStorageAccess-non-fully-active.sub.https.window.html [wpt.fyi]: TIMEOUT

New Tests That Don't Pass

• /storage-access-api/hasStorageAccess-insecure.sub.window.html [wpt.fyi]
  • [top-level-context] document.hasStorageAccess() should be disallowed in insecure contexts: FAIL (Chrome: FAIL, Safari: FAIL)
  • [same-origin-frame] document.hasStorageAccess() should be disallowed in insecure contexts: FAIL (Chrome: FAIL, Safari: FAIL)
  • [cross-origin-frame] document.hasStorageAccess() should be disallowed in insecure contexts: FAIL (Chrome: FAIL, Safari: PASS)
  • [nested-same-origin-frame] document.hasStorageAccess() should be disallowed in insecure contexts: FAIL (Chrome: FAIL, Safari: FAIL)
  • [nested-cross-origin-frame] document.hasStorageAccess() should be disallowed in insecure contexts: FAIL (Chrome: FAIL, Safari: PASS)
• /storage-access-api/requestStorageAccess-cross-origin-iframe.sub.https.window.html [wpt.fyi]
  • [cross-origin-frame] document.requestStorageAccess() should be resolved when called properly with a user gesture: FAIL (Chrome: FAIL, Safari: FAIL)
  • [cross-origin-frame] document.requestStorageAccess() should be rejected with a NotAllowedError without permission grant: FAIL (Chrome: FAIL, Safari: FAIL)
  • [cross-origin-frame] document.requestStorageAccess() should be rejected with a NotAllowedError with denied permission: FAIL (Chrome: FAIL, Safari: FAIL)
• /storage-access-api/requestStorageAccess-insecure.sub.window.html [wpt.fyi]: TIMEOUT (Chrome: OK, Safari: OK)
  • [non-fully-active] document.requestStorageAccess() should reject when run in a detached frame: TIMEOUT (Chrome: FAIL, Safari: FAIL)
  • [non-fully-active] document.requestStorageAccess() should reject when run in a detached DOMParser document: NOTRUN (Chrome: FAIL, Safari: FAIL)
  • [top-level-context] document.requestStorageAccess() should be rejected when called with a user gesture in insecure context: NOTRUN (Chrome: FAIL, Safari: FAIL)
• /storage-access-api/requestStorageAccess-nested-cross-origin-iframe.sub.https.window.html [wpt.fyi]
  • [nested-cross-origin-frame] document.requestStorageAccess() should be resolved when called properly with a user gesture: FAIL (Chrome: FAIL, Safari: FAIL)
  • [nested-cross-origin-frame] document.requestStorageAccess() should be rejected with a NotAllowedError without permission grant: FAIL (Chrome: FAIL, Safari: FAIL)
  • [nested-cross-origin-frame] document.requestStorageAccess() should be rejected with a NotAllowedError with denied permission: FAIL (Chrome: FAIL, Safari: FAIL)
• /storage-access-api/requestStorageAccess-nested-same-origin-iframe.sub.https.window.html [wpt.fyi]
  • [nested-same-origin-frame] document.requestStorageAccess() should be resolved when called properly with a user gesture: FAIL (Chrome: FAIL, Safari: FAIL)
• /storage-access-api/requestStorageAccess-non-fully-active.sub.https.window.html [wpt.fyi]: TIMEOUT (Chrome: OK, Safari: OK)
  • [non-fully-active] document.requestStorageAccess() should not resolve when run in a detached frame: TIMEOUT (Chrome: FAIL, Safari: FAIL)
  • [non-fully-active] document.requestStorageAccess() should not resolve when run in a detached DOMParser document: NOTRUN (Chrome: FAIL, Safari: FAIL)
• /storage-access-api/requestStorageAccess.sub.https.window.html [wpt.fyi]
  • [top-level-context] document.requestStorageAccess() should be resolved when called properly with a user gesture: FAIL (Safari: FAIL)
• /storage-access-api/storageAccess.testdriver.sub.html [wpt.fyi]
  • Set up storage access rules: FAIL (Chrome: FAIL, Safari: FAIL)
  • [third-party-blocked-on-first-party-site] Cookie access is allowed: false: FAIL (Chrome: FAIL, Safari: FAIL)
  • [third-party-blocked-all] Cookie access is allowed: false: FAIL (Chrome: FAIL, Safari: FAIL)

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1e9deb5a71d0
[wpt PR 36894] - Simplify RunWithUserGesture helper., a=testonly
https://hg.mozilla.org/integration/autoland/rev/85c883a2fc0e
[wpt PR 36894] - Update wpt metadata, a=testonly

Comment 6

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/1e9deb5a71d0
https://hg.mozilla.org/mozilla-central/rev/85c883a2fc0e