1799997 - [OnboardingVideo] Update autoPlay pref to support tratement branch with autoPlay true

Status: VERIFIED FIXED

(Firefox :: Messaging System, enhancement, P1)

Description

[Punam Dahiya [:pdahiya]]

Bu default Firefoxs Block AutoPlay. To support treatment branch, with option autoPlay as true, we need to set pref Services.prefs.setIntPref("media.autoplay.default", 0); when autoPlay in content.video_container is true

See https://phabricator.services.mozilla.com/D161233#inline-890079

Comment 1

[Shane Hughes [:aminomancer]]

I'm not sure if we need to set the default permission (which would affect video players everywhere), we may be able to just set the permission for this one about:welcome principal. SitePermissions will not work since it's an about page, but it has a non-expanded content principal so I think it should be possible for it to have an autoplay permission. If we can't handle it in the react component, we probably can in AboutWelcomeChild.jsm. I'll do some trial & error in the meantime

Comment 2

[Shane Hughes [:aminomancer]]

Services.perms.addFromPrincipal(
  gBrowser.selectedBrowser.contentPrincipal,
  "autoplay-media",
  Services.perms.ALLOW_ACTION,
  Services.perms.EXPIRE_SESSION
);

Comment 3

[Shane Hughes [:aminomancer]]

Attachment: Bug 1799997 - Support media autoplay on about:welcome. r=pdahiya

Add the autoplay permission to about:welcome through the default
permissions file. If we add onboarding videos to other messaging
surfaces (like the multistage spotlight for existing user onboarding),
it won't be necessary to add permissions since autoplay is only blocked
in content. This also incidentally reduces the severity of bug 1799935.
The error still happens, breaking the video controls. But since the
video autoplays, the bug is only noticeable if you try to interact with
the video controls. Otherwise, the video will just play on its own and
advance to the next screen when it's finished.

Comment 4

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/26a6cf64b6d9

Comment 5

[Simona Rosu [:srosu], Ecosystem QA]

I‘ve verified this enhancement using the latest Firefox Nightly 109.0a1 (Build ID: 20221204094021) on Windows 10 x64, macOS 11.7.1. On Ubuntu 22.04, I’m blocked from verifying due to Bug 1801038.

• After following the steps from this Test Plan, I can confirm that the video from the second screen of the “about:welcome” page doesn’t auto-play.