Closed Bug 1800004 Opened 2 years ago Closed 2 years ago

[wpt-sync] Sync PR 36899 - Refactor storage-access-api helpers for clarity/simplicity.

Categories

(Testing :: web-platform-tests, task, P4)

Product:
Testing
Component:
web-platform-tests
Type:
task

Tracking

(firefox108 fixed)

Status:
RESOLVED FIXED
Milestone:
108 Branch
Tracking Flags:
Tracking Status
firefox108 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 36899 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/36899
Details from upstream follow.

Chris Fredrickson <cfredric@chromium.org> wrote:

Refactor storage-access-api helpers for clarity/simplicity.

This CL doesn't change any behavior, but rearranges some helpers and
removes/renames some variables to try to make the helpers clearer.

Change-Id: Ic87a9baeb99b4a04a4d467c2f1c2251e863e2d9c

Reviewed-on: https://chromium-review.googlesource.com/4016856
WPT-Export-Revision: e1dd2cd96a65cf9622a5c069b5f02e63d87ef1bb

PR 36899 applied with additional changes from upstream: 5098f818e7fb02aa1c288b42085cc1b9dcda12cd, 72b8989a676d49507a16665ae534836d7121b9d1, 2b0e3c6158f6cf7d06937ed1010e1289fc4ef898, f9d5e9475ede2e2d0b0410c55c4b8618d7a4d9ef

CI Results

Ran 9 Firefox configurations based on mozilla-central, and Safari on GitHub CI

Total 5 tests and 5 subtests

Status Summary

Firefox

OK : 3
PASS : 47
FAIL : 8
TIMEOUT: 4
NOTRUN : 4

Safari

OK : 5
PASS : 38
FAIL : 23

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

  • /storage-access-api/hasStorageAccess.sub.window.html [wpt.fyi]
    • [top-level-context] document.hasStorageAccess() should be disallowed in insecure contexts: FAIL (Safari: FAIL)
    • [same-origin-frame] document.hasStorageAccess() should be disallowed in insecure contexts: FAIL (Safari: FAIL)
    • [cross-origin-frame] document.hasStorageAccess() should be disallowed in insecure contexts: FAIL (Safari: PASS)
    • [nested-same-origin-frame] document.hasStorageAccess() should be disallowed in insecure contexts: FAIL (Safari: FAIL)
    • [nested-cross-origin-frame] document.hasStorageAccess() should be disallowed in insecure contexts: FAIL (Safari: PASS)
  • /storage-access-api/requestStorageAccess.sub.https.window.html [wpt.fyi]: TIMEOUT (Safari: OK)
    • [non-fully-active] document.requestStorageAccess() should not resolve when run in a detached frame: TIMEOUT (Safari: FAIL)
    • [non-fully-active] document.requestStorageAccess() should not resolve when run in a detached DOMParser document: NOTRUN (Safari: FAIL)
    • [top-level-context] document.requestStorageAccess() should be resolved when called properly with a user gesture: NOTRUN (Safari: PASS)
  • /storage-access-api/requestStorageAccess.sub.window.html [wpt.fyi]: TIMEOUT (Safari: OK)
    • [non-fully-active] document.requestStorageAccess() should reject when run in a detached frame: TIMEOUT (Safari: FAIL)
    • [non-fully-active] document.requestStorageAccess() should reject when run in a detached DOMParser document: NOTRUN (Safari: FAIL)
    • [top-level-context] document.requestStorageAccess() should be rejected when called with a user gesture in insecure context: NOTRUN (Safari: FAIL)
  • /storage-access-api/storageAccess.testdriver.sub.html [wpt.fyi]
    • Set up storage access rules: FAIL (Safari: FAIL)
    • [third-party-blocked-on-first-party-site] Cookie access is allowed: false: FAIL (Safari: FAIL)
    • [third-party-blocked-all] Cookie access is allowed: false: FAIL (Safari: FAIL)
Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/4fedf418efdd
[wpt PR 36899] - Refactor storage-access-api helpers for clarity/simplicity., a=testonly
https://hg.mozilla.org/integration/autoland/rev/ef4ad80f957b
[wpt PR 36899] - Update wpt metadata, a=testonly

https://hg.mozilla.org/mozilla-central/rev/4fedf418efdd
https://hg.mozilla.org/mozilla-central/rev/ef4ad80f957b

Status: NEW → RESOLVED
Closed: 2 years ago
status-firefox108: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 108 Branch
You need to log in before you can comment on or make changes to this bug.