Closed Bug 1800012 Opened 3 years ago Closed 3 years ago

[wpt-sync] Sync PR 36901 - Add OpusEncoderConfig

Categories

(Testing :: web-platform-tests, task, P4)

Product:
Testing
Component:
web-platform-tests
Type:
task

Tracking

(firefox109 fixed)

Status:
RESOLVED FIXED
Milestone:
109 Branch
Tracking Flags:
Tracking Status
firefox109 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 36901 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/36901
Details from upstream follow.

Thomas Guilbert <tguilbert@chromium.org> wrote:

Add OpusEncoderConfig

This CL adds various Opus encoder configuration knobs, as defined by
the recent additions to the WebCodec spec.

See the following:
https://w3c.github.io/webcodecs/
https://www.w3.org/TR/webcodecs-opus-codec-registration/

Bug: 1372152
Change-Id: I9a838596a50e4dfb7e43339e664aa18790b2ab39
Reviewed-on: https://chromium-review.googlesource.com/3995495
WPT-Export-Revision: f2a1439aa1dc841149d2cf7352fc3d30bbae9f94

CI Results

Ran 9 Firefox configurations based on mozilla-central, and Firefox, and Chrome on GitHub CI

Total 3 tests and 23 subtests

Status Summary

Firefox

OK : 2
FAIL : 42
ERROR: 1

Chrome

OK : 3
PASS : 41
FAIL : 22

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

  • /webcodecs/audio-encoder-config.https.any.worker.html [wpt.fyi]
    • Test that AudioEncoder.isConfigSupported() rejects invalid config:Emtpy codec: FAIL (Chrome: PASS)
    • Test that AudioEncoder.isConfigSupported() rejects invalid config:Unrecognized codec: FAIL (Chrome: PASS)
    • Test that AudioEncoder.isConfigSupported() rejects invalid config:Sample rate is too small: FAIL (Chrome: PASS)
    • Test that AudioEncoder.isConfigSupported() rejects invalid config:Sample rate is too large: FAIL (Chrome: PASS)
    • Test that AudioEncoder.isConfigSupported() rejects invalid config:Too few channels: FAIL (Chrome: PASS)
    • Test that AudioEncoder.isConfigSupported() rejects invalid config:Way too many channels: FAIL (Chrome: PASS)
    • Test that AudioEncoder.isConfigSupported() rejects invalid config:Bit rate too big: FAIL (Chrome: PASS)
    • Test that AudioEncoder.isConfigSupported() rejects invalid config:Opus complexity too big: FAIL (Chrome: FAIL)
    • Test that AudioEncoder.isConfigSupported() rejects invalid config:Opus packetlossperc too big: FAIL (Chrome: FAIL)
    • Test that AudioEncoder.isConfigSupported() rejects invalid config:Opus frame duration too small: FAIL (Chrome: FAIL)
    • Test that AudioEncoder.isConfigSupported() rejects invalid config:Opus frame duration too big: FAIL (Chrome: FAIL)
    • Test that AudioEncoder.isConfigSupported() rejects invalid config:Invalid Opus frameDuration: FAIL (Chrome: FAIL)
    • Test that AudioEncoder.isConfigSupported() doesn't support config:Too many channels: FAIL (Chrome: PASS)
    • Test that AudioEncoder.isConfigSupported() doesn't support config:Bitrate is too low: FAIL (Chrome: PASS)
    • AudioEncoder.isConfigSupported() supports:{"codec":"opus","sampleRate":8000,"numberOfChannels":1}: FAIL (Chrome: PASS)
    • AudioEncoder.isConfigSupported() supports:{"codec":"opus","sampleRate":48000,"numberOfChannels":2}: FAIL (Chrome: PASS)
    • AudioEncoder.isConfigSupported() supports:{"codec":"opus","sampleRate":48000,"numberOfChannels":2,"bitrate":128000,"bogus":123}: FAIL (Chrome: PASS)
    • AudioEncoder.isConfigSupported() supports:{"codec":"opus","sampleRate":48000,"numberOfChannels":2,"opus":{"complexity":5,"frameDuration":20000,"packetlossperc":10,"useinbandfec":true}}: FAIL (Chrome: FAIL)
    • AudioEncoder.isConfigSupported() supports:{"codec":"opus","sampleRate":48000,"numberOfChannels":2,"opus":{"format":"opus","complexity":10,"frameDuration":60000,"packetlossperc":20,"usedtx":true,"bogus":456}}: FAIL (Chrome: FAIL)
    • AudioEncoder.isConfigSupported() supports:{"codec":"opus","sampleRate":48000,"numberOfChannels":2,"opus":{}}: FAIL (Chrome: FAIL)
  • /webcodecs/audio-encoder-config.https.any.html [wpt.fyi]
    • Test that AudioEncoder.isConfigSupported() rejects invalid config:Emtpy codec: FAIL (Chrome: PASS)
    • Test that AudioEncoder.isConfigSupported() rejects invalid config:Unrecognized codec: FAIL (Chrome: PASS)
    • Test that AudioEncoder.isConfigSupported() rejects invalid config:Sample rate is too small: FAIL (Chrome: PASS)
    • Test that AudioEncoder.isConfigSupported() rejects invalid config:Sample rate is too large: FAIL (Chrome: PASS)
    • Test that AudioEncoder.isConfigSupported() rejects invalid config:Too few channels: FAIL (Chrome: PASS)
    • Test that AudioEncoder.isConfigSupported() rejects invalid config:Way too many channels: FAIL (Chrome: PASS)
    • Test that AudioEncoder.isConfigSupported() rejects invalid config:Bit rate too big: FAIL (Chrome: PASS)
    • Test that AudioEncoder.isConfigSupported() rejects invalid config:Opus complexity too big: FAIL (Chrome: FAIL)
    • Test that AudioEncoder.isConfigSupported() rejects invalid config:Opus packetlossperc too big: FAIL (Chrome: FAIL)
    • Test that AudioEncoder.isConfigSupported() rejects invalid config:Opus frame duration too small: FAIL (Chrome: FAIL)
    • Test that AudioEncoder.isConfigSupported() rejects invalid config:Opus frame duration too big: FAIL (Chrome: FAIL)
    • Test that AudioEncoder.isConfigSupported() rejects invalid config:Invalid Opus frameDuration: FAIL (Chrome: FAIL)
    • Test that AudioEncoder.isConfigSupported() doesn't support config:Too many channels: FAIL (Chrome: PASS)
    • Test that AudioEncoder.isConfigSupported() doesn't support config:Bitrate is too low: FAIL (Chrome: PASS)
    • AudioEncoder.isConfigSupported() supports:{"codec":"opus","sampleRate":8000,"numberOfChannels":1}: FAIL (Chrome: PASS)
    • AudioEncoder.isConfigSupported() supports:{"codec":"opus","sampleRate":48000,"numberOfChannels":2}: FAIL (Chrome: PASS)
    • AudioEncoder.isConfigSupported() supports:{"codec":"opus","sampleRate":48000,"numberOfChannels":2,"bitrate":128000,"bogus":123}: FAIL (Chrome: PASS)
    • AudioEncoder.isConfigSupported() supports:{"codec":"opus","sampleRate":48000,"numberOfChannels":2,"opus":{"complexity":5,"frameDuration":20000,"packetlossperc":10,"useinbandfec":true}}: FAIL (Chrome: FAIL)
    • AudioEncoder.isConfigSupported() supports:{"codec":"opus","sampleRate":48000,"numberOfChannels":2,"opus":{"format":"opus","complexity":10,"frameDuration":60000,"packetlossperc":20,"usedtx":true,"bogus":456}}: FAIL (Chrome: FAIL)
    • AudioEncoder.isConfigSupported() supports:{"codec":"opus","sampleRate":48000,"numberOfChannels":2,"opus":{}}: FAIL (Chrome: FAIL)
  • /webcodecs/audio-encoder.https.any.html [wpt.fyi]: ERROR (Chrome: OK)
    • Simple audio encoding: FAIL (Chrome: PASS)
    • Encode audio with negative timestamp: FAIL (Chrome: PASS)
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/9afeeccded90 [wpt PR 36901] - Add OpusEncoderConfig, a=testonly https://hg.mozilla.org/integration/autoland/rev/239dadb17652 [wpt PR 36901] - Update wpt metadata, a=testonly

https://hg.mozilla.org/mozilla-central/rev/9afeeccded90
https://hg.mozilla.org/mozilla-central/rev/239dadb17652

Status: NEW → RESOLVED
Closed: 3 years ago
status-firefox109: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 109 Branch
You need to log in before you can comment on or make changes to this bug.