1800033 - Intermittent toolkit/components/telemetry/tests/unit/test_UtilityScalars.js | application crashed [@ mozilla::ipc::UtilityProcessImpl::Init(int, char**)]

Status: RESOLVED FIXED

(Core :: Security: Process Sandboxing, defect)

Description

[Treeherder Bug Filer]

Filed by: mkmelin [at] iki.fi
Parsed log: https://treeherder.mozilla.org/logviewer?job_id=396113291&repo=comm-central
Full log: https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/Wz-ruXBFT1aWv2lb1hbzvQ/runs/0/artifacts/public/logs/live_backing.log

---

Comment 1

[Intermittent Failures Robot]

2 failures in 3445 pushes (0.001 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• comm-central: 2

Platform and build breakdown:

• windows10-32-2004-qr: 1
  • opt: 1
• windows10-64-2004-shippable-qr: 1
  • opt: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1800033&startday=2022-11-07&endday=2022-11-13&tree=all

Comment 2

[Magnus Melin [:mkmelin]]

Mozilla crash reason: MOZ_CRASH(Unable to preload module) - https://searchfox.org/mozilla-central/rev/3d01e045479a6e5237958bd9aa8eb64306e1f48a/ipc/glue/UtilityProcessImpl.cpp#30. Looks like this is from bug 1797301 then - https://hg.mozilla.org/mozilla-central/rev/f8406f212dc308033f6454e07be7aea0aaa3646b

Any ideas?

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1797301

Comment 4

[Intermittent Failures Robot]

17 failures in 3589 pushes (0.005 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• comm-central: 17

Platform and build breakdown:

• windows10-32-2004-shippable-qr: 4
  • opt: 4
• windows10-64-2004-shippable-qr: 5
  • opt: 5
• windows10-32-2004-qr: 3
  • opt: 2
  • debug: 1
• windows10-64-2004-qr: 4
  • opt: 3
  • debug: 1
• macosx1015-64-qr: 1
  • opt: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1800033&startday=2022-11-14&endday=2022-11-20&tree=all

Comment 5

[:gerard-majax]

No ?

Comment 6

[:gerard-majax]

macosx1015-64-qr: 1

    opt: 1

The code is not used on macOS, I dont see how it could exists there.

Comment 7

[:gerard-majax]

This is all failing only on comm-central

Comment 8

[Magnus Melin [:mkmelin]]

Yes, looks like basically perma fail on windows. see the X1 failures e.g. at https://treeherder.mozilla.org/jobs?repo=comm-central&revision=6159998bfa02d443a2ebf3e4104c4cd63a26f77f

Comment 9

[Magnus Melin [:mkmelin]]

And here is one for debug: https://treeherder.mozilla.org/logviewer?job_id=397151001&repo=comm-central&lineNumber=3920

What library load could be failing?

Comment 10

[:gerard-majax]

ipc/glue/UtilityAudioDecoderParent.cpp:76

Comment 11

[:gerard-majax]

I dont know where that is, there is nothing on searchfox: https://searchfox.org/comm-central/source/ipc/glue/UtilityAudioDecoderParent.cpp

Comment 12

[:gerard-majax]

The best I get is https://searchfox.org/comm-central/rev/cc5837b209537d99febe8d64eef7d9a76807fe62/mozilla/ipc/glue/UtilityAudioDecoderParent.cpp#69-76 so line 76 is the end of the function, not sure which one it is. Are those libs even available on comm-central ?

Comment 13

[Magnus Melin [:mkmelin]]

Thanks, looks like we need to package those like https://searchfox.org/mozilla-central/rev/83b86005c6913c2062419efb8aabdf2e683aa47f/browser/installer/package-manifest.in#150

For the library loads in UtilityAudioDecoderParent.cpp, that ifdef probably should be conditional on MOZ_FFVPX

Comment 14

[:gerard-majax]

(In reply to Magnus Melin [:mkmelin] from comment #13)

Thanks, looks like we need to package those like https://searchfox.org/mozilla-central/rev/83b86005c6913c2062419efb8aabdf2e683aa47f/browser/installer/package-manifest.in#150

For the library loads in UtilityAudioDecoderParent.cpp, that ifdef probably should be conditional on MOZ_FFVPX

Can you give a try to if defined(XP_WIN) && defined(MOZ_FFPVX) then ? If it fixes, I can review that quickly. I'm focused on some quite urgent issue with debug symbols on Snap, so spinning up a comm-central build etc would likely take me too much time to confirm

Comment 15

[Magnus Melin [:mkmelin]]

Yep, I'll see if I can get it to work

Comment 16

[Magnus Melin [:mkmelin]]

Attachment: Bug 1800033 - package mozavutil+mozavcodec for mail. r=#thunderbird-reviewers

Comment 17

[Magnus Melin [:mkmelin]]

Attachment: Bug 1800033 - mozavcodec and mozavutil should be ifdef MOZ_FFPVX. r=gerard-majax

Comment 18

[Chris H-C :chutten]

Re-componenting based on regressing bug.

Comment 19

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/41bebff09700
mozavcodec and mozavutil should be ifdef MOZ_FFPVX. r=gerard-majax DONTBUILD

Comment 20

[Noemi Erli[:noemi_erli]]

Backed out changeset 41bebff09700 (Bug 1800033) for causing failures in browser_utility_audioDecodeCrash.js CLOSED TREE

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&collapsedPushes=842382&selectedTaskRun=Mklo1n1VQR20XyE4o1ur6w.0&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=98ad3f08cb4cd63517340df5607f88b2cb0813e5&searchStr=bc

Log: https://treeherder.mozilla.org/logviewer?job_id=397439019&repo=autoland&lineNumber=10035

Backout: https://hg.mozilla.org/integration/autoland/rev/17a7f82366276081b22f16184e69a2cb99f747db

Comment 21

[:gerard-majax]

From the error it looks like decoding is happening in the content process: TEST-UNEXPECTED-FAIL | ipc/glue/test/browser/browser_utility_audioDecodeCrash.js | playback https://example.com/browser/ipc/glue/test/browser/small-shot.mp3 was from decoder 'ffmpeg audio decoder', expected 'Utility Generic' - false == true - got false, expected true (operator ==)

This code would verify if it's on Generic or WMF process: https://searchfox.org/mozilla-central/rev/05f486c76f84830041e51b7c68e3e697dc768454/ipc/glue/test/browser/head.js#89-91, but being in the content process is symptom of something else.

Comment 22

[:gerard-majax]

Ok, it's a simple typo in the MOZ_FFPVX usage that should have been MOZ_FFVPX.

Comment 23

[:gerard-majax]

with the current patch: https://treeherder.mozilla.org/jobs?repo=try&revision=1262d40b631d88b781001f7ac41453f9b1d44434
with the correct define: https://treeherder.mozilla.org/jobs?repo=try&revision=32d40588f385ee15dda8116c36eda72c0d031e71

Comment 24

[Magnus Melin [:mkmelin]]

Hmm, the correct one doesn't look happy either.

Comment 25

[:gerard-majax]

(In reply to Magnus Melin [:mkmelin] from comment #24)

Hmm, the correct one doesn't look happy either.

It's all green, I dont know what you expect for successs? ASAN failures are expected, it is supposed to be skipped, but my try ran it anyway

Comment 26

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6c75b4aa4b74
mozavcodec and mozavutil should be ifdef MOZ_FFPVX. r=gerard-majax

Comment 27

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/6c75b4aa4b74

Comment 28

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/db00b84f4fee
package mozavutil+mozavcodec for mail. r=aleca

Comment 29

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:mkmelin, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox108 to wontfix.

For more information, please visit auto_nag documentation.

Comment 30

[Intermittent Failures Robot]

11 failures in 3888 pushes (0.003 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• comm-central: 11

Platform and build breakdown:

• windows10-32-2004-qr: 4
  • opt: 4
• windows10-64-2004-shippable-qr: 3
  • opt: 3
• linux1804-64-qr: 1
  • opt: 1
• windows10-32-2004-shippable-qr: 1
  • opt: 1
• windows10-64-2004-qr: 2
  • opt: 1
  • debug: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1800033&startday=2022-11-21&endday=2022-11-27&tree=all