1800084 - Empty formAutofillGroupBox not hidden in Privacy preferences

Status: RESOLVED FIXED

(Firefox :: Settings UI, defect, P3)

Description

[Henry Wilkes (they/them) [:henry-x]]

The #formAutofillGroupBox groupbox in the Privacy pane is not hidden when it has no children.

I noticed this when going through with a screen reader (Orca) the empty groupbox was announced as "blank". From a visual perspective, this creates an extra space between the "Logins & Passwords" and "History" preferences.

I think this is where the groupbox gets shown https://searchfox.org/mozilla-central/rev/12a18f7e112a4dcf88d8441d439b84144bfbe9a3/browser/components/preferences/preferences.js#425 It might benefit from an additional condition to check that it has some content.

Note, this is mostly copied from tor browser (https://gitlab.torproject.org/tpo/applications/tor-browser/-/issues/41396), but it effects firefox as well.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The severity field for this bug is set to S4. However, the accessibility severity is higher, [access-s3].
:jaws, could you consider increasing the severity?

For more information, please visit auto_nag documentation.

Comment 2

[Henry Wilkes (they/them) [:henry-x]]

I think this can be closed since the new config approach dropped #formAutofillGroupBox and seems to have logic to handle hiding the groups when they have no visible children.