1800187 - Update libpixman to release 0.42.2

Status: RESOLVED FIXED

(Core :: Graphics, task)

Description

[Ryan VanderMeulen [:RyanVM]]

We've already cherry-picked the fix for CVE-2022-44638 over in bug 1799748, but we're still behind upstream. Notably, release 0.42.0 brought in AArch64 SIMD optimizations which we can utilize on Linux and Android.

https://lists.freedesktop.org/archives/pixman/2022-October/004993.html

Green on Try:
https://treeherder.mozilla.org/jobs?repo=try&revision=e51952c38cbaa50100b2b93580fa4a538ffb0bdc

Comment 1

[Ryan VanderMeulen [:RyanVM]]

Attachment: Bug 1800187 - Part 0: Clean up pixman patches. r=jfkthame

Removes patches which are no longer being applied to our import and
updates the patches that are applied to the current upstream.

Comment 2

[Ryan VanderMeulen [:RyanVM]]

Attachment: Bug 1800187 - Part 1: Update libpixman to version 0.42.2. r=jfkthame

Depends on D161867

Comment 3

[Ryan VanderMeulen [:RyanVM]]

Attachment: Bug 1800187 - Part 2: Refactor libpixman moz.build file. r=jfkthame

• Remove workaround for a long-fixed LLVM bug
• Remove extra flags on pixman-mmx.c
• Remove unneeded -Winline flags
• Drop SIMD exceptions for macOS
• Use correct MMX define
• Enable all SIMD optimizations for Intel builds
• Clean up platform-specific logic
• Enable aarch64 optimizations on Android & Linux

Besides removing a lot of old cruft and improving general readability, this
also re-enables MMX optimizations (the define changed upstream and wasn't
updated in moz.build to reflect that) along with unconditionally compiling
with all available Intel SIMD optimization levels. Pixman does runtime CPU
feature detection, so this should be safe. It also enables AArch64
optimizations on Android and Linux.

Depends on D161868

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/605c2361d100
Part 0: Clean up pixman patches. r=jfkthame
https://hg.mozilla.org/integration/autoland/rev/5e8e0f2f9c55
Part 1: Update libpixman to version 0.42.2. r=jfkthame
https://hg.mozilla.org/integration/autoland/rev/09cc2e3341e0
Part 2: Refactor libpixman moz.build file. r=jfkthame

Comment 5

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/605c2361d100
https://hg.mozilla.org/mozilla-central/rev/5e8e0f2f9c55
https://hg.mozilla.org/mozilla-central/rev/09cc2e3341e0