180019 - mailviews: if you cancel when trying to create a custom mail view, it leaves the picker in a bad state

Status: VERIFIED FIXED

(SeaMonkey :: MailNews: Message Display, defect)

Description

[(not reading, please use [e-mail] instead)]

mailviews:  if you cancel when trying to create a custom mail view, it leaves
the picker in a bad state

the picker is left in the "Customize" state.

my guess is we normally pick the view you were to create, but if you cancel, we
should pick the one you had.

screen shot on the way...

Comment 1

[(not reading, please use [e-mail] instead)]

Attachment: screen shot

Comment 2

[laurel]

*** Bug 179283 has been marked as a duplicate of this bug. ***

Comment 3

[(not reading, please use [e-mail] instead)]

Attachment: patch

Comment 4

[(not reading, please use [e-mail] instead)]

I also fixed it so if you choose the same view (as previously chosen) we don't 
clear out the quick search text.

Comment 5

[(not reading, please use [e-mail] instead)]

fixed

Comment 6

[[e-mail]]

Seth, you're making work for yourself with all those variables.
I've updated my patch in bug 179050 which incidentally simplifies this code.

Comment 7

[[e-mail]]

Actually there's a sneakier way of doing it which means that the menulist value
never changes, but I won't confuse you with the details.

Comment 8

[(not reading, please use [e-mail] instead)]

there's another edge case I need to fix:

if you do Customize..., and then hit ok immediately, it sticks on Customize...

working on it now...

Comment 9

[jglick]

Remaining: Msg Views dialogs are non-modal to the Main Mail Window, so if i open
the Msg Views dialog, but then click back to the Main Mail Window, the
'customize' option is still showing. If the Main Mail Window gets focus, is it
possible to switch the View back to its previous selection?

Should that be a sep bug?

Comment 10

[[e-mail]]

Seth, does my patch in bug 179050 not fix these?

Comment 11

[(not reading, please use [e-mail] instead)]

> Seth, does my patch in bug 179050 not fix these?

it might.  I have a change to msgViewPickerOverlay.js, but I'll wait until I
look at your patch in 179050.

Comment 12

[laurel]

Using jan6 commercial trunk build:
Fixed:
  1) Original case of Cancel is fixed.
  2) Clearing text -- comment #4
Case mentioned in comomebn
Not fixed:
  1)  Hitting OK in customize views will leave customize selected -- comment #8
  2)  Jennifer's case in comment #9


Are we calling these other separate bugs (I'll log them if so) or are we waiting
for application of fix for bug 179050 or other fix by Seth?

Comment 13

[jglick]

>1.Hitting OK in customize views will leave customize selected -- comment #8
Bug 188404

>2.Jennifer's case in comment #9
Bug 188407.

Comment 14

[laurel]

marking verified then. Thanks for logging those, Jennifer.

Comment 15

[Andy Boze]

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b3) Gecko/20050708
SeaMonkey/1.0a

This bug, or something like it, may be back. Selecting "Customize..." opens the
"New Saved Search Folder" dialog, not the "Customize Message Views" dialog, as I
would expect. (From the menu, "View | Messages | Customize..." does work as I
would expect.) If I cancel the "New Saved Search Folder", the picker returns to
its previous state, but if I select "Customize..." again, no dialog box of any
sort opens, and the picker is left at "Customize...". If I select another view,
"All" for example, then the next time I select "Customize...", the "New Saved
Search Folder" dialog will open again.