Closed Bug 1800270 Opened 3 years ago Closed 2 years ago

[wpt-sync] Sync PR 36939 - Fix progress-based-animation-animation-longhand-properties test

Categories

(Testing :: web-platform-tests, task, P4)

Product:
Testing
Component:
web-platform-tests
Type:
task

Tracking

(firefox109 fixed)

Status:
RESOLVED FIXED
Milestone:
109 Branch
Tracking Flags:
Tracking Status
firefox109 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 36939 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/36939
Details from upstream follow.

Kevin Ellis <kevers@google.com> wrote:

Fix progress-based-animation-animation-longhand-properties test

The failing tests were for edge cases where special handling is needed
in time normalization. When the iteration count or iteration duration
is zero, the active duration is zero. In these cases, we do not align
with the timeline duration, and the animation collapses to one with
zero duration. This is expected behavior.

Since we were not specifying fill-forwards, we end up in the after
phase, and the animation was having no effect. Adding fill-forward,
we can see that we clamp to the end of the animation. The rule for
end-point inclusiveness did not kick in since the scroll position was
not aligned with the upper bounds.

Now to address the weirdness of why one of the three cases is at
progress 0 while the other two cases are progress 1 in the after
phase. This is because at the end of the active phase the overall
progress is equal to the iteration count, and in one case, the
iteration count is explicitly set to zero. The overall progress is
converted to an simple iteration progress by taking the overall
progress fmod 1.

Bug: 1382874
Change-Id: Ic41fcf9c1d64a81b008b94736d6ee556ef2aa1e5

Reviewed-on: https://chromium-review.googlesource.com/4022147
WPT-Export-Revision: 8b74590de87caf46742aa4e36d9392f3d2116618

CI Results

Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests and 12 subtests

Status Summary

Firefox

OK : 1
FAIL: 12

Chrome

OK : 1
PASS: 12

Safari

OK : 1
FAIL: 12

Links

GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

  • /scroll-animations/css/progress-based-animation-animation-longhand-properties.tentative.html [wpt.fyi]
    • animation-duration: FAIL (Chrome: PASS, Safari: FAIL)
    • animation-duration: 0s: FAIL (Chrome: PASS, Safari: FAIL)
    • animation-iteration-count: FAIL (Chrome: PASS, Safari: FAIL)
    • animation-iteration-count: 0: FAIL (Chrome: PASS, Safari: FAIL)
    • animation-iteration-count: infinite: FAIL (Chrome: PASS, Safari: FAIL)
    • animation-direction: normal: FAIL (Chrome: PASS, Safari: FAIL)
    • animation-direction: reverse: FAIL (Chrome: PASS, Safari: FAIL)
    • animation-direction: alternate: FAIL (Chrome: PASS, Safari: FAIL)
    • animation-direction: alternate-reverse: FAIL (Chrome: PASS, Safari: FAIL)
    • animation-delay with a positive value: FAIL (Chrome: PASS, Safari: FAIL)
    • animation-delay with a negative value: FAIL (Chrome: PASS, Safari: FAIL)
    • animation-fill-mode: FAIL (Chrome: PASS, Safari: FAIL)
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/5e90082b8e1b [wpt PR 36939] - Fix progress-based-animation-animation-longhand-properties test, a=testonly

https://hg.mozilla.org/mozilla-central/rev/5e90082b8e1b

Status: NEW → RESOLVED
Closed: 2 years ago
status-firefox109: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 109 Branch
You need to log in before you can comment on or make changes to this bug.