Closed Bug 1800284 Opened 3 years ago Closed 3 years ago

Update libjxl to new version 660aac936628eba175e11a79dc33f30140b49e35 from 2022-11-11 13:30:27

Categories

(Core :: Graphics: ImageLib, enhancement)

Product:
Core
Component:
Graphics: ImageLib
Type:
enhancement

Tracking

()

Status:
RESOLVED FIXED
Milestone:
109 Branch
Tracking Flags:
Tracking Status
firefox108 --- wontfix
firefox109 --- fixed

People

(Reporter: update-bot, Assigned: saschanaz)

Details

(Whiteboard: [3pl-filed][task_id: Px1bWgXISMOJDsPM2sMA9g])

Attachments

(1 file, 1 obsolete file)

Bug 1800284 - Update libjxl r=tnikkel
48 bytes, text/x-phabricator-request
Details | Review

This update covers 22 commits:

660aac936628eba175e11a79dc33f30140b49e35 by Fredrick Brennan

https://github.com/libjxl/libjxl/commit/660aac936628eba175e11a79dc33f30140b49e35
Authored: 2022-11-11 08:30:27 -0500
Committed: 2022-11-11 14:30:27 +0100

plugins/gimp: Support for decoding animations (#1863)

  • plugins/gimp: Support for decoding animations

  • lint

  • fix authors check

  • plugins/gimp: Handle the two blend modes GIMP understands.

  • plugins/gimp: Handle named frames

  • plugins/gimp: Fix maths fail

  • plugins/gimp: Start layer index from 1 to match WebP/gif plugins

  • set coalescing to true

Co-authored-by: Moritz Firsching <firsching@google.com>

Files Modified:

  • AUTHORS
  • plugins/gimp/file-jxl-load.cc

6dc85466fc5bab0572b43d027e179954c3814dc7 by Luca Versari

https://github.com/libjxl/libjxl/commit/6dc85466fc5bab0572b43d027e179954c3814dc7
Authored: 2022-11-10 16:32:45 +0100
Committed: 2022-11-10 17:51:31 +0100

[butteraugli] Add support for writing the distmap to pfm.

Files Modified:

  • tools/butteraugli_main.cc

72af6c7ec73cbb6af5ec5a32b8608b1f3f2fb633 by Zoltan Szabadka

https://github.com/libjxl/libjxl/commit/72af6c7ec73cbb6af5ec5a32b8608b1f3f2fb633
Authored: 2022-11-09 17:35:50 +0100
Committed: 2022-11-09 18:25:17 +0100

Remove xyb-jpegs dependence on JXL's parameterized quant matrix.

Optimize the set of remaining 105 free AC quant weights (since we
want the quant matrix to be symmetric).

Benchmark before:

Encoding            kPixels    Bytes          BPP  E MP/s  D MP/s     Max norm        pnorm       BPP*pnorm   Bugs
------------------------------------------------------------------------------------------------------------------
jpeg:libjxl:d0.5      13270  4654354    2.8058457   3.663  20.463   1.54231071   0.46554951  1.306260075416      0
jpeg:libjxl:d0.8      13270  3482816    2.0995920   3.796  25.002   1.70935893   0.61929160  1.300259661216      0
jpeg:libjxl:d0.9      13270  3223473    1.9432488   3.822  22.895   1.84545839   0.67493955  1.311575456149      0
jpeg:libjxl:d1.0      13270  3028977    1.8259982   3.726  21.924   1.90735793   0.71123393  1.298711878895      0
jpeg:libjxl:d1.1      13270  2833331    1.7080543   3.716  22.769   2.19600940   0.76419471  1.305286098499      0
jpeg:libjxl:d1.2      13270  2694178    1.6241669   3.751  23.004   2.27468419   0.79893476  1.297603396949      0
jpeg:libjxl:d1.5      13270  2307256    1.3909136   4.096  27.922   2.60481334   0.94243889  1.310851074545      0
jpeg:libjxl:d2.0      13270  1894603    1.1421485   3.831  22.792   3.18599176   1.12675147  1.286917548072      0
Aggregate:            13270  2919735    1.7601424   3.798  23.258   2.10445561   0.73980436  1.302161048110      0

Benchmark after:

Encoding            kPixels    Bytes          BPP  E MP/s  D MP/s     Max norm        pnorm       BPP*pnorm   Bugs
------------------------------------------------------------------------------------------------------------------
jpeg:libjxl:d0.5      13270  4604435    2.7757524   3.217  18.406   1.67270899   0.46916401  1.302283114386      0
jpeg:libjxl:d0.8      13270  3451612    2.0807808   3.843  21.973   1.71237743   0.62384150  1.298077432889      0
jpeg:libjxl:d0.9      13270  3189961    1.9230463   3.432  19.557   1.81622076   0.67879120  1.305346906713      0
jpeg:libjxl:d1.0      13270  2999278    1.8080944   3.483  20.767   1.95959663   0.71370775  1.290450959433      0
jpeg:libjxl:d1.1      13270  2801626    1.6889412   3.668  22.541   2.30924606   0.76993853  1.300380906241      0
jpeg:libjxl:d1.2      13270  2650997    1.5981355   3.619  22.952   2.31698585   0.81157827  1.297012067011      0
jpeg:libjxl:d1.5      13270  2280336    1.3746851   3.652  24.685   2.72100186   0.94873410  1.304210588039      0
jpeg:libjxl:d2.0      13270  1875238    1.1304745   3.880  27.784   3.36580706   1.13450375  1.282527537475      0
Aggregate:            13270  2887250    1.7405590   3.593  22.166   2.17430696   0.74545951  1.297516262872      0

Files Modified:

  • lib/extras/encode_jpeg.cc

cdf03323851a5efe3ddfe8f4467ff695b3c5c57d by Sami Boukortt

https://github.com/libjxl/libjxl/commit/cdf03323851a5efe3ddfe8f4467ff695b3c5c57d
Authored: 2022-09-28 17:42:48 +0200
Committed: 2022-11-09 15:51:14 +0100

Read the CICP tag from ICC profiles if present

Files Modified:

  • deps.sh
  • lib/jxl/enc_color_management.cc
  • third_party/skcms

be173019e2345b6c62ec808854bc997095418e9a by Jon Sneyers

https://github.com/libjxl/libjxl/commit/be173019e2345b6c62ec808854bc997095418e9a
Authored: 2022-11-09 15:27:59 +0200
Committed: 2022-11-09 15:27:59 +0200

don't compile debug print tree code (#1881)

Files Modified:

  • lib/jxl/enc_modular.cc

588c41863f2a7cdfdeed8d47bf603d3d91c0d6f3 by szabadka

https://github.com/libjxl/libjxl/commit/588c41863f2a7cdfdeed8d47bf603d3d91c0d6f3
Authored: 2022-11-08 18:26:17 +0100
Committed: 2022-11-08 18:26:17 +0100

Simplex-search optimized xyb-jpeg quantization matrix parameters. (#1877)

Benchmark before:

Encoding            kPixels    Bytes          BPP  E MP/s  D MP/s     Max norm        pnorm       BPP*pnorm   Bugs
------------------------------------------------------------------------------------------------------------------
jpeg:libjxl:d0.5      13270  4804698    2.8964795   3.723  22.242   1.56636882   0.47385977  1.372525138424      0
jpeg:libjxl:d0.8      13270  3636329    2.1921362   4.089  25.696   1.87652230   0.61543190  1.349110553678      0
jpeg:libjxl:d0.9      13270  3378595    2.0367630   3.790  23.042   2.17102480   0.66006343  1.344392804990      0
jpeg:libjxl:d1.0      13270  3163678    1.9072018   4.064  24.490   2.19093180   0.70477101  1.344140529099      0
jpeg:libjxl:d1.1      13270  2984772    1.7993495   3.966  26.363   2.11484838   0.75048089  1.350377429818      0
jpeg:libjxl:d1.2      13270  2828203    1.7049630   4.278  28.153   2.29096746   0.78898283  1.345186506645      0
jpeg:libjxl:d1.5      13270  2447451    1.4754292   4.083  26.287   3.02021217   0.91575531  1.351132125102      0
jpeg:libjxl:d2.0      13270  2015903    1.2152734   4.220  31.476   3.28036547   1.09683000  1.332948351442      0
Aggregate:            13270  3064488    1.8474056   4.023  25.829   2.25605616   0.73004342  1.348686280677      0

Benchmark after:

Encoding            kPixels    Bytes          BPP  E MP/s  D MP/s     Max norm        pnorm       BPP*pnorm   Bugs
------------------------------------------------------------------------------------------------------------------
jpeg:libjxl:d0.5      13270  4654354    2.8058457   3.971  20.967   1.54231071   0.46554951  1.306260075416      0
jpeg:libjxl:d0.8      13270  3482816    2.0995920   4.085  24.342   1.70935893   0.61929160  1.300259661216      0
jpeg:libjxl:d0.9      13270  3223473    1.9432488   4.163  22.163   1.84545839   0.67493955  1.311575456149      0
jpeg:libjxl:d1.0      13270  3028977    1.8259982   4.598  25.571   1.90735793   0.71123393  1.298711878895      0
jpeg:libjxl:d1.1      13270  2833331    1.7080543   4.518  26.407   2.19600940   0.76419471  1.305286098499      0
jpeg:libjxl:d1.2      13270  2694178    1.6241669   3.971  25.394   2.27468419   0.79893476  1.297603396949      0
jpeg:libjxl:d1.5      13270  2307256    1.3909136   4.331  26.717   2.60481334   0.94243889  1.310851074545      0
jpeg:libjxl:d2.0      13270  1894603    1.1421485   4.573  33.426   3.18599176   1.12675147  1.286917548072      0
Aggregate:            13270  2919735    1.7601424   4.269  25.400   2.10445561   0.73980436  1.302161048110      0

Files Modified:

  • lib/extras/encode_jpeg.cc

6f8cd1b4744ffe95e6788b49de6c4f28b742d4f6 by Moritz Firsching

https://github.com/libjxl/libjxl/commit/6f8cd1b4744ffe95e6788b49de6c4f28b742d4f6
Authored: 2022-11-08 13:33:22 +0100
Committed: 2022-11-08 13:51:50 +0100

lint and author file

Files Modified:

  • AUTHORS
  • experimental/fast_lossless/fast_lossless.cc
  • experimental/fast_lossless/fast_lossless.h

759da1a7c4b87e8bc80561832c3720edbfebd11e by Nigel Tao

https://github.com/libjxl/libjxl/commit/759da1a7c4b87e8bc80561832c3720edbfebd11e
Authored: 2022-11-05 11:16:38 +1100
Committed: 2022-11-08 13:51:50 +0100

fast_lossless: rename FastLosslessEncode

Adding a "Jxl" prefix disambiguates it when combining it with e.g. a
fast PNG encoder or fast WebP encoder. Some lines were subsequently
re-formatted to fit within 80 columns.

Also wrap an "extern C" around that function.

Also wrap an anonymous namespace around the implementation, so that the
fjxl BitWriter doesn't conflict with e.g. fpnge's BitWriter.

Also fix some -Wunknown-pragmas and -Wsign-compare g++ warnings.

Fixes #1855

Files Modified:

  • experimental/fast_lossless/fast_lossless.cc
  • experimental/fast_lossless/fast_lossless.h
  • experimental/fast_lossless/fast_lossless_main.cc

d1fdb1f41d194a7067f0b3c8697e8b20b8b23bd0 by szabadka

https://github.com/libjxl/libjxl/commit/d1fdb1f41d194a7067f0b3c8697e8b20b8b23bd0
Authored: 2022-11-07 23:11:12 +0100
Committed: 2022-11-07 23:11:12 +0100

XYB-jpeg: jpeg-specific clustering and more progression. (#1875)

Benchmark before:

Encoding            kPixels    Bytes          BPP  E MP/s  D MP/s     Max norm        pnorm       BPP*pnorm   Bugs
------------------------------------------------------------------------------------------------------------------
jpeg:libjxl:d1.0      13270  3197015    1.9272988   5.469  29.993   2.19093180   0.70477101  1.358304300765      0

Benchmark after:

Encoding            kPixels    Bytes          BPP  E MP/s  D MP/s     Max norm        pnorm       BPP*pnorm   Bugs
------------------------------------------------------------------------------------------------------------------
jpeg:libjxl:d1.0      13270  3163678    1.9072018   4.031  25.939   2.19093180   0.70477101  1.344140529099      0

Files Modified:

  • lib/extras/encode_jpeg.cc

1d2225c252ce5fd906d3a12ee0dbed92e577076d by Zoltan Szabadka

https://github.com/libjxl/libjxl/commit/1d2225c252ce5fd906d3a12ee0dbed92e577076d
Authored: 2022-11-03 16:23:49 +0100
Committed: 2022-11-07 09:26:19 +0100

Add a build mode without box decoding and jpeg transcoding.

In this case brotli decoder is also not needed.

Brotli compressed WASM binary size is 155k.

Files Modified:

  • .github/workflows/build_test.yml
  • CMakeLists.txt
  • lib/jxl.cmake
  • lib/jxl/common.h
  • lib/jxl/decode.cc
  • lib/jxl/decode_test.cc
  • lib/jxl/encode_test.cc
  • lib/jxl/test_utils.h
  • tools/build_cleaner.py

bc89bd5d455f2bc64f2c1479025cd806ee483e07 by alistair7

https://github.com/libjxl/libjxl/commit/bc89bd5d455f2bc64f2c1479025cd806ee483e07
Authored: 2022-11-06 21:20:36 +0000
Committed: 2022-11-06 23:20:36 +0200

Encode intrinsic dimensions (#1860)

Make the encoder store the intrinsic_xsize and intrinsic_ysize from JxlBasicInfo. Setting these previously had no effect.

Files Modified:

  • lib/include/jxl/codestream_header.h
  • lib/jxl/encode.cc
  • lib/jxl/encode_test.cc

59cd813787cbd89342cdd1b32a1b4ee9dd2d1042 by szabadka

https://github.com/libjxl/libjxl/commit/59cd813787cbd89342cdd1b32a1b4ee9dd2d1042
Authored: 2022-11-06 22:18:56 +0100
Committed: 2022-11-06 23:18:56 +0200

Make jpeg decoder more self-contained. (#1866)

Add specialized 8x8 IDCT and transpose from jpeg xl.

Files Modified:

  • lib/extras/dec_group_jpeg.cc
  • lib/extras/dec_group_jpeg.h

997069d111d4ba6c516580c218255c6f46c45c57 by Leo Izen

https://github.com/libjxl/libjxl/commit/997069d111d4ba6c516580c218255c6f46c45c57
Authored: 2022-11-05 03:55:54 -0400
Committed: 2022-11-05 08:55:54 +0100

tools/libjxl_test.c: avoid function declaration without prototype (#1867)

Avoid declaring int main() without a prototype as this is deprecated
in all versions of C.

Files Modified:

  • tools/libjxl_test.c

a0204edcaf9288b62a0fd1a708c97456ec717b02 by Zoltan Szabadka

https://github.com/libjxl/libjxl/commit/a0204edcaf9288b62a0fd1a708c97456ec717b02
Authored: 2022-11-04 11:34:23 +0100
Committed: 2022-11-04 13:21:48 +0100

Fix JPEG reconstruction error.

Fixes #1790.

Files Modified:

  • lib/jxl/jpeg/dec_jpeg_data_writer.cc
  • lib/jxl/jpeg/jpeg_data.cc

e453278ccf94fb7382373c362eeb25c97156a1f7 by Zoltan Szabadka

https://github.com/libjxl/libjxl/commit/e453278ccf94fb7382373c362eeb25c97156a1f7
Authored: 2022-11-03 17:19:45 +0100
Committed: 2022-11-04 11:27:25 +0100

Dont save MCU coding state if there are enough bytes in buffer.

Benchmark before:

Encoding                 kPixels    Bytes          BPP  E MP/s  D MP/s     Max norm        pnorm       BPP*pnorm   Bugs
-----------------------------------------------------------------------------------------------------------------------
jpeg:q90:djxl8             13270  4838710    2.9169834  65.817 112.747   2.17603183   0.62092407  1.811225220808      0
jpeg:yuv420:q90:djxl8      13270  3660915    2.2069577  96.322 164.534   6.05725956   0.91959307  2.029503031911      0
jpeg:libjxl:djxl8          13270  3197015    1.9272988  19.046  79.233   2.25490046   0.70510193  1.358942071174      0

Benchmark after:

Encoding                 kPixels    Bytes          BPP  E MP/s  D MP/s     Max norm        pnorm       BPP*pnorm   Bugs
-----------------------------------------------------------------------------------------------------------------------
jpeg:q90:djxl8             13270  4838710    2.9169834  66.330 118.045   2.17603183   0.62092407  1.811225220808      0
jpeg:yuv420:q90:djxl8      13270  3660915    2.2069577  96.814 169.467   6.05725956   0.91959307  2.029503031911      0
jpeg:libjxl:djxl8          13270  3197015    1.9272988  18.882  82.873   2.25490046   0.70510193  1.358942071174      0

Files Modified:

  • lib/extras/decode_jpeg.cc

ed959d69b4a8e7c4afd4b2a526a4ae844174ba25 by Zoltan Szabadka

https://github.com/libjxl/libjxl/commit/ed959d69b4a8e7c4afd4b2a526a4ae844174ba25
Authored: 2022-11-02 17:35:25 +0100
Committed: 2022-11-03 15:27:43 +0100

Add first version of streaming JPEG decoder.

Benchmark before:

Encoding                  kPixels    Bytes          BPP  E MP/s  D MP/s     Max norm        pnorm       BPP*pnorm   Bugs
------------------------------------------------------------------------------------------------------------------------
jpeg:q90                    13270  4838710    2.9169834  63.705 161.410   2.40070152   0.68663652  2.002907346396      0
jpeg:q90:djxl8              13270  4838710    2.9169834  63.213 112.574   2.17603183   0.62092407  1.811225220808      0
jpeg:q90:djxl16             13270  4838710    2.9169834  63.008 109.120   2.16807723   0.61567343  1.795909190468      0
jpeg:yuv420:q90             13270  3660915    2.2069577  93.729 238.752   6.07282543   0.95039908  2.097490592679      0
jpeg:yuv420:q90:djxl8       13270  3660915    2.2069577  93.761 156.263   6.05725956   0.91959307  2.029503031911      0
jpeg:yuv420:q90:djxl16      13270  3660915    2.2069577  95.847 152.478   6.05378914   0.91638444  2.022421724515      0
jpeg:libjxl                 13270  3197015    1.9272988  18.429  99.632   2.19571280   0.70762796  1.363810502985      0
jpeg:libjxl:djxl8           13270  3197015    1.9272988  18.652  86.314   2.25490046   0.70510193  1.358942071174      0
jpeg:libjxl:djxl16          13270  3197015    1.9272988  18.639  84.488   2.29413509   0.69006634  1.329964006217      0

Benchmark after:

Encoding                  kPixels    Bytes          BPP  E MP/s  D MP/s     Max norm        pnorm       BPP*pnorm   Bugs
------------------------------------------------------------------------------------------------------------------------
jpeg:q90                    13270  4838710    2.9169834  64.733 166.560   2.40070152   0.68663652  2.002907346396      0
jpeg:q90:djxl8              13270  4838710    2.9169834  63.666 105.345   2.17603183   0.62092407  1.811225220808      0
jpeg:q90:djxl16             13270  4838710    2.9169834  63.061 104.653   2.16807723   0.61567343  1.795909190468      0
jpeg:yuv420:q90             13270  3660915    2.2069577  96.172 246.808   6.07282543   0.95039908  2.097490592679      0
jpeg:yuv420:q90:djxl8       13270  3660915    2.2069577  97.151 156.914   6.05725956   0.91959307  2.029503031911      0
jpeg:yuv420:q90:djxl16      13270  3660915    2.2069577  97.868 153.058   6.05378914   0.91638444  2.022421724515      0
jpeg:libjxl                 13270  3197015    1.9272988  18.323  97.172   2.19571280   0.70762796  1.363810502985      0
jpeg:libjxl:djxl8           13270  3197015    1.9272988  18.660  76.811   2.25490046   0.70510193  1.358942071174      0
jpeg:libjxl:djxl16          13270  3197015    1.9272988  18.711  76.222   2.29413509   0.69006634  1.329964006217      0

Files Added:

  • lib/extras/decode_jpeg_test.cc

Files Modified:

  • ci.sh
  • lib/extras/dec_group_jpeg.cc
  • lib/extras/dec_group_jpeg.h
  • lib/extras/decode_jpeg.cc
  • lib/extras/decode_jpeg.h
  • lib/jxl_tests.cmake
  • testdata

7c162e26b49f8e5a5e87d8f6dc26c28e7cc13c5b by Zoltan Szabadka

https://github.com/libjxl/libjxl/commit/7c162e26b49f8e5a5e87d8f6dc26c28e7cc13c5b
Authored: 2022-10-28 15:06:58 +0200
Committed: 2022-11-02 13:57:09 +0100

Choose output pixel format based on selected bit depth in djxl.

Fixes #1840.

Files Modified:

  • lib/extras/dec/jxl.cc
  • tools/roundtrip_test.sh

b11c0dabb70be10c7c25a36e1ad39d7e924683fa by hasinoff

https://github.com/libjxl/libjxl/commit/b11c0dabb70be10c7c25a36e1ad39d7e924683fa
Authored: 2022-11-01 20:42:44 -0700
Committed: 2022-11-02 08:58:07 +0100

Update fast_dct-inl.h

Add missing std include

Files Modified:

  • lib/jxl/fast_dct-inl.h

d1f15a285576600d945b84e5ee3c5169bdefbc01 by Moritz Firsching

https://github.com/libjxl/libjxl/commit/d1f15a285576600d945b84e5ee3c5169bdefbc01
Authored: 2022-10-31 12:24:11 +0100
Committed: 2022-10-31 12:24:11 +0100

uses_original_profile typo (#1856)

fixes #1853

Files Modified:

  • lib/jxl/encode.cc

506714edaa3dd670133b9fe094d5efb94f6d0f6e by Zoltan Szabadka

https://github.com/libjxl/libjxl/commit/506714edaa3dd670133b9fe094d5efb94f6d0f6e
Authored: 2022-10-27 16:57:47 +0200
Committed: 2022-10-28 15:08:55 +0200

Fix pfm output for djxl and benchmark.

Files Modified:

  • lib/extras/codec.cc
  • tools/djxl_main.cc
  • tools/roundtrip_test.sh

176b1c03e5915063a5536cdf7f411419c9fef6a1 by Evgenii Kliuchnikov

https://github.com/libjxl/libjxl/commit/176b1c03e5915063a5536cdf7f411419c9fef6a1
Authored: 2022-10-25 09:58:27 +0000
Committed: 2022-10-25 12:31:00 +0200

Fix WASM build

Files Modified:

  • .github/workflows/build_test.yml

f927401bde3840802f9b93ffd36480de4e0563ad by Leo Izen

https://github.com/libjxl/libjxl/commit/f927401bde3840802f9b93ffd36480de4e0563ad
Authored: 2022-10-24 04:13:37 -0400
Committed: 2022-10-24 10:13:37 +0200

lib/include/jxl/types.h: remove implemented TODO (#1843)

This feature about row stride has been implemented so
the TODO can be removed.

Signed-off-by: Leo Izen <leo.izen@gmail.com>

Files Modified:

  • lib/include/jxl/types.h

./mach vendor media/libjxl/moz.yaml reported an error editing moz.build files:

Latest commit is 660aac936628eba175e11a79dc33f30140b49e35 from 2022-11-11T13:30:27Z
Fetching code archive from https://github.com/libjxl/libjxl/archive/660aac936628eba175e11a79dc33f30140b49e35.tar.gz
Retaining wanted in-tree files.
Cleaning third_party/jpeg-xl to import changes.
Unpacking upstream files for third_party/jpeg-xl.
Retaining wanted files from upstream changes.
Removing excluded files from upstream changes.
Removing: ['/tmp/tmpwe089z62/doc/tables/context_modes.md', '/tmp/tmpwe089z62/tools/jni/org/jpeg/jpegxl/wrapper/DecoderJni.java', '/tmp/tmpwe089z62/doc/tables/stock_counts.md', '/tmp/tmpwe089z62/doc/tables/all_tables.pdf', '/tmp/tmpwe089z62/tools/benchmark/metrics/mrse.sh', '/tmp/tmpwe089z62/tools/hdr/tone_map.cc', '/tmp/tmpwe089z62/doc/api.txt', '/tmp/tmpwe089z62/tools/example_tree.txt', '/tmp/tmpwe089z62/tools/icc_detect/icc_detect.h', '/tmp/tmpwe089z62/tools/ssimulacra.txt', '/tmp/tmpwe089z62/tools/benchmark/benchmark_codec_webp.cc', '/tmp/tmpwe089z62/tools/benchmark/metrics/fsim-rgb.sh', '/tmp/tmpwe089z62/tools/benchmark/metrics/compute-hdrvdp.m', '/tmp/tmpwe089z62/tools/fuzzer_stub.cc', '/tmp/tmpwe089z62/tools/comparison_viewer/codec_comparison_window.h', '/tmp/tmpwe089z62/tools/cmdline.cc', '/tmp/tmpwe089z62/tools/benchmark/metrics/plots.py', '/tmp/tmpwe089z62/tools/benchmark/benchmark_codec_jpeg.cc', '/tmp/tmpwe089z62/tools/benchmark/benchmark_codec_custom.h', '/tmp/tmpwe089z62/tools/icc_detect/icc_detect_x11.cc', '/tmp/tmpwe089z62/tools/ssimulacra2_main.cc', '/tmp/tmpwe089z62/doc/tables/is_zero_base.md', '/tmp/tmpwe089z62/tools/flicker_test/CMakeLists.txt', '/tmp/tmpwe089z62/doc/fuzzing.md', '/tmp/tmpwe089z62/tools/benchmark/metrics/compute_octave_metric.sh', '/tmp/tmpwe089z62/doc/color_management.md', '/tmp/tmpwe089z62/tools/benchmark/metrics/lpips-rgb.sh', '/tmp/tmpwe089z62/doc/tables/symbol_order.md', '/tmp/tmpwe089z62/tools/benchmark/metrics/run_all_sdr_metrics.sh', '/tmp/tmpwe089z62/tools/hdr/exr_to_pq.cc', '/tmp/tmpwe089z62/tools/benchmark/hm/decode.sh', '/tmp/tmpwe089z62/tools/icc_codec_fuzzer.cc', '/tmp/tmpwe089z62/tools/cjxl_bisect_size', '/tmp/tmpwe089z62/tools/benchmark/benchmark_codec_png.cc', '/tmp/tmpwe089z62/tools/viewer/viewer_window.cc', '/tmp/tmpwe089z62/tools/benchmark/metrics/vsi-rgb.sh', '/tmp/tmpwe089z62/tools/check_author.py', '/tmp/tmpwe089z62/tools/hdr/display_to_hlg.cc', '/tmp/tmpwe089z62/tools/viewer/viewer_window.h', '/tmp/tmpwe089z62/tools/conformance/CMakeLists.txt', '/tmp/tmpwe089z62/tools/benchmark/benchmark_codec_png.h', '/tmp/tmpwe089z62/tools/jxl_emcc.cc', '/tmp/tmpwe089z62/doc/benchmarking.md', '/tmp/tmpwe089z62/tools/comparison_viewer/settings.ui', '/tmp/tmpwe089z62/tools/flicker_test/split_view.cc', '/tmp/tmpwe089z62/doc/developing_in_github.md', '/tmp/tmpwe089z62/tools/jni/org/jpeg/jpegxl/wrapper/Decoder.java', '/tmp/tmpwe089z62/tools/rans_fuzzer.cc', '/tmp/tmpwe089z62/doc/man/cjxl.txt', '/tmp/tmpwe089z62/tools/set_from_bytes_fuzzer.cc', '/tmp/tmpwe089z62/tools/flicker_test/split_view.h', '/tmp/tmpwe089z62/tools/jni/org/jpeg/jpegxl/wrapper/decoder_jni_onload.cc', '/tmp/tmpwe089z62/doc/tables/nonzero_buckets.md', '/tmp/tmpwe089z62/doc/tables/icc.md', '/tmp/tmpwe089z62/tools/benchmark/metrics/msssim-rgb.sh', '/tmp/tmpwe089z62/tools/conformance/conformance.py', '/tmp/tmpwe089z62/doc/sphinx/index.rst', '/tmp/tmpwe089z62/tools/benchmark/metrics/fsim-y.sh', '/tmp/tmpwe089z62/tools/ossfuzz-build.sh', '/tmp/tmpwe089z62/tools/jxlinfo.c', '/tmp/tmpwe089z62/tools/README.cjpeg_hdr.md', '/tmp/tmpwe089z62/tools/box/box_list_main.cc', '/tmp/tmpwe089z62/tools/benchmark/metrics/nlpd-y.sh', '/tmp/tmpwe089z62/doc/sphinx/requirements.txt', '/tmp/tmpwe089z62/tools/benchmark/metrics/compute-pumetrics.m', '/tmp/tmpwe089z62/tools/djxl_fuzzer.cc', '/tmp/tmpwe089z62/tools/icc_detect/icc_detect_empty.cc', '/tmp/tmpwe089z62/tools/codec_config.h', '/tmp/tmpwe089z62/tools/jni/org/jpeg/jpegxl/wrapper/PixelFormat.java', '/tmp/tmpwe089z62/tools/flicker_test/setup.h', '/tmp/tmpwe089z62/tools/cjxl_main.cc', '/tmp/tmpwe089z62/tools/viewer/load_jxl.h', '/tmp/tmpwe089z62/tools/conformance/lcms2.py', '/tmp/tmpwe089z62/tools/djxl_main.cc', '/tmp/tmpwe089z62/tools/viewer/main.cc', '/tmp/tmpwe089z62/doc/sphinx/api_threads.rst', '/tmp/tmpwe089z62/tools/decode_basic_info_fuzzer.cc', '/tmp/tmpwe089z62/tools/benchmark/benchmark_codec.h', '/tmp/tmpwe089z62/tools/cjxl_bisect_bpp', '/tmp/tmpwe089z62/tools/comparison_viewer/split_image_renderer.cc', '/tmp/tmpwe089z62/doc/tables/stock_quant.md', '/tmp/tmpwe089z62/tools/benchmark/metrics/ssim-y.sh', '/tmp/tmpwe089z62/tools/benchmark/benchmark_args.cc', '/tmp/tmpwe089z62/tools/comparison_viewer/split_image_view.h', '/tmp/tmpwe089z62/tools/viewer/viewer_window.ui', '/tmp/tmpwe089z62/tools/jni/org/jpeg/jpegxl/wrapper/Status.java', '/tmp/tmpwe089z62/tools/benchmark/benchmark_codec_jpeg.h', '/tmp/tmpwe089z62/tools/benchmark/metrics/vif-rgb.sh', '/tmp/tmpwe089z62/tools/xyb_range.cc', '/tmp/tmpwe089z62/tools/benchmark/benchmark_codec_webp.h', '/tmp/tmpwe089z62/tools/comparison_viewer/codec_comparison_window.ui', '/tmp/tmpwe089z62/doc/tables/stock_values.md', '/tmp/tmpwe089z62/tools/benchmark/metrics/pupsnr.sh', '/tmp/tmpwe089z62/tools/comparison_viewer/settings.cc', '/tmp/tmpwe089z62/tools/conformance/tooling_test.sh', '/tmp/tmpwe089z62/tools/optimizer/simplex_fork.py', '/tmp/tmpwe089z62/doc/xl_overview.md', '/tmp/tmpwe089z62/tools/jxl_from_tree.cc', '/tmp/tmpwe089z62/tools/flicker_test/test_window.h', '/tmp/tmpwe089z62/tools/flicker_test/test_window.ui', '/tmp/tmpwe089z62/tools/comparison_viewer/compare_images.cc', '/tmp/tmpwe089z62/tools/comparison_viewer/compare_codecs.cc', '/tmp/tmpwe089z62/doc/building_and_testing.md', '/tmp/tmpwe089z62/tools/conformance/generator.py', '/tmp/tmpwe089z62/tools/flicker_test/parameters.cc', '/tmp/tmpwe089z62/tools/file_io.cc', '/tmp/tmpwe089z62/tools/args.h', '/tmp/tmpwe089z62/doc/software_support.md', '/tmp/tmpwe089z62/doc/tables/num_nonzeros_base.md', '/tmp/tmpwe089z62/doc/tables/quant.md', '/tmp/tmpwe089z62/tools/benchmark/hm/README.md', '/tmp/tmpwe089z62/tools/color_encoding_fuzzer.cc', '/tmp/tmpwe089z62/tools/box/box.h', '/tmp/tmpwe089z62/tools/speed_stats.h', '/tmp/tmpwe089z62/doc/building_wasm.md', '/tmp/tmpwe089z62/tools/benchmark/metrics/iqa_wrapper.sh', '/tmp/tmpwe089z62/doc/sphinx/api_common.rst', '/tmp/tmpwe089z62/tools/benchmark/metrics/prepare_metrics.sh', '/tmp/tmpwe089z62/tools/viewer/CMakeLists.txt', '/tmp/tmpwe089z62/tools/butteraugli_main.cc', '/tmp/tmpwe089z62/tools/jni/org/jpeg/jpegxl/wrapper/ImageData.java', '/tmp/tmpwe089z62/doc/release.md', '/tmp/tmpwe089z62/tools/flicker_test/parameters.h', '/tmp/tmpwe089z62/tools/ssimulacra.h', '/tmp/tmpwe089z62/doc/jxl.svg', '/tmp/tmpwe089z62/doc/sphinx/api_encoder.rst', '/tmp/tmpwe089z62/tools/benchmark/benchmark_codec_avif.h', '/tmp/tmpwe089z62/tools/reference_zip.sh', '/tmp/tmpwe089z62/tools/jni/org/jpeg/jpegxl/wrapper/DecoderTest.java', '/tmp/tmpwe089z62/tools/flicker_test/setup.ui', '/tmp/tmpwe089z62/tools/comparison_viewer/image_loading.cc', '/tmp/tmpwe089z62/tools/upscaling_coefficients/generate_upscaling_coefficients.py', '/tmp/tmpwe089z62/doc/tables/brn_proto.md', '/tmp/tmpwe089z62/tools/benchmark/metrics/gmsd-rgb.sh', '/tmp/tmpwe089z62/doc/sphinx/api.rst', '/tmp/tmpwe089z62/tools/flicker_test/test_window.cc', '/tmp/tmpwe089z62/tools/benchmark/metrics/run_all_hdr_metrics.sh', '/tmp/tmpwe089z62/tools/hdr/render_hlg.cc', '/tmp/tmpwe089z62/tools/benchmark/benchmark_codec_custom.cc', '/tmp/tmpwe089z62/tools/comparison_viewer/settings.h', '/tmp/tmpwe089z62/tools/ssimulacra_main.cc', '/tmp/tmpwe089z62/tools/speed_stats.cc', '/tmp/tmpwe089z62/doc/format_overview.md', '/tmp/tmpwe089z62/tools/benchmark/benchmark_utils.cc', '/tmp/tmpwe089z62/.gitmodules', '/tmp/tmpwe089z62/tools/progressive_saliency.conf', '/tmp/tmpwe089z62/doc/developing_with_crossroad.md', '/tmp/tmpwe089z62/tools/jni/org/jpeg/jpegxl/wrapper/StreamInfo.java', '/tmp/tmpwe089z62/tools/tool_version.cc', '/tmp/tmpwe089z62/tools/ssimulacra.cc', '/tmp/tmpwe089z62/tools/benchmark/benchmark_file_io.cc', '/tmp/tmpwe089z62/tools/decode_and_encode.cc', '/tmp/tmpwe089z62/doc/vuln_playbook.md', '/tmp/tmpwe089z62/tools/benchmark/metrics/ssim-rgb.sh', '/tmp/tmpwe089z62/tools/flicker_test/main.cc', '/tmp/tmpwe089z62/tools/benchmark/metrics/hdrvdp.sh', '/tmp/tmpwe089z62/tools/benchmark/hm/encode.sh', '/tmp/tmpwe089z62/tools/box/box.cc', '/tmp/tmpwe089z62/doc/sphinx/conf.py', '/tmp/tmpwe089z62/tools/progressive_sizes.sh', '/tmp/tmpwe089z62/tools/benchmark/benchmark_codec_avif.cc', '/tmp/tmpwe089z62/doc/tables/dct_gen.md', '/tmp/tmpwe089z62/tools/benchmark/metrics/iqa.py', '/tmp/tmpwe089z62/tools/benchmark/benchmark_xl.cc', '/tmp/tmpwe089z62/tools/comparison_viewer/image_loading.h', '/tmp/tmpwe089z62/tools/build_stats.py', '/tmp/tmpwe089z62/tools/flicker_test/setup.cc', '/tmp/tmpwe089z62/tools/ssimulacra2.cc', '/tmp/tmpwe089z62/tools/hdr/generate_lut_template.cc', '/tmp/tmpwe089z62/doc/developing_in_docker.md', '/tmp/tmpwe089z62/tools/comparison_viewer/CMakeLists.txt', '/tmp/tmpwe089z62/doc/sphinx/api_decoder.rst', '/tmp/tmpwe089z62/tools/bisector', '/tmp/tmpwe089z62/tools/benchmark/benchmark_stats.h', '/tmp/tmpwe089z62/doc/man/djxl.txt', '/tmp/tmpwe089z62/tools/benchmark/benchmark_utils.h', '/tmp/tmpwe089z62/tools/benchmark/benchmark_codec_jxl.h', '/tmp/tmpwe089z62/.gitignore', '/tmp/tmpwe089z62/tools/benchmark/metrics/vmaf.sh', '/tmp/tmpwe089z62/tools/demo_vardct_select.sh', '/tmp/tmpwe089z62/doc/developing_in_windows_msys.md', '/tmp/tmpwe089z62/tools/hdr/pq_to_hlg.cc', '/tmp/tmpwe089z62/tools/jni/org/jpeg/jpegxl/wrapper/decoder_jni.cc', '/tmp/tmpwe089z62/tools/fuzzer_corpus.cc', '/tmp/tmpwe089z62/tools/demo_progressive_saliency_encoding.py', '/tmp/tmpwe089z62/tools/benchmark/benchmark_codec.cc', '/tmp/tmpwe089z62/tools/git_version.cmake', '/tmp/tmpwe089z62/tools/benchmark/metrics/sdr_plots.sh', '/tmp/tmpwe089z62/tools/benchmark/metrics/hdr_plots.sh', '/tmp/tmpwe089z62/tools/djxl_fuzzer_test.cc', '/tmp/tmpwe089z62/doc/tables/adobe.md', '/tmp/tmpwe089z62/tools/cjxl_fuzzer.cc', '/tmp/tmpwe089z62/tools/benchmark/benchmark_stats.cc', '/tmp/tmpwe089z62/tools/cjpeg_hdr.cc', '/tmp/tmpwe089z62/tools/benchmark/metrics/msssim-y.sh', '/tmp/tmpwe089z62/doc/tables/ducky.md', '/tmp/tmpwe089z62/tools/build_cleaner.py', '/tmp/tmpwe089z62/doc/developing_in_debian.md', '/tmp/tmpwe089z62/tools/benchmark/metrics/pussim.sh', '/tmp/tmpwe089z62/tools/ssimulacra2.h', '/tmp/tmpwe089z62/tools/comparison_viewer/split_image_renderer.h', '/tmp/tmpwe089z62/tools/fields_fuzzer.cc', '/tmp/tmpwe089z62/tools/icc_detect/icc_detect_win32.cc', '/tmp/tmpwe089z62/doc/tables/markdown-pdf.css', '/tmp/tmpwe089z62/tools/viewer/load_jxl.cc', '/tmp/tmpwe089z62/tools/roundtrip_test.sh', '/tmp/tmpwe089z62/doc/tables/num_nonzero_context.md', '/tmp/tmpwe089z62/tools/jni/org/jpeg/jpegxl/wrapper/decoder_jni.h', '/tmp/tmpwe089z62/tools/benchmark/benchmark_file_io.h', '/tmp/tmpwe089z62/doc/sphinx/api_butteraugli.rst', '/tmp/tmpwe089z62/tools/benchmark/benchmark_args.h', '/tmp/tmpwe089z62/tools/hdr/README.md', '/tmp/tmpwe089z62/tools/cmdline.h', '/tmp/tmpwe089z62/tools/hdr/texture_to_cube.cc', '/tmp/tmpwe089z62/tools/comparison_viewer/split_image_view.cc', '/tmp/tmpwe089z62/tools/box/box_test.cc', '/tmp/tmpwe089z62/tools/tool_version.h', '/tmp/tmpwe089z62/tools/comparison_viewer/split_image_view.ui', '/tmp/tmpwe089z62/doc/tables/all_tables.sh', '/tmp/tmpwe089z62/tools/benchmark/metrics/dists-rgb.sh', '/tmp/tmpwe089z62/tools/benchmark/metrics/ssimulacra.sh', '/tmp/tmpwe089z62/tools/benchmark/metrics/hdrvdp-fixes.patch', '/tmp/tmpwe089z62/tools/codec_config.cc', '/tmp/tmpwe089z62/tools/benchmark/benchmark_codec_jxl.cc', '/tmp/tmpwe089z62/tools/transforms_fuzzer.cc', '/tmp/tmpwe089z62/doc/tables/app0.md', '/tmp/tmpwe089z62/tools/comparison_viewer/codec_comparison_window.cc', '/tmp/tmpwe089z62/doc/tables/freq_context.md', '/tmp/tmpwe089z62/doc/developing_in_windows_vcpkg.md', '/tmp/tmpwe089z62/tools/box/CMakeLists.txt', '/tmp/tmpwe089z62/tools/CMakeLists.txt', '/tmp/tmpwe089z62/tools/libjxl_test.c', '/tmp/tmpwe089z62/tools/file_io.h', '/tmp/tmpwe089z62/tools/upscaling_coefficients/upscaler_demo.py']
Copying to third_party/jpeg-xl.
Checking for update actions
Registering changes with version control.
Checking for a spurious update.
Version '660aac936628eba175e11a79dc33f30140b49e35' has changed 32 files.
Updating moz.yaml.
Found release: 99b0721251b51028927c56a81657cf76de7ea320 (2022-10-20T11:29:24Z).

Found revision: 99b0721251b51028927c56a81657cf76de7ea320

Updating moz.build files
Found 1 files added and 0 files removed.
Could not add third_party/jpeg-xl/lib/extras/decode_jpeg_test.cc to the appropriate moz.build file
This is a deficiency in ./mach vendor . Please review the affected files before committing.

We're going to continue processing the update; but we may fail because we couldn't handle these files. If we do succeed, you may want to add these files to the 'exclude' key in the moz.yaml file, so they are excluded from the source tree and ignored in the future.

I've submitted a try run for this commit: https://treeherder.mozilla.org/jobs?repo=try&revision=6804cc0629e7156dcc95583edaf217bbdb152f8e

It looks like we experienced one or more build failures when trying to apply this
update. You will need to apply this update manually; you can replicate the patch
locally with ./mach vendor media/libjxl/moz.yaml. I'm going to abandon the Phabricator patch and
let you submit a new one.

If the build failure wasn't caused by a library change, and was instead caused by
something structural in the build system please let my maintainers know in
Slack:#secinf.

I do my best to automatically add new files to the build, but some moz.build files
are complicated and you may need to fix them manually.

Flags: needinfo?(krosylight)
Attachment #9303134 - Attachment is obsolete: true
Assignee: nobody → krosylight
Status: NEW → ASSIGNED
Flags: needinfo?(krosylight)
status-firefox109: --- → affected

https://hg.mozilla.org/mozilla-central/rev/29c37fecb4ae

Status: ASSIGNED → RESOLVED
Closed: 3 years ago
status-firefox109: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → 109 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: