1800319 - Promote ESLint rule no-console to an error in newtab code (but allow console.error calls)

Status: RESOLVED FIXED

(Firefox :: New Tab Page, task)

Description

[Mark Banner (:standard8)]

I'm working towards replacing Cu.reportError with console.error.

The newtab code currently has an ESLint warning to disallow use of console. The problem with newtab's usage is that where console.error has been used, the rule get explicitly disabled in many places, and where something else has been used, it either gets turned off, or the warning is ignored.

If we still require the rule, then I think we should change it to be an error (so that issues actually get fixed), but allow console.error as an acceptable use.

Comment 1

[Mark Banner (:standard8)]

Attachment: Bug 1800319 - Change newtab code so that the ESLint rule no-console is an error, except for console.error calls. r?Mardak!

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ed64ba0e117d
Change newtab code so that the ESLint rule no-console is an error, except for console.error calls. r=Mardak

Comment 3

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/ed64ba0e117d