1800471 - Hit MOZ_CRASH(attempt to multiply with overflow) at /third_party/rust/wpf-gpu-raster/src/hwrasterizer.rs:1114

Status: NEW

(Core :: Graphics: Canvas2D, defect)

Description

[Jason Kratzer [:jkratzer]]

Testcase found while fuzzing mozilla-central rev 20e2590324e2 (built with: --enable-debug --enable-fuzzing).

Testcase can be reproduced using the following commands:

$ pip install fuzzfetch grizzly-framework
$ python -m fuzzfetch --build 20e2590324e2 --debug --fuzzing -n firefox
$ python -m grizzly.replay ./firefox/firefox testcase.html

Hit MOZ_CRASH(attempt to multiply with overflow) at /third_party/rust/wpf-gpu-raster/src/hwrasterizer.rs:1114

    ==807981==ERROR: UndefinedBehaviorSanitizer: SEGV on unknown address 0x000000000000 (pc 0x7fb5dbba8d45 bp 0x7ffc6aaf3c50 sp 0x7ffc6aaf3c40 T807981)
    ==807981==The signal is caused by a WRITE memory access.
    ==807981==Hint: address points to the zero page.
        #0 0x7fb5dbba8d45 in MOZ_Crash /builds/worker/workspace/obj-build/dist/include/mozilla/Assertions.h:261:3
        #1 0x7fb5dbba8d45 in RustMozCrash /mozglue/static/rust/wrappers.cpp:18:3
        #2 0x7fb5dbba8cc2 in mozglue_static::panic_hook::hd18ed6809dbf28d1 /mozglue/static/rust/lib.rs:91:9
        #3 0x7fb5dbba878b in core::ops::function::Fn::call::h07766207557d1e22 /rustc/897e37553bba8b42751c67658967889d11ecd120/library/core/src/ops/function.rs:77:5
        #4 0x7fb5dcb2b16c in std::panicking::rust_panic_with_hook::h7b190ce1a948faac /rustc/897e37553bba8b42751c67658967889d11ecd120/library/std/src/panicking.rs:702:17
        #5 0x7fb5dcb2af80 in std::panicking::begin_panic_handler::_$u7b$$u7b$closure$u7d$$u7d$::hbafbfdc3e1b97f68 /rustc/897e37553bba8b42751c67658967889d11ecd120/library/std/src/panicking.rs:586:13
        #6 0x7fb5dcb2812b in std::sys_common::backtrace::__rust_end_short_backtrace::hda93e5fef243b4c0 /rustc/897e37553bba8b42751c67658967889d11ecd120/library/std/src/sys_common/backtrace.rs:138:18
        #7 0x7fb5dcb2ace1 in rust_begin_unwind /rustc/897e37553bba8b42751c67658967889d11ecd120/library/std/src/panicking.rs:584:5
        #8 0x7fb5dcb804e2 in core::panicking::panic_fmt::h8d17ca1073d9a733 /rustc/897e37553bba8b42751c67658967889d11ecd120/library/core/src/panicking.rs:142:14
        #9 0x7fb5dcb8032c in core::panicking::panic::hf0565452d0d0936c /rustc/897e37553bba8b42751c67658967889d11ecd120/library/core/src/panicking.rs:48:5
        #10 0x7fb5dad24b71 in wpf_gpu_raster::hwrasterizer::CHwRasterizer::RasterizePath::h7858f85ed03af2a9 /third_party/rust/wpf-gpu-raster/src/hwrasterizer.rs
        #11 0x7fb5dad24b71 in wpf_gpu_raster::hwrasterizer::CHwRasterizer::SendGeometry::hd6f5545d75880913 /third_party/rust/wpf-gpu-raster/src/hwrasterizer.rs:747:10
        #12 0x7fb5dad24b71 in wpf_gpu_raster::rasterize_to_tri_list::h2c8a36a282f09870 /third_party/rust/wpf-gpu-raster/src/lib.rs:302:5
        #13 0x7fb5dad2166f in wgr_path_rasterize_to_tri_list /third_party/rust/wpf-gpu-raster/src/c_bindings.rs:106:18
        #14 0x7fb5d553e63c in mozilla::gfx::GeneratePathVertexBuffer(mozilla::gfx::QuantizedPath const&, mozilla::gfx::IntRectTyped<mozilla::gfx::UnknownUnits> const&) /dom/canvas/DrawTargetWebgl.cpp:2462:26
        #15 0x7fb5d553cbf1 in mozilla::gfx::DrawTargetWebgl::SharedContext::DrawPathAccel(mozilla::gfx::Path const*, mozilla::gfx::Pattern const&, mozilla::gfx::DrawOptions const&, mozilla::gfx::StrokeOptions const*, mozilla::gfx::ShadowOptions const*, bool) /dom/canvas/DrawTargetWebgl.cpp:2628:12
        #16 0x7fb5d553aa2d in mozilla::gfx::DrawTargetWebgl::DrawPath(mozilla::gfx::Path const*, mozilla::gfx::Pattern const&, mozilla::gfx::DrawOptions const&, mozilla::gfx::StrokeOptions const*) /dom/canvas/DrawTargetWebgl.cpp:2748:23
        #17 0x7fb5d553b89c in mozilla::gfx::DrawTargetWebgl::Fill(mozilla::gfx::Path const*, mozilla::gfx::Pattern const&, mozilla::gfx::DrawOptions const&) /dom/canvas/DrawTargetWebgl.cpp:2339:5
        #18 0x7fb5d55671aa in mozilla::dom::AdjustedTarget::Fill(mozilla::gfx::Path const*, mozilla::gfx::Pattern const&, mozilla::gfx::DrawOptions const&) /dom/canvas/CanvasRenderingContext2D.cpp:685:14
        #19 0x7fb5d55675c4 in mozilla::dom::CanvasRenderingContext2D::Fill(mozilla::dom::CanvasPath const&, mozilla::dom::CanvasWindingRule const&) /dom/canvas/CanvasRenderingContext2D.cpp:2864:10
        #20 0x7fb5d4937d67 in mozilla::dom::CanvasRenderingContext2D_Binding::fill(JSContext*, JS::Handle<JSObject*>, void*, JSJitMethodCallArgs const&) /builds/worker/workspace/obj-build/dom/bindings/CanvasRenderingContext2DBinding.cpp:3173:28
        #21 0x7fb5d5478792 in bool mozilla::dom::binding_detail::GenericMethod<mozilla::dom::binding_detail::NormalThisPolicy, mozilla::dom::binding_detail::ThrowExceptions>(JSContext*, unsigned int, JS::Value*) /dom/bindings/BindingUtils.cpp:3287:13
        #22 0x7fb5d9760cec in CallJSNative(JSContext*, bool (*)(JSContext*, unsigned int, JS::Value*), js::CallReason, JS::CallArgs const&) /js/src/vm/Interpreter.cpp:459:13
        #23 0x7fb5d976060f in js::InternalCallOrConstruct(JSContext*, JS::CallArgs const&, js::MaybeConstruct, js::CallReason) /js/src/vm/Interpreter.cpp:547:12
        #24 0x7fb5d9750584 in CallFromStack /js/src/vm/Interpreter.cpp:619:10
        #25 0x7fb5d9750584 in Interpret(JSContext*, js::RunState&) /js/src/vm/Interpreter.cpp:3375:16
        #26 0x7fb5d974268e in js::RunScript(JSContext*, js::RunState&) /js/src/vm/Interpreter.cpp:431:13
        #27 0x7fb5d976050b in js::InternalCallOrConstruct(JSContext*, JS::CallArgs const&, js::MaybeConstruct, js::CallReason) /js/src/vm/Interpreter.cpp:579:13
        #28 0x7fb5d9761a4c in js::Call(JSContext*, JS::Handle<JS::Value>, JS::Handle<JS::Value>, js::AnyInvokeArgs const&, JS::MutableHandle<JS::Value>, js::CallReason) /js/src/vm/Interpreter.cpp:646:8
        #29 0x7fb5d9818e0c in JS::Call(JSContext*, JS::Handle<JS::Value>, JS::Handle<JS::Value>, JS::HandleValueArray const&, JS::MutableHandle<JS::Value>) /js/src/vm/CallAndConstruct.cpp:117:10
        #30 0x7fb5d51785b1 in mozilla::dom::EventListener::HandleEvent(mozilla::dom::BindingCallContext&, JS::Handle<JS::Value>, mozilla::dom::Event&, mozilla::ErrorResult&) /builds/worker/workspace/obj-build/dom/bindings/EventListenerBinding.cpp:62:8
        #31 0x7fb5d5a32936 in void mozilla::dom::EventListener::HandleEvent<mozilla::dom::EventTarget*>(mozilla::dom::EventTarget* const&, mozilla::dom::Event&, mozilla::ErrorResult&, char const*, mozilla::dom::CallbackObject::ExceptionHandling, JS::Realm*) /builds/worker/workspace/obj-build/dist/include/mozilla/dom/EventListenerBinding.h:65:12
        #32 0x7fb5d5a3265c in mozilla::EventListenerManager::HandleEventSubType(mozilla::EventListenerManager::Listener*, mozilla::dom::Event*, mozilla::dom::EventTarget*) /dom/events/EventListenerManager.cpp:1311:43
        #33 0x7fb5d5a33309 in mozilla::EventListenerManager::HandleEventInternal(nsPresContext*, mozilla::WidgetEvent*, mozilla::dom::Event**, mozilla::dom::EventTarget*, nsEventStatus*, bool) /dom/events/EventListenerManager.cpp:1507:17
        #34 0x7fb5d5a28316 in HandleEvent /dom/events/EventListenerManager.h:395:5
        #35 0x7fb5d5a28316 in mozilla::EventTargetChainItem::HandleEvent(mozilla::EventChainPostVisitor&, mozilla::ELMCreationDetector&) /dom/events/EventDispatcher.cpp:348:17
        #36 0x7fb5d5a2784b in mozilla::EventTargetChainItem::HandleEventTargetChain(nsTArray<mozilla::EventTargetChainItem>&, mozilla::EventChainPostVisitor&, mozilla::EventDispatchingCallback*, mozilla::ELMCreationDetector&) /dom/events/EventDispatcher.cpp:550:16
        #37 0x7fb5d5a2a00b in mozilla::EventDispatcher::Dispatch(nsISupports*, nsPresContext*, mozilla::WidgetEvent*, mozilla::dom::Event*, nsEventStatus*, mozilla::EventDispatchingCallback*, nsTArray<mozilla::dom::EventTarget*>*) /dom/events/EventDispatcher.cpp:1119:11
        #38 0x7fb5d76e6f74 in nsDocumentViewer::LoadComplete(nsresult) /layout/base/nsDocumentViewer.cpp:1079:7
        #39 0x7fb5d8d45a70 in nsDocShell::EndPageLoad(nsIWebProgress*, nsIChannel*, nsresult) /docshell/base/nsDocShell.cpp:6451:20
        #40 0x7fb5d8d4501b in nsDocShell::OnStateChange(nsIWebProgress*, nsIRequest*, unsigned int, nsresult) /docshell/base/nsDocShell.cpp:5844:7
        #41 0x7fb5d8d46946 in non-virtual thunk to nsDocShell::OnStateChange(nsIWebProgress*, nsIRequest*, unsigned int, nsresult) /docshell/base/nsDocShell.cpp
        #42 0x7fb5d32208c8 in nsDocLoader::DoFireOnStateChange(nsIWebProgress*, nsIRequest*, int&, nsresult) /uriloader/base/nsDocLoader.cpp:1380:3
        #43 0x7fb5d321feb2 in nsDocLoader::doStopDocumentLoad(nsIRequest*, nsresult) /uriloader/base/nsDocLoader.cpp:978:14
        #44 0x7fb5d321e163 in nsDocLoader::DocLoaderIsEmpty(bool, mozilla::Maybe<nsresult> const&) /uriloader/base/nsDocLoader.cpp:797:9
        #45 0x7fb5d321f345 in nsDocLoader::OnStopRequest(nsIRequest*, nsresult) /uriloader/base/nsDocLoader.cpp:680:5
        #46 0x7fb5d8d7860e in nsDocShell::OnStopRequest(nsIRequest*, nsresult) /docshell/base/nsDocShell.cpp:13863:23
        #47 0x7fb5d251c8df in mozilla::net::nsLoadGroup::NotifyRemovalObservers(nsIRequest*, nsresult) /netwerk/base/nsLoadGroup.cpp:628:22
        #48 0x7fb5d251de03 in mozilla::net::nsLoadGroup::RemoveRequest(nsIRequest*, nsISupports*, nsresult) /netwerk/base/nsLoadGroup.cpp:532:10
        #49 0x7fb5d3d6f629 in mozilla::dom::Document::DoUnblockOnload() /dom/base/Document.cpp:11505:18
        #50 0x7fb5d3d3bc3b in mozilla::dom::Document::UnblockOnload(bool) /dom/base/Document.cpp:11443:9
        #51 0x7fb5d3d5663a in mozilla::dom::Document::DispatchContentLoadedEvents() /dom/base/Document.cpp:7970:3
        #52 0x7fb5d3e07768 in applyImpl<mozilla::dom::Document, void (mozilla::dom::Document::*)()> /builds/worker/workspace/obj-build/dist/include/nsThreadUtils.h:1147:12
        #53 0x7fb5d3e07768 in apply<mozilla::dom::Document, void (mozilla::dom::Document::*)()> /builds/worker/workspace/obj-build/dist/include/nsThreadUtils.h:1153:12
        #54 0x7fb5d3e07768 in mozilla::detail::RunnableMethodImpl<mozilla::dom::Document*, void (mozilla::dom::Document::*)(), true, (mozilla::RunnableKind)0>::Run() /builds/worker/workspace/obj-build/dist/include/nsThreadUtils.h:1200:13
        #55 0x7fb5d230c2b2 in mozilla::SchedulerGroup::Runnable::Run() /xpcom/threads/SchedulerGroup.cpp:140:20
        #56 0x7fb5d2316535 in mozilla::RunnableTask::Run() /xpcom/threads/TaskController.cpp:538:16
        #57 0x7fb5d2311b1c in mozilla::TaskController::DoExecuteNextTaskOnlyMainThreadInternal(mozilla::detail::BaseAutoLock<mozilla::Mutex&> const&) /xpcom/threads/TaskController.cpp:851:26
        #58 0x7fb5d23106ea in mozilla::TaskController::ExecuteNextTaskOnlyMainThreadInternal(mozilla::detail::BaseAutoLock<mozilla::Mutex&> const&) /xpcom/threads/TaskController.cpp:683:15
        #59 0x7fb5d2310a45 in mozilla::TaskController::ProcessPendingMTTask(bool) /xpcom/threads/TaskController.cpp:461:36
        #60 0x7fb5d2319e36 in operator() /xpcom/threads/TaskController.cpp:187:37
        #61 0x7fb5d2319e36 in mozilla::detail::RunnableFunction<mozilla::TaskController::InitializeInternal()::$_2>::Run() /builds/worker/workspace/obj-build/dist/include/nsThreadUtils.h:531:5
        #62 0x7fb5d232f7c8 in nsThread::ProcessNextEvent(bool, bool*) /xpcom/threads/nsThread.cpp:1204:16
        #63 0x7fb5d2335f3d in NS_ProcessNextEvent(nsIThread*, bool) /xpcom/threads/nsThreadUtils.cpp:465:10
        #64 0x7fb5d2f1bc13 in mozilla::ipc::MessagePump::Run(base::MessagePump::Delegate*) /ipc/glue/MessagePump.cpp:85:21
        #65 0x7fb5d2e41c88 in MessageLoop::RunInternal() /ipc/chromium/src/base/message_loop.cc:381:10
        #66 0x7fb5d2e41b91 in RunHandler /ipc/chromium/src/base/message_loop.cc:374:3
        #67 0x7fb5d2e41b91 in MessageLoop::Run() /ipc/chromium/src/base/message_loop.cc:356:3
        #68 0x7fb5d72eab48 in nsBaseAppShell::Run() /widget/nsBaseAppShell.cpp:150:27
        #69 0x7fb5d9520c6b in XRE_RunAppShell() /toolkit/xre/nsEmbedFunctions.cpp:884:20
        #70 0x7fb5d2f1cad9 in mozilla::ipc::MessagePumpForChildProcess::Run(base::MessagePump::Delegate*) /ipc/glue/MessagePump.cpp:235:9
        #71 0x7fb5d2e41c88 in MessageLoop::RunInternal() /ipc/chromium/src/base/message_loop.cc:381:10
        #72 0x7fb5d2e41b91 in RunHandler /ipc/chromium/src/base/message_loop.cc:374:3
        #73 0x7fb5d2e41b91 in MessageLoop::Run() /ipc/chromium/src/base/message_loop.cc:356:3
        #74 0x7fb5d95201fc in XRE_InitChildProcess(int, char**, XREChildData const*) /toolkit/xre/nsEmbedFunctions.cpp:743:34
        #75 0x5644cc6febe0 in content_process_main /browser/app/../../ipc/contentproc/plugin-container.cpp:57:28
        #76 0x5644cc6febe0 in main /browser/app/nsBrowserApp.cpp:359:18
        #77 0x7fb5e57ded8f in __libc_start_call_main csu/../sysdeps/nptl/libc_start_call_main.h:58:16
        #78 0x7fb5e57dee3f in __libc_start_main csu/../csu/libc-start.c:392:3
        #79 0x5644cc6d5248 in _start (/home/jkratzer/builds/m-c-20221114085151-fuzzing-debug/firefox-bin+0x5b248) (BuildId: d633bff2a8149f90cb651606f90c2bfad553154e)
    
    UndefinedBehaviorSanitizer can not provide additional info.
    SUMMARY: UndefinedBehaviorSanitizer: SEGV /builds/worker/workspace/obj-build/dist/include/mozilla/Assertions.h:261:3 in MOZ_Crash
    ==807981==ABORTING

Comment 1

[Jason Kratzer [:jkratzer]]

Attachment: Testcase

Comment 2

[Jeff Muizelaar [:jrmuizel]]

I think this is mostly harmless. Overflow will happen and we'll fail the subsequent if condition which limits the damage.

Comment 3

[Bugmon [:jkratzer for issues]]

Verified bug as reproducible on mozilla-central 20221118154632-3b5a8f67189b.
The bug appears to have been introduced in the following build range:

Start: c671a799829d029e89c7aa4a4f5a59b425ad2e58 (20221112094729)
End: b87135d72be81eaa782bcdff139cd191421387a4 (20221112084418)
Pushlog: https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=c671a799829d029e89c7aa4a4f5a59b425ad2e58&tochange=b87135d72be81eaa782bcdff139cd191421387a4

Comment 4

[BugBot [:suhaib / :marco/ :calixte]]

This bug has been marked as a regression. Setting status flag for Nightly to affected.

Comment 5

[BugBot [:suhaib / :marco/ :calixte]]

The severity field is not set for this bug.
:lsalzman, could you have a look please?

For more information, please visit auto_nag documentation.

Comment 6

[Bugmon [:jkratzer for issues]]

A pernosco session for this bug can be found here.

Comment 7

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1799402

Comment 8

[Bugmon [:jkratzer for issues]]

Testcase crashes using the initial build (mozilla-central 20221114085151-20e2590324e2) but not with tip (mozilla-central 20230317210204-c6b709a45852.)

Unable to bisect testcase (End build crashes!):

Start: 20e2590324e26b5ebc2f86ade34286967e0a58a8 (20221114085151)
End: c6b709a45852a4cd2a5651c2cce23718f5da02cb (20230317210204)
BuildFlags: BuildFlags(asan=False, tsan=False, debug=True, fuzzing=True, coverage=False, valgrind=False, no_opt=False, fuzzilli=False, nyx=False)

Removing bugmon keyword as no further action possible. Please review the bug and re-add the keyword for further analysis.

Comment 9

[Tyson Smith [:tsmith]]

I am able to reproduce the issue with the attached test case using m-c 20231215-d3a29d02b3dd.

I ran grizzly.replay.bugzilla <firefox> 1800471 --xvfb on Ubuntu 22.04 using a debug build.

Comment 10

[Bugmon [:jkratzer for issues]]

Verified bug as reproducible on mozilla-central 20231215214115-8fd04cb03fbd.
Unable to bisect testcase (failed to find build near 20e2590324e2).

Comment 11

[Bugmon [:jkratzer for issues]]

Testcase crashes using the initial build (mozilla-central 20221224090645-dfbd00b278b0) but not with tip (mozilla-central 20231222213932-8989af6649bf.)

Unable to bisect testcase (End build crashes!):

Start: dfbd00b278b023a3f187d55d8caf245f6a057ce4 (20221224090645)
End: 8989af6649bfc887cb1a9cc9105158a806a9b39f (20231222213932)
BuildFlags: BuildFlags(asan=False, tsan=False, debug=True, fuzzing=True, coverage=False, valgrind=False, no_opt=False, fuzzilli=False, nyx=False)

Removing bugmon keyword as no further action possible. Please review the bug and re-add the keyword for further analysis.