Closed Bug 1800576 Opened 3 months ago Closed 2 months ago

Site permission consent flow should describe the nature of the add-on in the first panel

Categories

(Toolkit :: Add-ons Manager, defect)

defect

Tracking

()

VERIFIED FIXED
109 Branch
Tracking Status
firefox108 --- verified
firefox109 --- verified

People

(Reporter: bholley, Assigned: bholley)

References

Details

Attachments

(1 file)

Johan pointed out that the first panel is totally generic (aside from the "learn more" link), and that the only way to understand the nature of the request is to click "Continue to Installation". I agree this could be improved, and came up with some modified language which I think conveys things better.

Pushed by bholley@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/54be557d5e90
— Site permission consent flow should describe the nature of the add-on in the first panel. r=rpl,flod
Status: NEW → RESOLVED
Closed: 2 months ago
Resolution: --- → FIXED
Target Milestone: --- → 109 Branch

Comment on attachment 9303423 [details]
Bug 1800576 — Site permission consent flow should describe the nature of the add-on in the first panel.

Beta/Release Uplift Approval Request

  • User impact if declined: The consent flow language is more confusing that it ought to be. This patch makes it clearer what's going on and why, and it's worth having the improved language in the initial release.
  • Is this code covered by automated tests?: Yes
  • Has the fix been verified in Nightly?: Yes
  • Needs manual test from QE?: No
  • If yes, steps to reproduce:
  • List of other uplifts needed: None
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky):
  • String changes made/needed: This includes new strings. I've discused the situation with flod. There is some risk that some less-common languages won't be able to localize the strings in time and that they may see English, but this feature is rare enough that we're willing to accept that risk.
  • Is Android affected?: No
Attachment #9303423 - Flags: approval-mozilla-beta?

Comment on attachment 9303423 [details]
Bug 1800576 — Site permission consent flow should describe the nature of the add-on in the first panel.

Approved for 108.0b3

Attachment #9303423 - Flags: approval-mozilla-beta? → approval-mozilla-beta+

Bobby, could we manually verify the updates from this issue? If yes, could you please guide as with some steps for verification.

Flags: needinfo?(bholley)

You can verify this by confirming that the first pane of the consent flow has this text: https://github.com/mozilla/standards-positions/pull/704#issuecomment-1317595992

Flags: needinfo?(bholley)

To clarify, you'll need to set the midi.testing pref to true, restart the browser, and then visit webmidi-examples.glitch.me/ to see the consent flow.

QA Whiteboard: [qa-triaged]
Flags: qe-verify+

I've verified as fixed this bug using the latest Beta 108.0b4 and Nightly 109.0a1 builds, under Win 7 x64, macOS 11 and Ubuntu 18.04 x64.

Status: RESOLVED → VERIFIED
Flags: qe-verify+
QA Whiteboard: [qa-triaged]
You need to log in before you can comment on or make changes to this bug.