1800576 - Site permission consent flow should describe the nature of the add-on in the first panel

Status: VERIFIED FIXED

(Toolkit :: Add-ons Manager, defect)

Description

[Bobby Holley (:bholley)]

Johan pointed out that the first panel is totally generic (aside from the "learn more" link), and that the only way to understand the nature of the request is to click "Continue to Installation". I agree this could be improved, and came up with some modified language which I think conveys things better.

Comment 1

[Bobby Holley (:bholley)]

Attachment: Bug 1800576 — Site permission consent flow should describe the nature of the add-on in the first panel.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/54be557d5e90
— Site permission consent flow should describe the nature of the add-on in the first panel. r=rpl,flod

Comment 3

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/54be557d5e90

Comment 4

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/54be557d5e90

Comment 5

[Bobby Holley (:bholley)]

Comment on attachment 9303423 [details]
Bug 1800576 — Site permission consent flow should describe the nature of the add-on in the first panel.

Beta/Release Uplift Approval Request

• User impact if declined: The consent flow language is more confusing that it ought to be. This patch makes it clearer what's going on and why, and it's worth having the improved language in the initial release.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky):
• String changes made/needed: This includes new strings. I've discused the situation with flod. There is some risk that some less-common languages won't be able to localize the strings in time and that they may see English, but this feature is rare enough that we're willing to accept that risk.
• Is Android affected?: No

Comment 6

[Dianna Smith [:diannaS]]

Comment on attachment 9303423 [details]
Bug 1800576 — Site permission consent flow should describe the nature of the add-on in the first panel.

Approved for 108.0b3

Comment 7

[Dianna Smith [:diannaS]]

https://hg.mozilla.org/releases/mozilla-beta/rev/ede99846e699

Comment 8

[Brindusa Tot, Desktop QA]

Bobby, could we manually verify the updates from this issue? If yes, could you please guide as with some steps for verification.

Comment 9

[Bobby Holley (:bholley)]

You can verify this by confirming that the first pane of the consent flow has this text: https://github.com/mozilla/standards-positions/pull/704#issuecomment-1317595992

Comment 10

[Bobby Holley (:bholley)]

To clarify, you'll need to set the midi.testing pref to true, restart the browser, and then visit webmidi-examples.glitch.me/ to see the consent flow.

Comment 11

[Ciprian Georgiu, Desktop QA]

I've verified as fixed this bug using the latest Beta 108.0b4 and Nightly 109.0a1 builds, under Win 7 x64, macOS 11 and Ubuntu 18.04 x64.