1800670 - Add the cookie banner menu item to the protections panel

Status: RESOLVED FIXED

(Core :: Privacy: Anti-Tracking, enhancement)

Description

[Jared Hirsch [:jhirsch] (he/him) (Needinfo please)]

Add the cookie banner handling menu item to the protections panel, in the default "nothing detected" state.

UX: See the 'Engineering Handoff' page in this Figma: https://www.figma.com/file/FAZxkK9IRLlCqyhXBqId7e/Auto-Cookie-Banner-Consent-Desktop?node-id=0%3A1&t=3hW7YfzeA9PldFgy-0

Comment 1

[Jared Hirsch [:jhirsch] (he/him) (Needinfo please)]

Attachment: Bug 1800670 - Update cookie banner handling UI in protections popup r=pbz,Itiel

This patch also implements bug 1800671 and bug 1800673.

Still need to finish updating tests, but wanted to get an initial review
started in the meantime.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0072aa5cd31d
Update cookie banner handling UI in protections popup r=pbz

Comment 5

[Atila Butkovits]

Backed out for causing multiple mochitest failures.

Backout link: https://hg.mozilla.org/integration/autoland/rev/47edf573a01c21d4bc43295aa293627076d47c15

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=0072aa5cd31d57802d5e8ca45d5f98f8848a142d&selectedTaskRun=ObP-MbYEQAaKR8a4xIlhaA.0

Failure log:

https://treeherder.mozilla.org/logviewer?job_id=403954992&repo=autoland&lineNumber=2415

https://treeherder.mozilla.org/logviewer?job_id=403954691&repo=autoland&lineNumber=8490

Comment 6

[Jared Hirsch [:jhirsch] (he/him) (Needinfo please)]

Thanks for the heads up! Looking now.

Comment 7

[Jared Hirsch [:jhirsch] (he/him) (Needinfo please)]

Looks like I was not correctly initializing the fluent variable $host by setting a blank value in the DOM. Making that change fixes the test for me locally. Attempting a relanding now.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/68de023d3c5c
Update cookie banner handling UI in protections popup r=pbz

Comment 9

[Noemi Erli[:noemi_erli]]

Backed out changeset 68de023d3c5c (Bug 1800670) for causing failures in browser_protectionsUI_cookie_banner.js CLOSED TREE

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&collapsedPushes=842382&resultStatus=pending%2Crunning%2Csuccess%2Ctestfailed%2Cbusted%2Cexception&classifiedState=unclassified&searchStr=linux%2C18.04%2Cx64%2Cwebrender%2Copt%2Cmochitests%2Cwith%2Cnetworking%2Con%2Csocket%2Cprocess%2Ctest-linux1804-64-qr%2Fopt-mochitest-browser-chrome-spi-nw%2C&revision=68de023d3c5c1d00d657895a3bd8af989da14bf5

Log: https://treeherder.mozilla.org/logviewer?job_id=403989446&repo=autoland&lineNumber=3489

Backout: https://hg.mozilla.org/integration/autoland/rev/d2c3f90f07351317b4ac0cda5472d45e337be6cb

Comment 10

[Jared Hirsch [:jhirsch] (he/him) (Needinfo please)]

My best guess at the breakage here is that chaos mode causes timeouts to behave unpredictably, and there are a few timeouts in the test, which we are already planning to remove as a followup. To be continued, but I suspect disabling this test in chaos mode temporarily is the best path forward.

Comment 11

[Jared Hirsch [:jhirsch] (he/him) (Needinfo please)]

Added some test improvements suggested by :pbz and disabled the test temporarily in chaos mode. I think we should now be good to attempt another landing.

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f878cff45427
Update cookie banner handling UI in protections popup r=pbz

Comment 13

[Atila Butkovits]

Backed out for causing failures at browser_protectionsUI_cookie_banner.js.

Backout link: https://hg.mozilla.org/integration/autoland/rev/e4d29479534216aef9088a37cfeb1c9053cef423

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=f878cff45427911ce4879546595886bd538ffe83&selectedTaskRun=ckaFB8ShROKL78UkjBER0A.0

Failure log: https://treeherder.mozilla.org/logviewer?job_id=404244400&repo=autoland&lineNumber=4721

Comment 15

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b9da0cd521fc
Update cookie banner handling UI in protections popup r=pbz

Comment 16

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/b9da0cd521fc