1800724 - Implement DecoratorEmitter::emitCreateAddInitializerFunction

Status: RESOLVED FIXED

(Core :: JavaScript Engine, enhancement, P2)

Description

[Dan Minor [:dminor]]

A DecoratorEmitter is being added as part of Bug 1793959. The implementation of emitCreateAddInitializerFunction is complicated enough to break out into a follow up bug.

Comment 1

[Dan Minor [:dminor]]

Attachment: WIP: Bug 1800724 - Implement emitCreateAddInitializerFunction

Comment 2

[Dan Minor [:dminor]]

Attachment: WIP: Bug 1800724 - Implement emitCreateAddInitializerFunction (WIP)

Comment 3

[Dan Minor [:dminor]]

Attachment: WIP: Bug 1800724 - Implement DecoratorEmitter::emitCreateAddInitializerFunction

Comment 4

[Dan Minor [:dminor]]

When I first filed this bug, I thought there was only one set of extra initializers, similar to the current .initializers, but it runs out they can be added for static fields and at the class level as well. Since this is turning into a big project, I'm going to split out support for static and class extra initializers into follow up bugs.

Comment 5

[Dan Minor [:dminor]]

Attachment: Bug 1800724 - Add properties for instance extra initializers; r=arai

Comment 6

[Dan Minor [:dminor]]

Attachment: Bug 1800724 - Add synthesizeAddInitializerFunction to Parser; r=arai!

Depends on D195915

Comment 7

[Dan Minor [:dminor]]

Attachment: Bug 1800724 - Prepare for extra initializers in ObjectEmitter; r=arai!

Depends on D195916

Comment 8

[Dan Minor [:dminor]]

Attachment: Bug 1800724 - Call prepareForExtraInitializers in BytecodeEmitter; r=arai!

Depends on D195917

Comment 9

[Dan Minor [:dminor]]

Attachment: Bug 1800724 - Move emitCheckIsCallable to BytecodeEmitter; r=arai!

We'll want to be able to use this while generating the function code for addInitializer,
so we need to be able to specify the BytecodeEmitter to use.

Depends on D195918

Comment 10

[Dan Minor [:dminor]]

Attachment: Bug 1800724 - Implement DecoratorEmitter::emitCreateAddInitializerFunction; r=arai!

Depends on D195919

Comment 11

[Dan Minor [:dminor]]

Attachment: Bug 1800724 - Pass addInitializerFunction on stack to emitCreateDecoratorContextObject; r=arai!

Depends on D195920

Comment 12

[Dan Minor [:dminor]]

Attachment: Bug 1800724 - Use DecoratorEmitter::emitCreateAddInitializerFunction for non-static fields in BytecodeEmitter; r=arai!

Depends on D195921

Comment 13

[Dan Minor [:dminor]]

Attachment: Bug 1800724 - Implement DecoratorEmitter::emitCallExtraInitializers; r=arai!

Depends on D195922

Comment 14

[Dan Minor [:dminor]]

Attachment: Bug 1800724 - Use DecoratorEmitter::emitCallExtraInitializers in BytecodeEmitter; r=arai!

Depends on D195923

Comment 15

[Dan Minor [:dminor]]

Attachment: Bug 1800724 - Update references to follow up bug for emitDecorationState and emitUpdateDecorationState; r=arai!

Depends on D195924

Comment 16

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/35620d1f3d31
Add properties for instance extra initializers; r=arai
https://hg.mozilla.org/integration/autoland/rev/f10f9cab1395
Add synthesizeAddInitializerFunction to Parser; r=arai
https://hg.mozilla.org/integration/autoland/rev/8510ebb4bc51
Prepare for extra initializers in ObjectEmitter; r=arai
https://hg.mozilla.org/integration/autoland/rev/7bfbd3878605
Call prepareForExtraInitializers in BytecodeEmitter; r=arai
https://hg.mozilla.org/integration/autoland/rev/3b59324b7194
Move emitCheckIsCallable to BytecodeEmitter; r=arai
https://hg.mozilla.org/integration/autoland/rev/7bb98802a27b
Implement DecoratorEmitter::emitCreateAddInitializerFunction; r=arai
https://hg.mozilla.org/integration/autoland/rev/4905307036cd
Pass addInitializerFunction on stack to emitCreateDecoratorContextObject; r=arai
https://hg.mozilla.org/integration/autoland/rev/5790563a32c5
Use DecoratorEmitter::emitCreateAddInitializerFunction for non-static fields in BytecodeEmitter; r=arai
https://hg.mozilla.org/integration/autoland/rev/d2d10d00585b
Implement DecoratorEmitter::emitCallExtraInitializers; r=arai
https://hg.mozilla.org/integration/autoland/rev/67c0d6dc77af
Use DecoratorEmitter::emitCallExtraInitializers in BytecodeEmitter; r=arai
https://hg.mozilla.org/integration/autoland/rev/847f583eeaaa
Update references to follow up bug for emitDecorationState and emitUpdateDecorationState; r=arai

Comment 17

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/35620d1f3d31
https://hg.mozilla.org/mozilla-central/rev/f10f9cab1395
https://hg.mozilla.org/mozilla-central/rev/8510ebb4bc51
https://hg.mozilla.org/mozilla-central/rev/7bfbd3878605
https://hg.mozilla.org/mozilla-central/rev/3b59324b7194
https://hg.mozilla.org/mozilla-central/rev/7bb98802a27b
https://hg.mozilla.org/mozilla-central/rev/4905307036cd
https://hg.mozilla.org/mozilla-central/rev/5790563a32c5
https://hg.mozilla.org/mozilla-central/rev/d2d10d00585b
https://hg.mozilla.org/mozilla-central/rev/67c0d6dc77af
https://hg.mozilla.org/mozilla-central/rev/847f583eeaaa