1800733 - The saved passwords are not imported from Opera on MacOS

Status: VERIFIED FIXED

(Firefox :: Migration, defect, P3)

Description

[Raluca Popovici, Desktop QA]

Found in

• Nightly 109.0a1

Affected versions

• Nightly 109.0a1

Tested platforms

• Affected platforms: All MacOS
• Unaffected platforms: Win 10, Ubuntu

Preconditions

• Have a password set for the OS's account.
• Have multiple saved passwords in Opera.
• Set pref "browser.migrate.opera.enabled" on true on Firefox.

Steps to reproduce

1. Open the latest Nightly browser navigate to "about:logins" page and click the Open Menu(three-dot ellipsis) button.
2. Click the "Import from Another Browser" option.
3. Select Opera and click the "Continue" button.
4. Select "Saved logins and passwords" and click "Continue".
5. Click "Done" button

Expected result

• The saved passwords are imported and "enter keychain password" is required.

Actual result

• "enter keychain password" is not required and the saved passwords are not imported on Nightly.

Regression range

• Not a regression. This bug is reproducible only on Nightly 109 because of the new feature implementation.

Additional notes

• This issue is reproducible only on MacOS

Comment 1

[Mike Conley (:mconley) (:⚙️)]

This also appears to affect the Opera GX migrator.

Comment 2

[Mike Conley (:mconley) (:⚙️)]

Attachment: Bug 1800733 - Fix macOS keychain values for Opera and Opera GX migrators. r?Gijs!

It turns out we just had these two values wrong. Using the Keychain Access utility
on macOS, I was able to find the right values for both browsers and then do a
successfull password import from each.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/baca9604cdcb
Fix macOS keychain values for Opera and Opera GX migrators. r=Gijs

Comment 4

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/baca9604cdcb

Comment 5

[Raluca Popovici, Desktop QA]

Verified fixed on MacOS 11.6 using Nightly 101.0a1(2022-12-22), successful import of passwords from Opera/ Opera GX and Vivaldi migrators.