1800772 - Perma toolkit/components/pictureinpicture/tests/browser_durationChange.js | Expected to get the right mouse events. - ["mousedown","mouseup"] deepEqual ["pointerdown","mousedown","pointerup","mouseup"] - JS frame... when Gecko 109 merges to Beta on 2022

Status: VERIFIED FIXED

(Toolkit :: Picture-in-Picture, defect)

Description

[Marian-Vasile Laza]

Central-as-beta-simulation

How to run these simulations

Failure log

[task 2022-11-15T13:05:01.404Z] 13:05:01     INFO - TEST-PASS | toolkit/components/pictureinpicture/tests/browser_durationChange.js | Toggle reached target opacity. - true == true - 
[task 2022-11-15T13:05:01.405Z] 13:05:01     INFO - Right-clicking on toggle.
[task 2022-11-15T13:05:01.405Z] 13:05:01     INFO - Buffered messages finished
[task 2022-11-15T13:05:01.406Z] 13:05:01     INFO - TEST-UNEXPECTED-FAIL | toolkit/components/pictureinpicture/tests/browser_durationChange.js | Expected to get the right mouse events. - ["mousedown","mouseup"] deepEqual ["pointerdown","mousedown","pointerup","mouseup"] - JS frame :: chrome://mochitests/content/browser/toolkit/components/pictureinpicture/tests/head.js :: assertSawMouseEvents :: line 383
[task 2022-11-15T13:05:01.406Z] 13:05:01     INFO - Stack trace:
[task 2022-11-15T13:05:01.406Z] 13:05:01     INFO - chrome://mochitests/content/browser/toolkit/components/pictureinpicture/tests/head.js:assertSawMouseEvents:383
[task 2022-11-15T13:05:01.407Z] 13:05:01     INFO - TEST-PASS | toolkit/components/pictureinpicture/tests/browser_durationChange.js | No Picture-in-Picture window found. - 

Comment 1

[Molly Howell (she/her) (mostly inactive)]

This seems to be related to bug 1799565; I can turn the failures off and on just by flipping the pref that that bug added. Kagami, what's your advice about how to handle this? We don't have any real dependency on the pointer events themselves, we just need to be able to have a consistent set of events that we can expect to get.

Comment 2

[Kagami Rosylight 🏳️‍🌈🏳️‍⚧️ [:saschanaz] (they/them)]

Ah, it's the logic in bug 1799565, it shouldn't return pref(); or it'll block pointer events unconditionally without the pref. I'll fix it.

Comment 3

[Kagami Rosylight 🏳️‍🌈🏳️‍⚧️ [:saschanaz] (they/them)]

Attachment: Bug 1800772 - Early return only when the pref is true r=smaug

Otherwise no form element will get pointer events on beta 😬

Depends on D162105

Comment 4

[Kagami Rosylight 🏳️‍🌈🏳️‍⚧️ [:saschanaz] (they/them)]

Attachment: Bug 1800772 - Early return only when the pref is true r=smaug

Otherwise no form element will get pointer events on beta 😬

Depends on D162105

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0f86833852a9
Early return only when the pref is true r=smaug

Comment 6

[Norisz Fay [:noriszfay]]

Patch is working in today's central as beta simulation

Comment 7

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/0f86833852a9

Comment 8

[Cosmin Sabou [:CosminS]]

https://treeherder.mozilla.org/jobs?repo=try&resultStatus=success%2Ctestfailed%2Cbusted%2Cexception%2Crunnable&revision=39ebadcaf7ea950074c6e4c5e7d7d3ff89ef7713&test_paths=toolkit%2Fcomponents%2Fpictureinpicture%2Ftests%2Fbrowser.ini