1800833 - Simplify NetworkObserver handling of response cookies and headers

Status: RESOLVED FIXED

(DevTools :: Netmonitor, task)

Description

[Julian Descottes [:jdescottes]]

At the moment, response cookies and headers are a shared responsibility between NetworkObserver and NetworkResponseListener, and require a lot of boilerplate to work.

First of all we have the #openResponses property of NetworkObserver which is a ChannelMap instance containing "response" objects. Those "response" seem to contain a lot of information (id, channel, httpVersion, status, statusText, cookies and headers) but only cookies and headers are actually used. So we could simplify the object.

Then the main issue is that #openResponses are owned and filled by NetworkObserver, but the NetworkResponseListener is responsible for reading it and notifying the consumer about potential response cookies and headers. Ideally, we should move that responsibility back to NetworkObserver, it's not clear why we can't simply notify consumers when we collect the response cookies and headers, which consistently happens in NetworkObserver:#httpResponseExaminer

Comment 1

[Julian Descottes [:jdescottes]]

Attachment: Bug 1800833 - [devtools] Clarify the content of networkObserver's openResponses

Depends on D162205

Comment 2

[Julian Descottes [:jdescottes]]

Attachment: Bug 1800833 - [devtools] Notify about response cookies and headers from NetworkObserver directly

Depends on D162206

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/05df30e6f7e9
[devtools] Clarify the content of networkObserver's openResponses r=bomsy
https://hg.mozilla.org/integration/autoland/rev/a548d0e36104
[devtools] Notify about response cookies and headers from NetworkObserver directly r=bomsy

Comment 4

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/05df30e6f7e9
https://hg.mozilla.org/mozilla-central/rev/a548d0e36104