1800838 - Move request blocking outside of the NetworkEvent payload creation

Status: RESOLVED FIXED

(DevTools :: Netmonitor, task, P3)

Description

[Julian Descottes [:jdescottes]]

At the moment, the actual call to nsIChannel.cancel for blocked requests happens in the middle of NetworkUtils' createNetworkEvent. Other than this, this method is purely dedicated to building an event payload (mostly renaming and aggregating properties from the Channel), so it's very unexpected to perform the call to cancel here.

At the very least this should move to NetworkObserver, who owns the list of blocked URLs, and preferably it should be handled at specific points of the request's lifecycle, not in a generic event creation method.

Also note that we rebuild URL pattern regexps each and every time we need to check for request blocking. We should probably build the regexps once, when a blocked URL is added.

Comment 1

[Julian Descottes [:jdescottes]]

Attachment: Bug 1800838 - [devtools] Request blocking should not be handled in the middle of NetworkEvent payload creation

Depends on D162195

Comment 2

[Julian Descottes [:jdescottes]]

Attachment: Bug 1800838 - [devtools] Do not create new request blocking regexp for each and every channel

Depends on D162204

Comment 3

[Julian Descottes [:jdescottes]]

Attachment: Bug 1800838 - [devtools] Add shared helper for typing in netmonitor

This helper was duplicated in many tests.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d9a7d7c2d92d
[devtools] Add shared helper for typing in netmonitor r=bomsy
https://hg.mozilla.org/integration/autoland/rev/317936ce53ce
[devtools] Request blocking should not be handled in the middle of NetworkEvent payload creation r=bomsy
https://hg.mozilla.org/integration/autoland/rev/b048606f56cd
[devtools] Do not create new request blocking regexp for each and every channel r=bomsy

Comment 5

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/d9a7d7c2d92d
https://hg.mozilla.org/mozilla-central/rev/317936ce53ce
https://hg.mozilla.org/mozilla-central/rev/b048606f56cd