1800967 - Wrong (or missing) style on overflowed extension widgets pinned in the toolbar

Status: RESOLVED FIXED

(WebExtensions :: General, defect, P1)

Description

[William Durand [:willdurand]]

Attachment: screenshot of the problem

STR

1. Install an extension like uBlock
2. Pin it to the toolbar
3. Resize window to overflow the uBlock button in the unified extensions panel
4. Unpin uBlock in the panel
5. Increase the size (width) of the window

Expected

We should not see the extension widget in the toolbar, the extension should stay in the unified extensions panel.

Actual

See screenshot, when we resize the window, we see an extension in the toolbar and the style is off.

Comment 1

[William Durand [:willdurand]]

Re-reading the STR above, I am not sure this is just a pure CSS issue to be honest..

Comment 2

[Mike Conley (:mconley) (:⚙️)]

Looks like the cui-areatype isn't being properly set to toolbar after the item underflows. Investigating.

Comment 3

[Mike Conley (:mconley) (:⚙️)]

It turns out that this is related to bug 1798377, in that the internal collection of overflowed items isn't being properly updated when browser action widgets are being moved out of the overflowable toolbar while overflowed.

Comment 4

[Mike Conley (:mconley) (:⚙️)]

Attachment: Bug 1800967 - Update internal OverflowableToolbar state when unpinning an extension button from the toolbar when overflowed. r?Gijs!,willdurand!

We have some internal bookkeeping within OverflowableToolbar to remember the state of things that
have overflowed, like how wide the window needs to be before they can be moved back, etc. When an
item is removed from an overflowable toolbar while overflowed, we update that internal bookkeeping
so that OverflowableToolbar doesn't accidentally try to move those items back into the toolbar
when the window becomes wide enough again.

We've added a new overflow list for extension buttons, but we weren't updating our internal accounting
when items had been overflowed into that list. This patch fixes that.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9b51c28937ff
Update internal OverflowableToolbar state when unpinning an extension button from the toolbar when overflowed. r=willdurand,Gijs

Comment 6

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/9b51c28937ff