1800969 - Consider aliasing -webkit-clip-path to clip-path

Status: RESOLVED FIXED

(Core :: Layout, defect, P1)

Description

[Thomas Wisniewski [:twisniewski]]

It seems there are sites out there which never added the standard clip-path CSS property, and just have -webkit-clip-path. For instance, fr.techtribune.net uses clip paths to create the illusion that page ads "roll under" their page content as the user scrolls down the page, but since they do not have the unprefixed variant, the ads are always on top, completely breaking their page.

As such it seems like it's worth supporting that prefix as a basic alias, since I don't recall -webkit-clip-path having any quirky behavior, and I don't recall us having any major interop issues left with clip-path support which should leave us in a worse position if we alias the prefixed version.

Comment 1

[Emilio Cobos Álvarez [:emilio]]

Adding extra_prefixes="webkit", here plus a test should be enough.

Comment 2

[Thomas Wisniewski [:twisniewski]]

Attachment: Bug 1800969 - Alias -webkit-clip-path to clip-path for webcompat; r?emilio

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b893eee8c864
Alias -webkit-clip-path to clip-path for webcompat; r=emilio

Comment 4

[Noemi Erli[:noemi_erli]]

Backed out changeset b893eee8c864 (Bug 1800969) for causing failures in test_css-properties-db.js CLOSED TREE

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&collapsedPushes=842382&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=b893eee8c864a3ce5c706d93442e388c718e3d61&selectedTaskRun=Zfv0qtF0QAm0bxkT90wLZA.0

Log: https://treeherder.mozilla.org/logviewer?job_id=397423061&repo=autoland&lineNumber=5225

Backout: https://hg.mozilla.org/integration/autoland/rev/f150bc1f71d09e1e1941065951f0f5a38628f080

Comment 5

[Thomas Wisniewski [:twisniewski]]

Ah, I didn't remember that devtools test. I'm not seeing any other failures in that try run, so I'll push again with that test fixed.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/864c533448d8
Alias -webkit-clip-path to clip-path for webcompat; r=emilio

Comment 7

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/864c533448d8