180098 - "--enable-activex-scripting" option seems to break composition window.

Status: RESOLVED FIXED

(Core :: XPConnect, defect)

Description

[Frederic Bezies]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.3a) Gecko/20021113
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.3a) Gecko/20021113

I cannot use anymore mailnews composition windows in CVS based build since
yesterday.

Composition is still broken, even using a new tarball source and apply CVS on it.



Reproducible: Always

Steps to Reproduce:
1. Grab a tarball source from 13 november
2. Use CVS on it


Actual Results:  
After building, composition window is still broken ! :-/

From bar is empty :-|

Expected Results:  
Working composition window.

Trying with a blank new profile doesn't change a thing. I will post asap a
screenshot of the bug I'm seeing.

I am using classic theme, and when running Profile manager, new mozilla is using
modern theme ?!

Comment 1

[Frederic Bezies]

Attachment: Screenshot of broken composition window

Comment 2

[Frederic Bezies]

Here is my .mozconfig if it helps a little :

ac_add_options --enable-activex-scripting
ac_add_options --disable-pedantic
ac_add_options --disable-tests
ac_add_options --disable-debug
ac_add_options --enable-strip
ac_add_options --enable-optimize="-O2"
ac_add_options --enable-crypto

Is active-scripting guilty here ?!

Comment 3

[R.K.Aa.]

Did you clobber?
Are you unable to select an account in the "From" dropdown?
WFM, current CVS, Linux.

Comment 4

[Frederic Bezies]

I cannot choose any from because of an empty list. But, after grabbing a brand
new tarball and update it with CVS, I think I find the "guilty".

It seems to be related to "--enable-activex-scripting" option.

It completely brokes composition window. What a pity I do not have js error :-/

Very strange !

If I delete this option, mozilla is working without problem !

By the way, "--enable-activex-scripting option" is win32 only.

Comment 5

[hacker formerly known as [e-mail]]

activex -> adamlock

Comment 6

[hacker formerly known as [e-mail]]

Moving to proper component.

Comment 7

[Adam Lock]

CC'ing David for ideas. I don't see anything in the plugin which might cause it,
though I guess it could be a COM connect issue.

Comment 8

[Adam Lock]

The compose window has two errors, either of which may be the cause, unrelated
to the activex-scripting flag

JavaScript error:
chrome://help/content/contextHelp.js line 1: redeclaration of const MOZ_HELP_URI

JavaScript error:
chrome://editor/content/editorUtilities.js line 1: redeclaration of const XUL_NS

Comment 9

[Frederic Bezies]

In answer to comment #8 : those broken composition window only appears when I
use "--enable-active-scripting" for building.

I've built the mozilla I am using, without "--enable-active-scripting" and no
problem. :-|

Comment 10

[David Bradley]

I'll take this, I'm sure it's probably some hole I created in XPConnect

Comment 11

[David Bradley]

Attachment: Fixes the enumerate bustage

I botched the enumerator. I was thinking of a hook that would always get
called, but when I implemented I implemented assuming that IDispatch interface
had already been determined. The result was that this returned false and caused
enumerating wrapped natives to fail.

Comment 12

[David Bradley]

Attachment: Added test for IDispatch enabled

Comment 13

[Adam Lock]

Comment on attachment 106250 [details] [diff] [review]
Added test for IDispatch enabled

r=adamlock

Comment 14

[Johnny Stenback (:jst)]

Comment on attachment 106250 [details] [diff] [review]
Added test for IDispatch enabled

sr=jst

Comment 15

[David Bradley]

Patch checked in

Comment 16

[Frederic Bezies]

You can mark it verified fixed. I am using a build with
"--enable-activex-scripting" option and it works.

Thanks for fixing this bug.