1800981 - Crash in [@ nsHtml5Parser::UnblockParser]

Status: VERIFIED FIXED

(Core :: DOM: Core & HTML, defect, P1)

Description

[Kevin Locke]

Crash report: https://crash-stats.mozilla.org/report/index/e47b4e92-18b0-4641-a367-9aa930221116

MOZ_CRASH Reason: MOZ_DIAGNOSTIC_ASSERT(mBlocked > 0)

Top 10 frames of crashing thread:

0  libxul.so  nsHtml5Parser::UnblockParser  parser/html/nsHtml5Parser.cpp:130
1  libxul.so  nsIScriptElement::UnblockParser  dom/script/nsIScriptElement.cpp:21
2  libxul.so  mozilla::dom::ScriptLoader::UnblockParser  dom/script/ScriptLoader.cpp:3219
2  libxul.so  mozilla::dom::ScriptLoader::HandleLoadError  dom/script/ScriptLoader.cpp:3192
3  libxul.so  mozilla::dom::ScriptLoader::OnStreamComplete  dom/script/ScriptLoader.cpp:2959
3  libxul.so  mozilla::dom::ScriptLoadHandler::OnStreamComplete  dom/script/ScriptLoadHandler.cpp:460
4  libxul.so  nsIncrementalStreamLoader::OnStopRequest  netwerk/base/nsIncrementalStreamLoader.cpp:82
5  libxul.so  mozilla::net::HttpChannelChild::DoOnStopRequest  netwerk/protocol/http/HttpChannelChild.cpp:1051
5  libxul.so  mozilla::net::HttpChannelChild::OnStopRequest  netwerk/protocol/http/HttpChannelChild.cpp:928
5  libxul.so  mozilla::net::HttpChannelChild::ProcessOnStopRequest  netwerk/protocol/http/HttpChannelChild.cpp:802

Reliable crash visiting https://about.gitlab.com

Pushlog https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=a140341548916ef553ec4bfd5e9a92b60c355a69&tochange=dd72eb737d96be466be10fb911116244039eac7d suggests it was regressed by Bug 1632975.

Comment 1

[Adam Vandolder [:avandolder]]

This should be fixed with the update patch for bug 1632975.

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

The bug is marked as tracked for firefox109 (nightly). However, the bug still isn't assigned.

:hsinyi, could you please find an assignee for this tracked bug? Given that it is a regression and we know the cause, we could also simply backout the regressor. If you disagree with the tracking decision, please talk with the release managers.

For more information, please visit auto_nag documentation.

Comment 3

[Ryan VanderMeulen [:RyanVM]]

Bug 1632975 re-landed without these crashes returning.

Comment 4

[Ciprian Georgiu, Desktop QA]

I have reproduced this crash using an affected Nightly build from 2022-11-16, with macOS 11.

The issue is verified as fixed on latest Beta 109.0b5, across platforms: Win 10 x64, macOS 11 and Ubuntu 21.04 x64.