1800985 - USB Remote Debugging is broken after adb extension path changed on ftp.mozilla.org

Status: RESOLVED FIXED

(DevTools :: about:debugging, defect, P3)

Description

[Julian Descottes [:jdescottes]]

It seems the FTP folder https://ftp.mozilla.org/pub/mozilla.org/labs/ was moved to https://ftp.mozilla.org/pub/labs/.

This is referenced at https://searchfox.org/mozilla-central/rev/d7d2cc647772de15c4c5aa47f74d25d0e379e404/modules/libpref/init/all.js#4116 and is used to download the adb-extension in about:debugging.

This prevents users from enabling USB debugging at the moment. If the new location is supposed to be stable, we should update the value of the preference accordingly.

Comment 1

[Julian Descottes [:jdescottes]]

Chris, (sorry for pinging you in two bugs simultaneously!) before proceeding with a patch here I would need to have some more information about the recent changes on the FTP which changed the location of our devtools webextension. I am not sure if that's a question for you, but if not, maybe you'll know who I can ask.

First, I need to know if the new location (https://ftp.mozilla.org/pub/labs/devtools/adb-extension/) is going to be stable.
Then I would still ask if it's possible to preserve the old location for the time being (https://ftp.mozilla.org/pub/mozilla.org/labs/devtools/ ) because otherwise it means we need to uplift this change to beta/release/esr.

I will file another bug to decide on a better location for the extension. As pointed out by :sylvestre on Elements, since it's under labs/ no one expects its content to be actually used in production. We just kept reusing this location to store the ADB extension (formerly ADB Helper) for DevTools since the Firefox OS days.

Comment 2

[Julian Descottes [:jdescottes]]

Attachment: Bug 1800985 - [devtools] Update adb extension URL to new location

The labs folder on the FTP was moved one level up

Comment 3

[chris valaas [:cvalaas]]

Ah, this is a redirect we missed on migrating to google/nginx as middleware for the CDN. A fix is in process and should be pushed shortly.

Comment 4

[Julian Descottes [:jdescottes]]

That's great to hear, thanks for the info!

Comment 5

[chris valaas [:cvalaas]]

this should be "fixed" now. instead of redirecting with a 302, nginx is internally redirecting to the right place. Is that a problem? Like, do you expect a 302 response?

Comment 6

[Julian Descottes [:jdescottes]]

Folders seem fine, but the main issue is that we are still getting a 404 for actual files: https://ftp.mozilla.org/pub/mozilla.org/labs/devtools/adb-extension/mac64/adb-extension-latest-mac64.xpi

That's what about:debugging will pass to AddonManager.getInstallForURL so we would need those URLs to work as well.

Comment 7

[chris valaas [:cvalaas]]

Huh. okay, will investigate further

Comment 8

[chris valaas [:cvalaas]]

All right, I believe I've got this fixed. Yes?

Comment 9

[chris valaas [:cvalaas]]

As proof I offer:

# the xpi file
$ curl -o /dev/null -s -w "%{http_code}\n" https://ftp.mozilla.org/pub/mozilla.org/labs/devtools/adb-extension/mac64/adb-extension-latest-mac64.xpi
200

# the directory containing it
$ curl -o /dev/null -s -w "%{http_code}\n" https://ftp.mozilla.org/pub/mozilla.org/labs/devtools/adb-extension/mac64/
200

Comment 10

[Julian Descottes [:jdescottes]]

Yes looks like this works now, thanks!

Comment 11

[Julian Descottes [:jdescottes]]

Chris, I'm wondering if we should still update our code to point to https://ftp.mozilla.org/pub/labs/ instead of https://ftp.mozilla.org/pub/mozilla.org/labs/ ? If the "canonical" path is pub/labs and pub/mozilla.org/labs is just a redirect, maybe we should use the right one?

(Thanks again for promptly fixing the redirect!)

Comment 12

[chris valaas [:cvalaas]]

Yeah, you should get rid of "mozilla.org" there. Thanks!

Comment 13

[Julian Descottes [:jdescottes]]

Thanks, let's reopen and update the pref then !

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8eb51be92ac9
[devtools] Update adb extension URL to new location r=nchevobbe

Comment 15

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/8eb51be92ac9