1801009 - Consider removing setZoomSettings implementation

Status: RESOLVED WONTFIX

(WebExtensions :: General, task, P5)

Description

[Gregory Pappas [:gregp]]

Continuing a conversation from D158731, I noticed that we have an implementation of tabs.setZoomSettings that doesn't seem to do anything.

On Phabricator, Shane says:

We should probably leave it as some extensions may already be calling it in a way that it does not fail.

I'm not sure that this matters in practice. It doesn't do anything, and in my testing, always throws an exception. Any extension that tries to use it has broken behavior already. Thus, I propose that we remove it entirely to reduce developer confusion (DevTools console autocomplete, etc.). The BCD table on MDN says Firefox doesn't support it and the functionality is already included in the browserSettings api as well.

Comment 1

[Gregory Pappas [:gregp]]

Attachment: Bug 1801009 - Remove broken setZoomSettings implementation r?zombie!

Depends on D158731

Comment 2

[Tomislav Jovanovic :zombie]

We've decided against making this change.

Even though the method doesn't work, the original goal for implementing it was for compatibility. It's a different failure mode when a promise is rejected vs a method is missing. Removing the method might throw in code which didn't previously. There's not much (if any) benefit from doing this.

Therefore closing as wontfix.