1801059 - TPS - Error syncing tabs: tabEngine.getAllClients().find is not a function

Status: RESOLVED FIXED

(Firefox :: Sync, defect)

Description

[Isabel Rios[:isabel_rios]]

Attachment: Firefox-logs.docx

Opening this bug to track this error we are seeing when running the sync integration tests on firefox-ios.

https://storage.googleapis.com/mobile-reports/public/firefox-ios-M1/result_318/SyncIntegrationTests/results/index.html

It happens when we login on Nightly to check if tabs open on mobile are synced.

The error is:
CROSSWEAVE ERROR: [phase phase1] RunNextTestAction failed - TypeError: tabEngine.getAllClients().find is not a function(resource://tps/modules/tabs.jsm:72:49) JS Stack trace: [e-mail]:72:49

Please see complete log file attached if needed.

We need to narrow down when the error started to happen but it is between Nov 7th and Nov 15th.

Mark, are you aware of any changes that could be causing this? Thanks!

Comment 1

[Sammy Khamis [:skhamis]]

Hi Isabel,

This is definitely from the landing on vendoring rust code into desktop: https://bugzilla.mozilla.org/show_bug.cgi?id=1791851 where we had some slight API churn. Specifically this phab patch: https://phabricator.services.mozilla.com/D157981

I'll see if I can get TPS running to understand why that function is failing and put up a patch accordingly.

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1791851

Comment 3

[Sammy Khamis [:skhamis]]

Attachment: Bug 1801059: Fix Error syncing tabs in tps tests r?isabel_rios,markh

Comment 4

[Isabel Rios[:isabel_rios]]

Thanks! Let me know if you need more help to debug, test the fix or confirm when it lands that everything is working.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a6c360a20f2f
Fix Error syncing tabs in tps tests r=isabel_rios

Comment 6

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/a6c360a20f2f

Comment 7

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:skhamis, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox108 to wontfix.

For more information, please visit auto_nag documentation.

Comment 8

[Sammy Khamis [:skhamis]]

:isabel_rios should be working now! I'm not familiar with how TPS tests are run on mobile, will this need to be uplifted to 108? I figured since it's tests we don't need to uplift but if that's not correct LMK.

Comment 9

[Isabel Rios[:isabel_rios]]

Yes! It is working! no need to uplift. Thanks!