1801087 - `skia` third-party C++ file pruning

Status: NEW

(Core :: Graphics, task)

Description

[Adrien Champion [:chadrien]]

Steps to reproduce:

This bug reports tracks the removal of unused C++ (.cpp/.h) files in the skia third-party library.

Comment 2

[Adrien Champion [:chadrien]]

Here are the file clusters considered:

• https://treeherder.mozilla.org/jobs?repo=try&revision=cafec7986f79034d0e735aee19a5bbe6ee240f91

  • cluster 1

    • gfx/skia/skia/src/lazy/SkDiscardableMemoryPool.cpp
    • gfx/skia/skia/src/lazy/SkDiscardableMemoryPool.h
    • gfx/skia/skia/src/ports/SkDiscardableMemory_none.cpp

  • cluster 2

    • gfx/skia/skia/src/pathops/SkPathOpsAsWinding.cpp

  • cluster 3

    • gfx/skia/skia/src/core/SkVMBlitter.cpp
    • gfx/skia/skia/src/core/SkVM.cpp
    • gfx/skia/skia/src/core/SkVM.h

  • cluster 4

    • gfx/skia/skia/src/pathops/SkDCubicToQuads.cpp

  • cluster 5

    • gfx/skia/skia/src/pathops/SkPathOpsTightBounds.cpp

  • cluster 6

    • gfx/skia/skia/src/pathops/SkOpBuilder.cpp

• https://treeherder.mozilla.org/jobs?repo=try&revision=6d807cb27e7894927fb1f7105520997ffc6d3b37

  (this run is cumulative w.r.t. the run above)

  • cluster 7

    • gfx/skia/skia/src/ports/SkOSLibrary_posix.cpp

Comment 3

[Adrien Champion [:chadrien]]

Attachment: Bug 1801087 - Remove `skia` dead C++ cluster `SkDiscardableMemoryPool`. r?sylvestre,marco

Comment 4

[Adrien Champion [:chadrien]]

Attachment: Bug 1801087 - Remove `skia` dead C++ cluster `SkPathOpsAsWinding`. r?glandium,marco

Depends on D162375

Comment 5

[Adrien Champion [:chadrien]]

Attachment: Bug 1801087 - Remove `skia` dead C++ cluster `SkVM`. r?glandium,marco

Depends on D162376

Comment 6

[Adrien Champion [:chadrien]]

Attachment: Bug 1801087 - Remove `skia` dead C++ cluster `SkDCubicToQuads`. r?glandium,marco

Depends on D162377

Comment 7

[Adrien Champion [:chadrien]]

Attachment: Bug 1801087 - Remove `skia` dead C++ cluster `SkPathOpsTightBounds`. r?glandium,marco

Depends on D162378

Comment 8

[Adrien Champion [:chadrien]]

Attachment: Bug 1801087 - Remove `skia` dead C++ cluster `SkOpBuilder`. r?glandium,marco

Depends on D162379

Comment 9

[Adrien Champion [:chadrien]]

Attachment: Bug 1801087 - Remove `skia` dead C++ cluster `SkOSLibrary_posix`. r?glandium,marco

Depends on D162380

Comment 10

[Adrien Champion [:chadrien]]

Attachment: Clusters found by reachable

Clusters identified by the [reachable tool](https://github.com/MozillaSecurity/reachable/tree/master/reachable)

Cluster 1

- https://treeherder.mozilla.org/jobs?repo=try&revision=48d4b49cc7b1af747d6a164a46aed6a03d7d61f7

- `gfx/skia/skia/src/codec/SkMasks.cpp`

Cluster 2

- https://treeherder.mozilla.org/jobs?repo=try&revision=ef5ad692357768c8998d9ff89adfc06094ac0b9c

- `gfx/skia/skia/src/core/SkATrace.cpp`

Cluster 3

- https://treeherder.mozilla.org/jobs?repo=try&revision=5f2fd331105940b36e3da68ded0d05a9c333f7f6

- `gfx/skia/skia/src/core/SkCubicMap.cpp`

Cluster 4

- https://treeherder.mozilla.org/jobs?repo=try&revision=fa7a96e69a6383ddfa89753191f6f39b7f8dbfa8

- `gfx/skia/skia/src/core/SkDistanceFieldGen.cpp`

Cluster 5

- https://treeherder.mozilla.org/jobs?repo=try&revision=d1d124f37b5d419204259fe4805c3e7c2d94b973

- `gfx/skia/skia/src/core/SkICC.cpp`

Cluster 6

- https://treeherder.mozilla.org/jobs?repo=try&revision=b70afdcf13ca24b60e794cac59c617cae1e7d02c

- `gfx/skia/skia/src/core/SkMultiPictureDraw.cpp`
- `gfx/skia/skia/src/core/SkTaskGroup.cpp`

Cluster 7

- https://treeherder.mozilla.org/jobs?repo=try&revision=ba810cfa9efa683ce767143637b76d1df3ee758c

- `gfx/skia/skia/src/core/SkSwizzle.cpp`

Cluster 8

- https://treeherder.mozilla.org/jobs?repo=try&revision=5dc1f7d1d955d0887edf49ec6d4a6199331694d1

- `gfx/skia/skia/src/core/SkYUVMath.cpp`

Cluster 9

- https://treeherder.mozilla.org/jobs?repo=try&revision=986eb743aa9e05cbc8bde7c869466cb16f0ee345

- `gfx/skia/skia/src/core/SkYUVPlanesCache.cpp`

Cluster 10

- https://treeherder.mozilla.org/jobs?repo=try&revision=21013e63fe5a8bfe9b04d39431cc5fb92e258dd1

- `gfx/skia/skia/src/utils/SkOSPath.cpp`

Cluster 11

- https://treeherder.mozilla.org/jobs?repo=try&revision=341c19aa5cbf4d10b3f3c75ff7c9b470e865342e

- `gfx/skia/skia/src/utils/SkParse.cpp`
- `gfx/skia/skia/src/utils/SkParsePath.cpp`

Cluster 12

- https://treeherder.mozilla.org/jobs?repo=try&revision=de33ffbea89f3954aab8d5ede0067fd644ee0925

- `gfx/skia/skia/src/utils/win/SkAutoCoInitialize.cpp`

Cluster 13

- https://treeherder.mozilla.org/jobs?repo=try&revision=17062f7b9c9cef952b3a6a08aed0f262ff2adbdd

- `gfx/skia/skia/src/utils/win/SkIStream.cpp`

Comment 11

[BugBot [:suhaib / :marco/ :calixte]]

The bug assignee is inactive on Bugzilla, so the assignee is being reset.