1801097 - Perma browser-chrome Customize failures e.g. on CustomizableUI.jsm when Gecko 109 merges to Beta on 2022-12-12

Status: VERIFIED FIXED

(Firefox :: Toolbars and Customization, defect)

Description

[Natalia Csoregi [:nataliaCs]]

[Tracking Requested - why for this release]:

• Central-as-beta-simulation
• How to run these simulations
• Failure logs:
  • TEST-UNEXPECTED-FAIL | browser/base/content/test/sync/browser_contextmenu_sendtab.js | Uncaught exception in test - at resource:///modules/CustomizableUI.jsm:1135 - TypeError: aPlacements is undefined
  • TEST-UNEXPECTED-FAIL | browser/components/firefoxview/tests/browser/browser_firefoxview_feature_callout_a11y.js | A promise chain failed to handle a rejection: aPlacements is undefined - stack: buildArea@resource:///modules/CustomizableUI.jsm:1135:22
  • TEST-UNEXPECTED-FAIL | browser/modules/test/browser/browser_UsageTelemetry_toolbars.js | Uncaught exception in test - at resource:///modules/CustomizableUI.jsm:4334 - Error: Area not yet restored
  • TEST-UNEXPECTED-FAIL | browser/base/content/test/general/browser_newwindow_focus.js | A promise chain failed to handle a rejection: aPlacements is undefined - stack: buildArea@resource:///modules/CustomizableUI.jsm:1135:22
  • TEST-UNEXPECTED-FAIL | browser/components/customizableui/test/browser_1008559_anchor_undo_restore.js | Test timed out -
  • TEST-UNEXPECTED-FAIL | browser/components/extensions/test/browser/browser_ext_user_events.js | Cleanup function threw an exception - at resource:///modules/CustomizableUI.jsm:1135 - TypeError: aPlacements is undefined
  • all browser-chrome failures here: push

Mike, these seem triggered by Bug 1798896.
Can you take a look please?
Thank you.

Comment 1

[Mike Conley (:mconley) (:⚙️)]

It's pretty unlikely that we'll abort shipping Unified Extensions in 109, so this will be fixed when the pref is made able to ride the trains. But just in case, I'll see if I can fix these.

Comment 2

[Mike Conley (:mconley) (:⚙️)]

Attachment: Bug 1801097 - Set the AREA_ADDONS placements when resetting, even if Unified Extensions is disabled. r?Gijs!

Even if Unified Extensions is enabled, it is expected that each registered area
will have a placements array set in gPlacements. When resetting, that's normally
re-created in restoreStateForArea, but we were skipping that call for AREA_ADDONS,
and then manually setting the placements array - but only if Unified Extensions
was enabled.

This change makes it so that we always set it when resetting.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d3124713349f
Set the AREA_ADDONS placements when resetting, even if Unified Extensions is disabled. r=Gijs

Comment 4

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/d3124713349f

Comment 5

[Norisz Fay [:noriszfay]]

Verified fixed as seen in the following central as beta simulation