Closed Bug 1801161 Opened 2 years ago Closed 1 year ago

Rename CancelAllOngoingPreloads::CancelAllOngoingPreloads to CancelAllOngoingPreloads::CancelAll

Categories

(Core :: Networking: HTTP, task, P3)

task

Tracking

()

RESOLVED FIXED
112 Branch
Tracking Status
firefox112 --- fixed

People

(Reporter: manuel, Assigned: gotlou)

References

(Blocks 1 open bug)

Details

(Keywords: good-first-bug, Whiteboard: [necko-triaged])

Attachments

(1 file)

Occurences: https://searchfox.org/mozilla-central/search?q=CancelAllOngoingPreloads

Raised in https://phabricator.services.mozilla.com/D149643?id=646349#inline-891623

The function name could be just CancellAll - Since it's already on a class called OngoingEarlyHints

Whiteboard: [necko-triaged]
Blocks: 1802501
No longer blocks: earlyhints
Keywords: good-first-bug
Summary: Followup on phase2 early hint preloader: rename CancelAllOngoingPreloads → Rename CancelAllOngoingPreloads to CancelAll to avoid name duplication
Summary: Rename CancelAllOngoingPreloads to CancelAll to avoid name duplication → Rename CancelAllOngoingPreloads::CancelAllOngoingPreloads to CancelAllOngoingPreloads::CancelAll

As described in the original bugreport, the name can be shortened since
the original name is kind of redundant. The necessary files were changed to
call the renamed function

Assignee: nobody → gotlouemail
Status: NEW → ASSIGNED

Hello, I saw this bug report and as a first-time contributor to Firefox, have made the necessary changes as outlined from the information given in this bugreport

Pushed by mbucher@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/0390c6488ad2
Rename CancelAllOngoingPreloads to CancelAll. r=manuel,necko-reviewers,valentin@mozilla.com
Status: ASSIGNED → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → 112 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: