Closed Bug 1801231 Opened 3 years ago Closed 3 years ago

[wpt-sync] Sync PR 37021 - Additional tests to ensure Ed25519 keys are valid

Categories

(Core :: DOM: Security, task, P4)

task

Tracking

()

RESOLVED FIXED
109 Branch
Tracking Status
firefox109 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 37021 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/37021
Details from upstream follow.

Javier Fernández García-Boente <jfernandez@igalia.com> wrote:

Additional tests to ensure Ed25519 keys are valid

Most of the test we have for the Ed25519 algorithm's operations rely on
the import / export API to manage the keys. We have specific tests for
the generateKey API, but we don't verify the obtained keys are correct
to be used in the algorithm's operations.

The new tests ensure that keys created using the generateKey API are
valid for the 'sign' and 'verify' operations.

Bug: 1370697

Change-Id: I0499ff809fee295e14b5e699f93cbe4619fb88eb
Reviewed-on: https://chromium-review.googlesource.com/4031830
WPT-Export-Revision: 8d39bd705f958443328a327b2c46fcc57d36584b

Component: web-platform-tests → DOM: Security
Product: Testing → Core
Whiteboard: [wptsync downstream] → [wptsync downstream error]
Whiteboard: [wptsync downstream error] → [wptsync downstream]

CI Results

Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 2 tests and 39 subtests

Status Summary

Firefox

OK : 2
PASS: 2
FAIL: 52

Chrome

OK : 2
PASS: 28
FAIL: 26

Safari

OK : 2
PASS: 2
FAIL: 52

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

  • /WebCryptoAPI/sign_verify/eddsa.https.any.html [wpt.fyi]
    • Sign and verify using generated Ed25519 keys.: FAIL (Chrome: PASS, Safari: FAIL)
    • Sign and verify using generated Ed448 keys.: FAIL (Chrome: FAIL, Safari: FAIL)
    • importVectorKeys step: EdDSA Ed25519 verification: FAIL (Safari: FAIL)
    • importVectorKeys step: EdDSA Ed448 verification: FAIL (Chrome: FAIL, Safari: FAIL)
    • importVectorKeys step: EdDSA Ed25519 verification with altered signature after call: FAIL (Safari: FAIL)
    • importVectorKeys step: EdDSA Ed448 verification with altered signature after call: FAIL (Chrome: FAIL, Safari: FAIL)
    • importVectorKeys step: EdDSA Ed25519 with altered data after call: FAIL (Safari: FAIL)
    • importVectorKeys step: EdDSA Ed448 with altered data after call: FAIL (Chrome: FAIL, Safari: FAIL)
    • importVectorKeys step: EdDSA Ed25519 using privateKey to verify: FAIL (Safari: FAIL)
    • importVectorKeys step: EdDSA Ed448 using privateKey to verify: FAIL (Chrome: FAIL, Safari: FAIL)
    • importVectorKeys step: EdDSA Ed25519 using publicKey to sign: FAIL (Safari: FAIL)
    • importVectorKeys step: EdDSA Ed448 using publicKey to sign: FAIL (Chrome: FAIL, Safari: FAIL)
    • importVectorKeys step: EdDSA Ed25519 no verify usage: FAIL (Safari: FAIL)
    • importVectorKeys step: EdDSA Ed448 no verify usage: FAIL (Chrome: FAIL, Safari: FAIL)
    • importVectorKeys step: EdDSA Ed25519 round trip: FAIL (Safari: FAIL)
    • importVectorKeys step: EdDSA Ed448 round trip: FAIL (Chrome: FAIL, Safari: FAIL)
    • importVectorKeys step: EdDSA Ed25519 verification failure due to altered signature: FAIL (Safari: FAIL)
    • importVectorKeys step: EdDSA Ed448 verification failure due to altered signature: FAIL (Chrome: FAIL, Safari: FAIL)
    • importVectorKeys step: EdDSA Ed25519 verification failure due to shortened signature: FAIL (Safari: FAIL)
    • importVectorKeys step: EdDSA Ed448 verification failure due to shortened signature: FAIL (Chrome: FAIL, Safari: FAIL)
    • importVectorKeys step: EdDSA Ed25519 verification failure due to altered data: FAIL (Safari: FAIL)
    • importVectorKeys step: EdDSA Ed448 verification failure due to altered data: FAIL (Chrome: FAIL, Safari: FAIL)
    • importVectorKeys step: EdDSA Ed25519 signing with wrong algorithm name: FAIL (Safari: FAIL)
    • importVectorKeys step: EdDSA Ed448 signing with wrong algorithm name: FAIL (Chrome: FAIL, Safari: FAIL)
    • importVectorKeys step: EdDSA Ed25519 verifying with wrong algorithm name: FAIL (Safari: FAIL)
    • importVectorKeys step: EdDSA Ed448 verifying with wrong algorithm name: FAIL (Chrome: FAIL, Safari: FAIL)
  • /WebCryptoAPI/sign_verify/eddsa.https.any.worker.html [wpt.fyi]
    • Sign and verify using generated Ed25519 keys.: FAIL (Chrome: PASS, Safari: FAIL)
    • Sign and verify using generated Ed448 keys.: FAIL (Chrome: FAIL, Safari: FAIL)
    • importVectorKeys step: EdDSA Ed25519 verification: FAIL (Safari: FAIL)
    • importVectorKeys step: EdDSA Ed448 verification: FAIL (Chrome: FAIL, Safari: FAIL)
    • importVectorKeys step: EdDSA Ed25519 verification with altered signature after call: FAIL (Safari: FAIL)
    • importVectorKeys step: EdDSA Ed448 verification with altered signature after call: FAIL (Chrome: FAIL, Safari: FAIL)
    • importVectorKeys step: EdDSA Ed25519 with altered data after call: FAIL (Safari: FAIL)
    • importVectorKeys step: EdDSA Ed448 with altered data after call: FAIL (Chrome: FAIL, Safari: FAIL)
    • importVectorKeys step: EdDSA Ed25519 using privateKey to verify: FAIL (Safari: FAIL)
    • importVectorKeys step: EdDSA Ed448 using privateKey to verify: FAIL (Chrome: FAIL, Safari: FAIL)
    • importVectorKeys step: EdDSA Ed25519 using publicKey to sign: FAIL (Safari: FAIL)
    • importVectorKeys step: EdDSA Ed448 using publicKey to sign: FAIL (Chrome: FAIL, Safari: FAIL)
    • importVectorKeys step: EdDSA Ed25519 no verify usage: FAIL (Safari: FAIL)
    • importVectorKeys step: EdDSA Ed448 no verify usage: FAIL (Chrome: FAIL, Safari: FAIL)
    • importVectorKeys step: EdDSA Ed25519 round trip: FAIL (Safari: FAIL)
    • importVectorKeys step: EdDSA Ed448 round trip: FAIL (Chrome: FAIL, Safari: FAIL)
    • importVectorKeys step: EdDSA Ed25519 verification failure due to altered signature: FAIL (Safari: FAIL)
    • importVectorKeys step: EdDSA Ed448 verification failure due to altered signature: FAIL (Chrome: FAIL, Safari: FAIL)
    • importVectorKeys step: EdDSA Ed25519 verification failure due to shortened signature: FAIL (Safari: FAIL)
    • importVectorKeys step: EdDSA Ed448 verification failure due to shortened signature: FAIL (Chrome: FAIL, Safari: FAIL)
    • importVectorKeys step: EdDSA Ed25519 verification failure due to altered data: FAIL (Safari: FAIL)
    • importVectorKeys step: EdDSA Ed448 verification failure due to altered data: FAIL (Chrome: FAIL, Safari: FAIL)
    • importVectorKeys step: EdDSA Ed25519 signing with wrong algorithm name: FAIL (Safari: FAIL)
    • importVectorKeys step: EdDSA Ed448 signing with wrong algorithm name: FAIL (Chrome: FAIL, Safari: FAIL)
    • importVectorKeys step: EdDSA Ed25519 verifying with wrong algorithm name: FAIL (Safari: FAIL)
    • importVectorKeys step: EdDSA Ed448 verifying with wrong algorithm name: FAIL (Chrome: FAIL, Safari: FAIL)
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/a022f3782871 [wpt PR 37021] - Additional tests to ensure Ed25519 keys are valid, a=testonly https://hg.mozilla.org/integration/autoland/rev/ff5d11938ea6 [wpt PR 37021] - Update wpt metadata, a=testonly
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → 109 Branch
You need to log in before you can comment on or make changes to this bug.