1801270 - GetDiskInfo can return NS_OK without setting aResult

Status: RESOLVED FIXED

(Core :: XPCOM, defect)

Description

[Valentin Gosu [:valentin] (he/him)]

If we return NS_OK from this function, aResult should be set to the proper value.

Comment 1

[Valentin Gosu [:valentin] (he/him)]

Attachment: Bug 1801270 - Always set aResult when returning NS_OK from GetDiskInfo r=janv

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1746894

Comment 3

[Dianna Smith [:diannaS]]

Since this a recent regression, did you want to get this landed and uplifted to fx108? FYI This is the last week of the beta cycle.

Comment 4

[Valentin Gosu [:valentin] (he/him)]

Attachment: Bug 1801270 - Rename tentativeResult to statfsResult and quotaResult in nsLocalFile::GetDiskInfo r=jstutte

Depends on D162374

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/09d3cd5772bf
Always set aResult when returning NS_OK from GetDiskInfo r=xpcom-reviewers,jstutte
https://hg.mozilla.org/integration/autoland/rev/7f729df6819e
Rename tentativeResult to statfsResult and quotaResult in nsLocalFile::GetDiskInfo r=jstutte

Comment 6

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/09d3cd5772bf
https://hg.mozilla.org/mozilla-central/rev/7f729df6819e

Comment 7

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:valentin, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox108 to wontfix.

For more information, please visit auto_nag documentation.

Comment 8

[Valentin Gosu [:valentin] (he/him)]

Comment on attachment 9304055 [details]
Bug 1801270 - Always set aResult when returning NS_OK from GetDiskInfo r=janv

Beta/Release Uplift Approval Request

• User impact if declined: The error can only happen when the call to FillStatCache or GetDeviceName fail. In that case, we would return a wrong answer (uninitialized value) for nsLocalFile::GetDiskSpaceAvailable or nsLocalFile::GetDiskCapacity. The wrong values could lead us to assume that the disk is full, and keep evicting HTTP cache entries.
  The issue does not affect windows.
• Is this code covered by automated tests?: Unknown
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): The patches make sure we always return a valid result from GetDiskInfo.
• String changes made/needed:
• Is Android affected?: Yes

Comment 9

[Dianna Smith [:diannaS]]

Comment on attachment 9304055 [details]
Bug 1801270 - Always set aResult when returning NS_OK from GetDiskInfo r=janv

We are in RC week for 108

Comment 10

[Dianna Smith [:diannaS]]

Comment on attachment 9304055 [details]
Bug 1801270 - Always set aResult when returning NS_OK from GetDiskInfo r=janv

Approved for 108.0rc2

Comment 11

[Dianna Smith [:diannaS]]

Comment on attachment 9305781 [details]
Bug 1801270 - Rename tentativeResult to statfsResult and quotaResult in nsLocalFile::GetDiskInfo r=jstutte

Approved for 108.0rc2

Comment 12

[Dianna Smith [:diannaS]]

https://hg.mozilla.org/releases/mozilla-release/rev/b544918856bf
https://hg.mozilla.org/releases/mozilla-release/rev/f3b9f86a8e23