1801306 - HBO currently playing video is closed when the user closes the PiP with the ESC button

Status: NEW

(Toolkit :: Picture-in-Picture, defect)

Description

[Daniel Bodea [:danibodea]]

Found in

• Beta v108.0b3

Affected versions

• Nightly v109.0a1
• ESR v102.5.0esr

Tested platforms

• Affected platforms: Win10, Ubu22, MacOS11
• Unaffected platforms: -

Preconditions

• Have a valid HBO account.

Steps to reproduce

1. Load https://play.hbomax.com/page/urn:hbo:page:home
2. Login with a valid account.
3. Play any video.
4. Launch PiP.
5. Make sure PiP is focused and press ESC to close the PiP.

Expected result

• The PiP closes and the playback is paused.
• The currently playing video is NOT closed.

Actual result

• The PiP closes and the currently playing video is closed completely, as the ESC key is also applied to the page, not only to the PiP.

Regression range

• This issue statred occuring after the implementation of bug 1651609:
  2022-11-18T16:00:41.010000: DEBUG : Found commit message:
  Bug 1651609 - Allow ESC key to exit picture-in-picture fullscreen mode. r=pip-reviewers,mhowell

This fix handles the ESC key in 2 ways:

• first when the PiP is in fullscreen mode, it would just leave the fullscreen mode
• second when the PiP is not in fullscreen mode, it would handle it as same as pressing the close button of the PiP player
• introduced a dedicated test for handling the ESC key for fullscreen and non fullscreen modes

Additional notes

• This issue was not found to reproduce in other streaming services (YT, Netflix).

Comment 1

[Jim Mathies [:jimm]]

Maybe the esc key is leaking through to the web page? If so, quite the papercut especially if the user loses the location of their playback. We've got a severity of S3 here set by the reporter. This may have slipped through PiP triage as a result. Molly, mind taking a look adjusting as needed?

Comment 2

[Molly Howell (she/her) (no longer active)]

I did not miss this when it was filed, no. I agree with S3 here until we get some indication that some other service is more broken, because the impact of this issue on HBO currently is just not that bad.