1801321 - Unified extension panel looks broken when add-ons are pinned to the toolbar

Status: VERIFIED FIXED

(WebExtensions :: General, defect)

Description

[Alex Cornestean]

Attachment: 2022-11-18_16h05_48.mp4

Affected versions:
Nightly – 109.0a1/20221118094451

Description:
The unified extension panel looks broken when all the add-ons in it are moved to the toolbar via “Pin to Toolbar”.

The panel remains open when the last add-on is pinned to toolbar. Only the “Extensions” header remains, a few horizontal lines where the add-ons were and the “Manage Extensions” footer.

Steps to reproduce:

1. Install a few add-on with browser actions (NoScript, Search by Image)
2. Move the add-on to the UEB (unified extension button) panel if they are not already there after installing the add-ons
3. Open the panel and start pinning the add-ons to the toolbar
4. Once the last add-on is pinned to the toolbar, observe the UEB panel

Actual:
The UEB panel looks broken after the last add-on has been pinned to the toolbar since during the move of the last add-on, the panel remained open.

Expected:
As the lasta dd-on is moved from the UEB panel to the toolbar, the panel should close.

Comment 1

[William Durand [:willdurand]]

Attachment: Bug 1801321 - Hide panel when pinning an extension to the toolbar. r?mconley!

Similar to the Manage/Remove/Report actions in the (context) menu, we
close the unified extensions panel when clicking "Pin to toolbar". This
will also prevent the panel to be empty when there is only one extension
listed and we decide to pin it to the toolbar.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/655a5b20af88
Hide panel when pinning an extension to the toolbar.  r=mconley

Comment 3

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/655a5b20af88

Comment 4

[Alex Cornestean]

Verified as Fixed on the latest Nightly (109.0a1/20221120214001). Tested on Windows 10 x64 and Ubuntu 16.04 LTS.

The UEB panel closes immediately after each extension is pinned to the toolbar, confirming the fix.

For further details, see the attached video.

Comment 5

[Alex Cornestean]

Attachment: 2022-11-21_10h31_26.mp4