Closed Bug 1801362 Opened 3 years ago Closed 2 years ago

[wpt-sync] Sync PR 37031 - Combine the popoverhide/popovershow events into one toggle event

Categories

(Core :: DOM: Core & HTML, task, P4)

task

Tracking

()

RESOLVED FIXED
110 Branch
Tracking Status
firefox110 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Attachments

(1 file)

Sync web-platform-tests PR 37031 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/37031
Details from upstream follow.

Mason Freed <masonf@chromium.org> wrote:

Combine the popoverhide/popovershow events into one toggle event

See [1] for context. This eliminates the "popoverhide" and
"popovershow" events, and re-uses the "toggle" event for both
of these transitions. The event in this case is a ToggleEvent,
which has a state that is either "opening" or "closing".

[1] https://github.com/openui/open-ui/issues/607#issuecomment-1319114654

Bug: 1307772
Change-Id: I404861a10579365b56e6e8eae7c29f88a5aac166
Reviewed-on: https://chromium-review.googlesource.com/4035832
WPT-Export-Revision: 78484c7b6dbf6868da408e2cc4cb121b2495c807

Component: web-platform-tests → DOM: Core & HTML
Product: Testing → Core
PR 37031 applied with additional changes from upstream: 8bb98a4f9e3f84fb450a5093aa88d8bd2be53c45, af360936fcf00402b9857f57013acb37335aeb86, 0f44b429e244aa0f99b3b94d3c40c2f6adf9d331
Whiteboard: [wptsync downstream] → [wptsync downstream error]
Attached file Notable wpt changes
# CI Results Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI Total 8 tests and 37 subtests ## Status Summary ### Firefox `OK` : 7 `FAIL` : 1005 `ERROR`: 1 ### Chrome `OK` : 8 `PASS` : 953 `FAIL` : 54 ### Safari `OK` : 7 `FAIL` : 1005 `ERROR`: 1 ## Links [GitHub PR Head](https://wpt.fyi/results/?sha=a51313e61b45c21481958e5ed338cd0701a974f8&label=pr_head) [GitHub PR Base](https://wpt.fyi/results/?sha=a51313e61b45c21481958e5ed338cd0701a974f8&label=pr_base) ## Details (See attachment for full changes)
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/f5f3637657a1 [wpt PR 37031] - Combine the popoverhide/popovershow events into one beforetoggle event, a=testonly https://hg.mozilla.org/integration/autoland/rev/70021e8f4492 [wpt PR 37031] - Update wpt metadata, a=testonly
Whiteboard: [wptsync downstream error] → [wptsync downstream]
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → 110 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: