1801441 - ./mach package on Windows Debug buld triggers PathUtils exception

Status: RESOLVED FIXED

(Firefox :: Normandy Client, defect, P1)

Description

[Barret Rennie [:barret] (they/them)]

STR

1. Build a debug build
2. ./mach package

ER
./mach package succeeds

AR

 2:05.42 Assertion failure: !aPath.Contains(u'/') (Windows paths cannot include forward slashes), at C:/Users/Barret/Workspace/src/hg.mozilla.org/mozilla-central/dom/system/PathUtils.cpp:93
 2:06.80 #01: mozilla::dom::PathUtils::InitFileWithPath (C:\Users\Barret\Workspace\src\hg.mozilla.org\mozilla-central\dom\system\PathUtils.cpp:92)
 2:06.80 #02: mozilla::dom::PathUtils::IsAbsolute (C:\Users\Barret\Workspace\src\hg.mozilla.org\mozilla-central\dom\system\PathUtils.cpp:422)
 2:06.81 #03: mozilla::dom::PathUtils_Binding::isAbsolute (C:\Users\Barret\Workspace\src\hg.mozilla.org\mozilla-central\obj-optdebug\dom\bindings\PathUtilsBinding.cpp:615)
 2:06.81 #04: CallJSNative (C:\Users\Barret\Workspace\src\hg.mozilla.org\mozilla-central\js\src\vm\Interpreter.cpp:459)
 2:06.81 #05: js::InternalCallOrConstruct (C:\Users\Barret\Workspace\src\hg.mozilla.org\mozilla-central\js\src\vm\Interpreter.cpp:547)

This is caused by https://searchfox.org/mozilla-central/rev/4d433a219634633ce19158b55520ea228187577a/toolkit/components/normandy/metadata-script.js#22 (or rather its caller)

Comment 1

[Barret Rennie [:barret] (they/them)]

Attachment: Bug 1801441 - Don't crash in metadata-script.js on Windows Debug builds r?emcminn

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/85866e9677a9
Don't crash in metadata-script.js on Windows Debug builds r=emcminn

Comment 3

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/85866e9677a9