1801459 - Regression on macOS: Fullscreen behavior is broken

Status: VERIFIED FIXED

(Core :: Widget: Cocoa, defect)

Description

[Mehmet]

Nightly 109.0a1 (2022-11-18) (64-Bit)
macOS 12.6.1

1.) Open a new window on the Desktop
2.) Click on the Green Window Control Button to switch into Fullscreen
3.) Click on the Red Window Control Button or press CMD-W to close the window so that you are back on the Desktop again
4.) Open a new window with CMD-N

Actual: Fullscreen window opens

Expected: The new window should open on the Desktop

This is a regression.

Comment 1

[Mehmet]

Strangely I can no longer reproduce this issue?!

Comment 2

[Mehmet]

I see this issue again in Nighty 109.0a1 (2022-11-22) (64-Bit) on macOS 12.6.1 :(

Comment 3

[Mehmet]

Okay, I have now the correct steps to reproduce:

1.) Open a new window on the Desktop
2.) Click on the Green Window Control Button to switch into Fullscreen
3.) Press CMD-N to open a second new window in fullscreen (notice the janky animation - see bug 1801460)
3.) Now, close both fullscreen windows with CMD-W or by clicking on the red window control button
4.) Click on the Nightly Dock icon to open a new window on the desktop

Actual: New window in Fullscreen open.

Expected: New window should open on the desktop.

Comment 4

[Mehmet]

This is really a bad regression for MacOS experience. Here is the regression range:

Good build: 2022-10-20-10-56-05-mozilla-central
Bad build: 2022-10-20-21-51-26-mozilla-central

Looks like Bug 1795139 in this range touched fullscreen related code. Maybe this is cause of this regression?

echen@ Can you please take a look, if this is related to your change? Many Thanks :)

Comment 5

[Edgar Chen [:edgar]]

Bug 1795139 only changed the way to show fullscreen notification, it should not affect how fullscreen is handled in widget, so it is unlikely a regression of Bug 1795139. But I will try to get regression window if possible.

Comment 6

[Mehmet]

(In reply to Edgar Chen [:edgar] from comment #5)

Bug 1795139 only changed the way to show fullscreen notification, it should not affect how fullscreen is handled in widget, so it is unlikely a regression of Bug 1795139. But I will try to get regression window if possible.

Many thanks in advance !

Comment 7

[Edgar Chen [:edgar]]

mozregression points me to Bug 1795804.

Comment 8

[Edgar Chen [:edgar]]

Attachment: Bug 1801459 - Use widget sizemode to decide whether persistent should be saved; r?emilio

It is bascially for macOS as user could switch widget to fullscreen via
window control button in macOS, and the fullscreen state on chrome window isn't
updated yet.

Comment 9

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1795804

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/06a19335d057
Use widget sizemode to decide whether persistent should be saved; r=emilio

Comment 12

[Marian-Vasile Laza]

https://hg.mozilla.org/mozilla-central/rev/06a19335d057

Comment 13

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:edgar, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox108 to wontfix.

For more information, please visit auto_nag documentation.

Comment 14

[Edgar Chen [:edgar]]

Comment on attachment 9305178 [details]
Bug 1801459 - Use widget sizemode to decide whether persistent should be saved; r?emilio

Beta/Release Uplift Approval Request

• User impact if declined: The new window might be opened in fullscreen mode wrongly and fullscreen transition is not smooth.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: Follow the STR in https://bugzilla.mozilla.org/show_bug.cgi?id=1801459#c3.
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Small tweak on how we check widget is in fullscreen mode, the change should be safe.
• String changes made/needed: None
• Is Android affected?: No

Comment 15

[Dianna Smith [:diannaS]]

Comment on attachment 9305178 [details]
Bug 1801459 - Use widget sizemode to decide whether persistent should be saved; r?emilio

Approved for 108.0b8

Comment 16

[Dianna Smith [:diannaS]]

https://hg.mozilla.org/releases/mozilla-beta/rev/88e22098f7d1

Comment 17

[Alin Ilea, Desktop QA]

Reproduced in Nightly 109.0a1 (2022-11-22) using macOS 12.
Verified - Fixed in Beta 108.0b9 and the latest Nightly 109.0a1 (2022-12-02) on macOS 12.

Comment 18

[Mehmet]

Many thanks for fixing this issue!