Closed Bug 1801461 Opened 2 months ago Closed 2 months ago

browsingContext.navigate[interactive] should not stop the progress listener if navigation has not started

Categories

(Remote Protocol :: WebDriver BiDi, defect, P1)

defect
Points:
1

Tracking

(firefox109 fixed)

RESOLVED FIXED
109 Branch
Tracking Status
firefox109 --- fixed

People

(Reporter: jdescottes, Assigned: jdescottes)

References

(Blocks 1 open bug)

Details

(Whiteboard: [webdriver:m5])

Attachments

(1 file, 1 obsolete file)

See detailed analysis at https://bugzilla.mozilla.org/show_bug.cgi?id=1785544#c18

The call to stop at https://searchfox.org/mozilla-central/rev/92d3050ecbbdd077ffa4cb78e0dffc4bd5021109/remote/webdriver-bidi/modules/root/browsingContext.sys.mjs#399-401 will stop the progress listener regardless of which document becomes interactive.

Normally the progress listener for navigate should only be stopped for an explicit new navigation (expectNavigation=true, waitForExplicitStart=true), but external callers can still call stop() and bypass all the state logic from the progress listener.

We should expose a safer stop, that will still check that the progress listener state is correct, and maybe make the current stop private. Or maybe stop should also check the progress listener state, which feels a bit redundant since right now it's done case by case before calling stop within the ProgressListener

Assignee: nobody → jdescottes
Status: NEW → ASSIGNED
Severity: -- → S3
Points: --- → 1
Priority: -- → P1
Whiteboard: [webdriver:m5]
Pushed by smolnar@mozilla.com:
https://hg.mozilla.org/mozilla-central/rev/4c736eef7473
[bidi] browsingContext.navigate[interactive] should not stop the progress listener if navigation has not started r=webdriver-reviewers,Sasha,whimboo
Status: ASSIGNED → RESOLVED
Closed: 2 months ago
Resolution: --- → FIXED
Target Milestone: --- → 109 Branch

Comment on attachment 9306961 [details]
Bug 1801461 - [wdspec] Add wdspec tests for browsingContext.navigationStarted

Revision D163994 was moved to bug 1756595. Setting attachment 9306961 [details] to obsolete.

Attachment #9306961 - Attachment is obsolete: true
You need to log in before you can comment on or make changes to this bug.