180153 - [junk mail] analyze "new" local messages, after they've been filtered to an open folder

Status: VERIFIED FIXED

(SeaMonkey :: MailNews: Message Display, defect)

Description

[(not reading, please use [e-mail] instead)]

[junk mail] analyze "new" local messages, after they've been filtered, like we
do with imap messages

from granrose:

1)  he filters pop mail from inbox to folder x.
2)  since filters execute before bayesian plugin, then don't get analyzed
3)  open folder x, and we don't analyze the messages we filtered (like we do
with imap) since they aren't new.

should we just keep them as new, after moving them?

Comment 1

[David :Bienvenu]

I said that I would do this, so unless you're looking for stuff to do, Dan, I
can look at this.

Comment 2

[(not reading, please use [e-mail] instead)]

blocks 11035, which is our meta bug for this work

Comment 3

[mozilla3eran]

This appears to be a dupe of bug 179639.

Comment 4

[David :Bienvenu]

*** Bug 179639 has been marked as a duplicate of this bug. ***

Comment 5

[David :Bienvenu]

Attachment: proposed fix

Comment 6

[David :Bienvenu]

Dan, can I get an r=? thx.

Comment 7

[(not reading, please use [e-mail] instead)]

Comment on attachment 106808 [details] [diff] [review]
proposed fix

sr=sspitzer

you'll make pop users who filter (like granrose) happy with this one.

Comment 8

[Dan Mosedale (:dmosedale, :dmose)]

Comment on attachment 106808 [details] [diff] [review]
proposed fix

r=dmose

Comment 9

[David :Bienvenu]

fix checked in.

Comment 10

[Jon Granrose]

woohoo!  I'll try it tonight.

Comment 11

[David :Bienvenu]

Please let me know. It was easy. Too easy :-)

Comment 12

[Jon Granrose]

looks good.  It's analyzing new messages in the Inbox folders for my secondary
accounts when I enter them.  I noticed for two of my accounts it left one
message each with an "unknown" status rather than marking it junk or non-junk,
so I wonder if it's not having something similar to the IMAP problem where it
used to leave one message unanalyzed.  Although a non-inbox folder in my
secondary account it apparently analyzed all of them.

somewhat related rfe: would be nice if there were a way you could select to have
it analyze messages that are in the "unknown" status even if they're not new. 
This would come in handy in my webmail account since I read that all over the
place so every time I switch between home and work, any read mail that is new in
this profile shows up "unknown".  Probably too much stress on the server for
IMAP, but don't see any reason for it not to work on POP (although that's less
useful).

Comment 13

[Andreas Kunz]

granrose, something like "Tools / Run Junk Mail Controls on Selected Messages" ?

And: thanks, the filter works great here (no mistake among about 50-100
automatically marked messages) and the fix to this bug report left no message
undefined here yet!!

Comment 14

[Jon Granrose]

andreas:  doh!  I meant something to analyze unknown messages *automatically*
every time you enter a folder, so you wouldn't have to do "run junk mail
controls" manually.

Comment 15

[Andrew Perry]

Doesn't this fix reverse the logic of creating a filter TO MOVE a message that
is JUNK MAIL status of = "junk" to a separate folder ???

I know this filter can be created in MESSAGE FILTERS (but didnt work
Automatically before, and definitely wldnt now that Junk Mail is marked AFTER
mail moves) ...  Is the ONLY way to *automatically* move a message that is
labelled as Junk to a "SPAM" folder to use the Junk Mail controls (the ones that
are currently blocked out in the code in junkmail.js) ??? 

And, users would only be able to create *after-the-fact* filters based on
message Junk Mail labels (basically, you can create a filter that says ... MOVE
any mail labelled as JUNK to Trash ... but you could only choose to RUN it on
directories .. b/c it wld never work automatically) ... 

Comment 16

[David :Bienvenu]

Andrew, I don't really know what you're talking about. Junk was always marked
after filter moves; that's the problem that this fixes. You don't have to have
the  junk messages moved to the spam folder by the built-in junk filter.

Comment 17

[Andreas Kunz]

I don't know if you already are aware of that:
While this fix enabled junk scanning in folders where pop mail went after
sorting (it is now scanned upon first access to this folder), the case when you
already *are* in a folder different from your inbox seems to be left:

Say you have folder foo as subfolder of your Inbox and set your message filters
to put certain mails there. Then everything works fine when you are in another
folder (i.e. e.g. viewing your Inbox mails) while downloading your pop mail: the
foo folder is scanned for junk on first access.

BUT when you already are in the foo folder while downloading new messages, then
the mails filtered to the foo folder will NEITHER be examined by the junk mail
controls directly after the download/filtering NOR when you leave and re-enter
the foo folder.

Maybe that is what granrose experienced when he wrote about mails that were left
"unknown". And maybe (if you can reproduce it) this bug should be reopened for
fixing it... 

Comment 18

[David :Bienvenu]

Andreas, no, I didn't realize that, but it makes sense. That's not going to be
so easy to fix. Sigh. I'm tempted to open a new bug for that but I guess I'll
reopen this and change the summary so the people on the cc list won't have to move.

Comment 19

[Michael Heisig]

*** Bug 181912 has been marked as a duplicate of this bug. ***

Comment 20

[Michael Heisig]

The Problem seems to be solved width the Trunk from 2002-11-26 (Mozilla/5.0
(Windows; U; Win98; en-US; rv:1.3a) Gecko/20021126)

Comment 21

[Michael Zimmermann]

Not sure whether the folowing belongs to this bug, but it is rather similar:

Having various pop accounts I filter all incoming mail from AccountX/Inbox to
LocalFolders/Inbox/AccX (x = 1,2,...).
While moving mail within one pop account to sub folders of the inbox and still
get the filtering for junk, this definetly doesn't work, if you move the
messages to LocalFolders/somewhere with message filters.
Only option available is to run the junk mail scan manually after each get
messages. Annoying.
(Build 20030115)

Any comments?

Comment 22

[R.K.Aa.]

*** Bug 197056 has been marked as a duplicate of this bug. ***

Comment 23

[David :Bienvenu]

Attachment: proposed fix

the fix is to run the junk mail controls on the currently displayed folder if
it's not the inbox and it has new messages after getting new pop3 mail.

Comment 24

[David :Bienvenu]

Attachment: proposed fix

need to add null check for folder.

Comment 25

[(not reading, please use [e-mail] instead)]

Comment on attachment 123405 [details] [diff] [review]
proposed fix

r/sr/a=sspitzer

can you double check that there are no ownership cycles introduced?

also, per scc, do:

NS_IF_ADDREF(*aMsgWindow = m_msgWindow);

Comment 26

[(not reading, please use [e-mail] instead)]

should land for 1.4 final.

Comment 27

[David :Bienvenu]

fix checked in.

Comment 28

[esther]

using trunk build 20030521 on winxp, macosx and linux this works for POP to
Local and POP to POP but not for IMAP filtering to a POP or Local folder.  I
know this was specifically logged for POP to Local, but I wanted to try IMAP too
since we just fixed the bug where the move or copy didn't hold the Junk Icon. 
Should I reopen this or log a new bug.  

Comment 29

[David :Bienvenu]

Esther, please log a new bug for the imap -> local case.

Comment 30

[esther]

OK, verified  new bug for imap to pop/local is bug 206679

Comment 31

[louis bennett]

*** Bug 192499 has been marked as a duplicate of this bug. ***

Comment 32

[louis bennett]

*** Bug 204850 has been marked as a duplicate of this bug. ***

Comment 33

[Matthew Mastracci]

Is there a bug that deals with marking messages as spam, even if they should be
getting filtered?  I did a number of bugzilla searches, but this seemed to be
the only related bug.

BTW, I would also love to be able move the junk mail filter around in the
"Message Filters" dialog to prioritize it relative to my other filters.  I'll
create a bug for this second item.