1801563 - Update Zydis to version 4.0.0

Ryan VanderMeulen [:RyanVM]

Reporter

Description

•

1 year ago

Pretty big set of changes.

Added encoding functionality, allowing users to use Zydis for code generation and rewriting
Split instruction and operand decoding, allowing users to decode only the data they actually need
Added support for creating amalgamized builds, essentially combining all of Zydis and the required Zycore source code files and headers into a single header and source file, greatly simplifying linking against Zydis on the quick
Improved and automatically built documentation for all recent versions of Zydis
Added maximally simplified all-in-one disassembler function (see #379 for details)

Ryan VanderMeulen [:RyanVM]

Reporter

Comment 1

•

1 year ago

There were some manual fix-ups needed to ZydisAPI.cpp to account for some function signature changes and/or renamings.

Some failures on Try:
https://treeherder.mozilla.org/logviewer?job_id=397127264&repo=try&lineNumber=20469

[COV] no shared memory bitmap available, skipping
[COV] edge counters initialized. Shared memory: (null) with 298917 edges
executionHash is 0x1 with 0 inputs
executionHash is 0x1 with 0 inputs
executionHash is 0x1 with 0 inputs
/builds/worker/checkouts/gecko/js/src/jit-test/lib/codegen-x64-test.js:165:13 Error: Assertion failed: got false, expected true
Stack:
  codegenTestX64_adhoc@/builds/worker/checkouts/gecko/js/src/jit-test/lib/codegen-x64-test.js:165:13
  @/builds/worker/checkouts/gecko/js/src/jit-test/tests/wasm/binop-x64-ion-codegen.js:215:24
Exit code: 3
FAIL - wasm/binop-x64-ion-codegen.js
TEST-UNEXPECTED-FAIL | js/src/jit-test/tests/wasm/binop-x64-ion-codegen.js | executionHash is 0x1 with 0 inputs (code 3, args "--wasm-compiler=optimizing") [0.3 s]
INFO exit-status     : 3
INFO timed-out       : False
INFO stdout          > [COV] no shared memory bitmap available, skipping
INFO stdout          > [COV] edge counters initialized. Shared memory: (null) with 298917 edges
INFO stderr         2> executionHash is 0x1 with 0 inputs
INFO stderr         2> executionHash is 0x1 with 0 inputs
INFO stderr         2> executionHash is 0x1 with 0 inputs
INFO stderr         2> /builds/worker/checkouts/gecko/js/src/jit-test/lib/codegen-x64-test.js:165:13 Error: Assertion failed: got false, expected true
INFO stderr         2> Stack:
INFO stderr         2> codegenTestX64_adhoc@/builds/worker/checkouts/gecko/js/src/jit-test/lib/codegen-x64-test.js:165:13
INFO stderr         2> @/builds/worker/checkouts/gecko/js/src/jit-test/tests/wasm/binop-x64-ion-codegen.js:215:24
[COV] no shared memory bitmap available, skipping
[COV] edge counters initialized. Shared memory: (null) with 298917 edges
executionHash is 0x1 with 0 inputs
executionHash is 0x1 with 0 inputs
executionHash is 0x1 with 0 inputs
/builds/worker/checkouts/gecko/js/src/jit-test/lib/codegen-x64-test.js:165:13 Error: Assertion failed: got false, expected true
Stack:
  codegenTestX64_adhoc@/builds/worker/checkouts/gecko/js/src/jit-test/lib/codegen-x64-test.js:165:13
  test@/builds/worker/checkouts/gecko/js/src/jit-test/tests/wasm/binop-x64-ion-folding.js:35:25
  test32@/builds/worker/checkouts/gecko/js/src/jit-test/tests/wasm/binop-x64-ion-folding.js:42:12
  @/builds/worker/checkouts/gecko/js/src/jit-test/tests/wasm/binop-x64-ion-folding.js:140:7
Exit code: 3
FAIL - wasm/binop-x64-ion-folding.js
TEST-UNEXPECTED-FAIL | js/src/jit-test/tests/wasm/binop-x64-ion-folding.js | executionHash is 0x1 with 0 inputs (code 3, args "--wasm-compiler=optimizing") [0.2 s]
INFO exit-status     : 3
INFO timed-out       : False
INFO stdout          > [COV] no shared memory bitmap available, skipping
INFO stdout          > [COV] edge counters initialized. Shared memory: (null) with 298917 edges
INFO stderr         2> executionHash is 0x1 with 0 inputs
INFO stderr         2> executionHash is 0x1 with 0 inputs
INFO stderr         2> executionHash is 0x1 with 0 inputs
INFO stderr         2> /builds/worker/checkouts/gecko/js/src/jit-test/lib/codegen-x64-test.js:165:13 Error: Assertion failed: got false, expected true
INFO stderr         2> Stack:
INFO stderr         2> codegenTestX64_adhoc@/builds/worker/checkouts/gecko/js/src/jit-test/lib/codegen-x64-test.js:165:13
INFO stderr         2> test@/builds/worker/checkouts/gecko/js/src/jit-test/tests/wasm/binop-x64-ion-folding.js:35:25
INFO stderr         2> test32@/builds/worker/checkouts/gecko/js/src/jit-test/tests/wasm/binop-x64-ion-folding.js:42:12
INFO stderr         2> @/builds/worker/checkouts/gecko/js/src/jit-test/tests/wasm/binop-x64-ion-folding.js:140:7
[COV] no shared memory bitmap available, skipping
[COV] edge counters initialized. Shared memory: (null) with 298917 edges
executionHash is 0x1 with 0 inputs
executionHash is 0x1 with 0 inputs
executionHash is 0x1 with 0 inputs
/builds/worker/checkouts/gecko/js/src/jit-test/lib/codegen-x64-test.js:165:13 Error: Assertion failed: got false, expected true
Stack:
  codegenTestX64_adhoc@/builds/worker/checkouts/gecko/js/src/jit-test/lib/codegen-x64-test.js:165:13
  @/builds/worker/checkouts/gecko/js/src/jit-test/tests/wasm/binop-x64-ion-codegen.js:215:24
Exit code: 3
FAIL - wasm/binop-x64-ion-codegen.js
TEST-UNEXPECTED-FAIL | js/src/jit-test/tests/wasm/binop-x64-ion-codegen.js | executionHash is 0x1 with 0 inputs (code 3, args "--wasm-test-serialization") [0.3 s]
INFO exit-status     : 3
INFO timed-out       : False
INFO stdout          > [COV] no shared memory bitmap available, skipping
INFO stdout          > [COV] edge counters initialized. Shared memory: (null) with 298917 edges
INFO stderr         2> executionHash is 0x1 with 0 inputs
INFO stderr         2> executionHash is 0x1 with 0 inputs
INFO stderr         2> executionHash is 0x1 with 0 inputs
INFO stderr         2> /builds/worker/checkouts/gecko/js/src/jit-test/lib/codegen-x64-test.js:165:13 Error: Assertion failed: got false, expected true
INFO stderr         2> Stack:
INFO stderr         2> codegenTestX64_adhoc@/builds/worker/checkouts/gecko/js/src/jit-test/lib/codegen-x64-test.js:165:13
INFO stderr         2> @/builds/worker/checkouts/gecko/js/src/jit-test/tests/wasm/binop-x64-ion-codegen.js:215:24
[COV] no shared memory bitmap available, skipping
[COV] edge counters initialized. Shared memory: (null) with 298917 edges
executionHash is 0x1 with 0 inputs
executionHash is 0x1 with 0 inputs
executionHash is 0x1 with 0 inputs
/builds/worker/checkouts/gecko/js/src/jit-test/lib/codegen-x64-test.js:165:13 Error: Assertion failed: got false, expected true
Stack:
  codegenTestX64_adhoc@/builds/worker/checkouts/gecko/js/src/jit-test/lib/codegen-x64-test.js:165:13
  @/builds/worker/checkouts/gecko/js/src/jit-test/tests/wasm/binop-x64-ion-codegen.js:215:24
Exit code: 3
FAIL - wasm/binop-x64-ion-codegen.js
TEST-UNEXPECTED-FAIL | js/src/jit-test/tests/wasm/binop-x64-ion-codegen.js | executionHash is 0x1 with 0 inputs (code 3, args "--wasm-compiler=optimizing --no-avx") [0.3 s]
INFO exit-status     : 3
INFO timed-out       : False
INFO stdout          > [COV] no shared memory bitmap available, skipping
INFO stdout          > [COV] edge counters initialized. Shared memory: (null) with 298917 edges
INFO stderr         2> executionHash is 0x1 with 0 inputs
INFO stderr         2> executionHash is 0x1 with 0 inputs
INFO stderr         2> executionHash is 0x1 with 0 inputs
INFO stderr         2> /builds/worker/checkouts/gecko/js/src/jit-test/lib/codegen-x64-test.js:165:13 Error: Assertion failed: got false, expected true
INFO stderr         2> Stack:
INFO stderr         2> codegenTestX64_adhoc@/builds/worker/checkouts/gecko/js/src/jit-test/lib/codegen-x64-test.js:165:13
INFO stderr         2> @/builds/worker/checkouts/gecko/js/src/jit-test/tests/wasm/binop-x64-ion-codegen.js:215:24
[COV] no shared memory bitmap available, skipping
[COV] edge counters initialized. Shared memory: (null) with 298917 edges
executionHash is 0x1 with 0 inputs
executionHash is 0x1 with 0 inputs
executionHash is 0x1 with 0 inputs
/builds/worker/checkouts/gecko/js/src/jit-test/lib/codegen-x64-test.js:165:13 Error: Assertion failed: got false, expected true
Stack:
  codegenTestX64_adhoc@/builds/worker/checkouts/gecko/js/src/jit-test/lib/codegen-x64-test.js:165:13
  test@/builds/worker/checkouts/gecko/js/src/jit-test/tests/wasm/binop-x64-ion-folding.js:35:25
  test32@/builds/worker/checkouts/gecko/js/src/jit-test/tests/wasm/binop-x64-ion-folding.js:42:12
  @/builds/worker/checkouts/gecko/js/src/jit-test/tests/wasm/binop-x64-ion-folding.js:140:7
Exit code: 3
FAIL - wasm/binop-x64-ion-folding.js
TEST-UNEXPECTED-FAIL | js/src/jit-test/tests/wasm/binop-x64-ion-folding.js | executionHash is 0x1 with 0 inputs (code 3, args "--wasm-test-serialization") [0.2 s]
INFO exit-status     : 3
INFO timed-out       : False
INFO stdout          > [COV] no shared memory bitmap available, skipping
INFO stdout          > [COV] edge counters initialized. Shared memory: (null) with 298917 edges
INFO stderr         2> executionHash is 0x1 with 0 inputs
INFO stderr         2> executionHash is 0x1 with 0 inputs
INFO stderr         2> executionHash is 0x1 with 0 inputs
INFO stderr         2> /builds/worker/checkouts/gecko/js/src/jit-test/lib/codegen-x64-test.js:165:13 Error: Assertion failed: got false, expected true
INFO stderr         2> Stack:
INFO stderr         2> codegenTestX64_adhoc@/builds/worker/checkouts/gecko/js/src/jit-test/lib/codegen-x64-test.js:165:13
INFO stderr         2> test@/builds/worker/checkouts/gecko/js/src/jit-test/tests/wasm/binop-x64-ion-folding.js:35:25
INFO stderr         2> test32@/builds/worker/checkouts/gecko/js/src/jit-test/tests/wasm/binop-x64-ion-folding.js:42:12
INFO stderr         2> @/builds/worker/checkouts/gecko/js/src/jit-test/tests/wasm/binop-x64-ion-folding.js:140:7
[COV] no shared memory bitmap available, skipping
[COV] edge counters initialized. Shared memory: (null) with 298917 edges
executionHash is 0x1 with 0 inputs
executionHash is 0x1 with 0 inputs
executionHash is 0x1 with 0 inputs
/builds/worker/checkouts/gecko/js/src/jit-test/lib/codegen-x64-test.js:165:13 Error: Assertion failed: got false, expected true
Stack:
  codegenTestX64_adhoc@/builds/worker/checkouts/gecko/js/src/jit-test/lib/codegen-x64-test.js:165:13
  test@/builds/worker/checkouts/gecko/js/src/jit-test/tests/wasm/binop-x64-ion-folding.js:35:25
  test32@/builds/worker/checkouts/gecko/js/src/jit-test/tests/wasm/binop-x64-ion-folding.js:42:12
  @/builds/worker/checkouts/gecko/js/src/jit-test/tests/wasm/binop-x64-ion-folding.js:140:7
Exit code: 3
FAIL - wasm/binop-x64-ion-folding.js
TEST-UNEXPECTED-FAIL | js/src/jit-test/tests/wasm/binop-x64-ion-folding.js | executionHash is 0x1 with 0 inputs (code 3, args "--wasm-compiler=optimizing --no-avx") [0.3 s]
INFO exit-status     : 3
INFO timed-out       : False
INFO stdout          > [COV] no shared memory bitmap available, skipping
INFO stdout          > [COV] edge counters initialized. Shared memory: (null) with 298917 edges
INFO stderr         2> executionHash is 0x1 with 0 inputs
INFO stderr         2> executionHash is 0x1 with 0 inputs
INFO stderr         2> executionHash is 0x1 with 0 inputs
INFO stderr         2> /builds/worker/checkouts/gecko/js/src/jit-test/lib/codegen-x64-test.js:165:13 Error: Assertion failed: got false, expected true
INFO stderr         2> Stack:
INFO stderr         2> codegenTestX64_adhoc@/builds/worker/checkouts/gecko/js/src/jit-test/lib/codegen-x64-test.js:165:13
INFO stderr         2> test@/builds/worker/checkouts/gecko/js/src/jit-test/tests/wasm/binop-x64-ion-folding.js:35:25
INFO stderr         2> test32@/builds/worker/checkouts/gecko/js/src/jit-test/tests/wasm/binop-x64-ion-folding.js:42:12
INFO stderr         2> @/builds/worker/checkouts/gecko/js/src/jit-test/tests/wasm/binop-x64-ion-folding.js:140:7

Ryan Hunt [:rhunt] (on leave until early May)

Comment 2

•

1 year ago

We have manual tests that compare against the disassembly to ensure we're emitting the correct instruction sequences for some performance-sensitive operations. It looks like the new disassembler may be outputting in a different format. Example test breakage [1].

Fixing this probably involves running a local build and seeing what disassembly is output. Ideally, these test failures would just say what disassembly they got and what they expected, that would make this easier.

I'll have time to look at this next week, if that's okay.

[1] https://searchfox.org/mozilla-central/rev/83b86005c6913c2062419efb8aabdf2e683aa47f/js/src/jit-test/tests/wasm/binop-x64-ion-codegen.js#215

Ben Visness [:bvisness]

Assignee

Comment 3

•

1 year ago

Attached file Bug 1801563: Update Zydis to version 4.0.0. r=rhunt — Details

Ryan VanderMeulen [:RyanVM]

Reporter

Updated

•

1 year ago

Assignee: ryanvm → ben

Pulsebot

Comment 4

•

1 year ago

Pushed by rvandermeulen@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/c4ac29c35a84
Update Zydis to version 4.0.0. r=rhunt

Norisz Fay [:noriszfay]

Comment 5

•

1 year ago

Backed out for causing SM bustage

Backout link

Push with failures

Failure log

Flags: needinfo?(ben)

BugBot [:suhaib / :marco/ :calixte]

Comment 6

•

1 year ago

There's a r+ patch which didn't land and no activity in this bug for 2 weeks.
:bvisness, could you have a look please?
If you still have some work to do, you can add an action "Plan Changes" in Phabricator.
For more information, please visit auto_nag documentation.

Flags: needinfo?(rhunt)

Flags: needinfo?(ben)

Ryan Hunt [:rhunt] (on leave until early May)

Updated

•

1 year ago

Flags: needinfo?(rhunt)

Flags: needinfo?(ben)

Pulsebot

Comment 7

•

1 year ago

Pushed by rhunt@eqrion.net:
https://hg.mozilla.org/integration/autoland/rev/c6795729948b
Update Zydis to version 4.0.0. r=rhunt

Iulian Moraru

Comment 8

•

1 year ago

Backed out for causing spidermonkey build bustages on codegen-x86-test.js.

[task 2023-02-08T00:18:56.726Z] TEST-PASS | js/src/jit-test/tests/wasm/simd/binop-x86-ion-codegen.js | Success (code 59, args "--wasm-test-serialization") [0.0 s]
[task 2023-02-08T00:18:56.730Z] ---- codegen-x86-test.js: TEST FAILED ----
[task 2023-02-08T00:18:56.730Z] ---- module text
[task 2023-02-08T00:18:56.730Z] (module 
[task 2023-02-08T00:18:56.730Z]     (func (export "f") (param v128) (result v128)
[task 2023-02-08T00:18:56.730Z]       (f32x4.eq (local.get 0) (v128.const f32x4 1 2 3 4))))
[task 2023-02-08T00:18:56.730Z] ---- actual
[task 2023-02-08T00:18:56.730Z] 00000000  55                                    push %rbp
[task 2023-02-08T00:18:56.730Z] 00000001  8b ec                                 mov %esp, %ebp
[task 2023-02-08T00:18:56.730Z] 00000003  81 f9 33 04 00 00                     cmp $0x433, %ecx
[task 2023-02-08T00:18:56.730Z] 00000009  0f 84 14 00 00 00                     jz 0x0000000000000023
[task 2023-02-08T00:18:56.730Z] 0000000F  0f 0b                                 ud2
[task 2023-02-08T00:18:56.730Z] 00000011  90                                    nop
[task 2023-02-08T00:18:56.730Z] 00000012  0f 1f 80 00 00 00 00                  nopl %eax, (%rax)
[task 2023-02-08T00:18:56.730Z] 00000019  0f 1f 80 00 00 00 00                  nopl %eax, (%rax)
[task 2023-02-08T00:18:56.730Z] 00000020  55                                    push %rbp
[task 2023-02-08T00:18:56.730Z] 00000021  8b ec                                 mov %esp, %ebp
[task 2023-02-08T00:18:56.730Z] 00000023  b8 ef be ad de                        mov $-0x21524111, %eax
[task 2023-02-08T00:18:56.730Z] 00000028  f3 0f 6f 45 18                        movdqux 0x18(%rbp), %xmm0
[task 2023-02-08T00:18:56.730Z] 0000002D  0f c2 05 50 d0 85 21 00               cmppsx $0x00, 0x000000002185D085, %xmm0
[task 2023-02-08T00:18:56.730Z] 00000035  5d                                    pop %rbp
[task 2023-02-08T00:18:56.730Z] 00000036  c3                                    ret
[task 2023-02-08T00:18:56.730Z] 
[task 2023-02-08T00:18:56.731Z] ---- expected (initial)
[task 2023-02-08T00:18:56.731Z] 
[task 2023-02-08T00:18:56.731Z] f3 0f 6f 45 [0-9a-fA-F]{2}            movdqux 0x[0-9a-fA-F]+\(%.bp\), %xmm0
[task 2023-02-08T00:18:56.731Z] 0f c2 05 [0-9a-fA-F]{2} [0-9a-fA-F]{2} [0-9a-fA-F]{2} [0-9a-fA-F]{2} 00   cmppsx \$0x00, 0x[0-9a-fA-F]+, %xmm0
[task 2023-02-08T00:18:56.731Z] ---- expected (as used)
[task 2023-02-08T00:18:56.731Z] (?:0x)?[0-9a-fA-F]+\s+8b\s+ec\s+mov\s+%esp,\s+%ebp(
[task 2023-02-08T00:18:56.731Z] (?:0x)?[0-9a-fA-F]+\s+b8\s+ef\s+be\s+ad\s+de\s+mov\s+\$0xDEADBEEF,\s+%eax)?
[task 2023-02-08T00:18:56.731Z] (?:0x)?[0-9a-fA-F]+\s+f3\s+0f\s+6f\s+45\s+[0-9a-fA-F]{2}\s+movdqux\s+0x[0-9a-fA-F]+\(%.bp\),\s+%xmm0
[task 2023-02-08T00:18:56.731Z] (?:0x)?[0-9a-fA-F]+\s+0f\s+c2\s+05\s+[0-9a-fA-F]{2}\s+[0-9a-fA-F]{2}\s+[0-9a-fA-F]{2}\s+[0-9a-fA-F]{2}\s+00\s+cmppsx\s+\$0x00,\s+0x[0-9a-fA-F]+,\s+%xmm0
[task 2023-02-08T00:18:56.731Z] (?:0x)?[0-9a-fA-F]+\s+5d\s+pop\s+%.bp
[task 2023-02-08T00:18:56.731Z] ----
[task 2023-02-08T00:18:56.731Z] /builds/worker/checkouts/gecko/js/src/jit-test/lib/codegen-x86-test.js:80:13 Error: Assertion failed: got false, expected true
[task 2023-02-08T00:18:56.731Z] Stack:
[task 2023-02-08T00:18:56.732Z]   codegenTestX86_adhoc@/builds/worker/checkouts/gecko/js/src/jit-test/lib/codegen-x86-test.js:80:13
[task 2023-02-08T00:18:56.732Z]   codegenTestX86_v128xLITERAL_v128@/builds/worker/checkouts/gecko/js/src/jit-test/lib/codegen-x86-test.js:35:29
[task 2023-02-08T00:18:56.732Z]   @/builds/worker/checkouts/gecko/js/src/jit-test/tests/wasm/simd/binop-x86-ion-codegen.js:3:33
[task 2023-02-08T00:18:56.732Z] Exit code: 3
[task 2023-02-08T00:18:56.732Z] FAIL - wasm/simd/binop-x86-ion-codegen.js
[task 2023-02-08T00:18:56.732Z] TEST-UNEXPECTED-FAIL | js/src/jit-test/tests/wasm/simd/binop-x86-ion-codegen.js | /builds/worker/checkouts/gecko/js/src/jit-test/lib/codegen-x86-test.js:80:13 Error: Assertion failed: got false, expected true (code 3, args "--wasm-compiler=optimizing --no-avx") [0.0 s]
[task 2023-02-08T00:18:56.732Z] INFO exit-status     : 3
[task 2023-02-08T00:18:56.732Z] INFO timed-out       : False
[task 2023-02-08T00:18:56.732Z] INFO stdout          > ---- codegen-x86-test.js: TEST FAILED ----
[task 2023-02-08T00:18:56.733Z] INFO stdout          > ---- module text
[task 2023-02-08T00:18:56.733Z] INFO stdout          > (module
[task 2023-02-08T00:18:56.733Z] INFO stdout          > (func (export "f") (param v128) (result v128)
[task 2023-02-08T00:18:56.733Z] INFO stdout          > (f32x4.eq (local.get 0) (v128.const f32x4 1 2 3 4))))
[task 2023-02-08T00:18:56.733Z] INFO stdout          > ---- actual
[task 2023-02-08T00:18:56.733Z] INFO stdout          > 00000000  55                                    push %rbp
[task 2023-02-08T00:18:56.733Z] INFO stdout          > 00000001  8b ec                                 mov %esp, %ebp
[task 2023-02-08T00:18:56.733Z] INFO stdout          > 00000003  81 f9 33 04 00 00                     cmp $0x433, %ecx
[task 2023-02-08T00:18:56.733Z] INFO stdout          > 00000009  0f 84 14 00 00 00                     jz 0x0000000000000023
[task 2023-02-08T00:18:56.733Z] INFO stdout          > 0000000F  0f 0b                                 ud2
[task 2023-02-08T00:18:56.733Z] INFO stdout          > 00000011  90                                    nop
[task 2023-02-08T00:18:56.733Z] INFO stdout          > 00000012  0f 1f 80 00 00 00 00                  nopl %eax, (%rax)
[task 2023-02-08T00:18:56.733Z] INFO stdout          > 00000019  0f 1f 80 00 00 00 00                  nopl %eax, (%rax)
[task 2023-02-08T00:18:56.733Z] INFO stdout          > 00000020  55                                    push %rbp
[task 2023-02-08T00:18:56.733Z] INFO stdout          > 00000021  8b ec                                 mov %esp, %ebp
[task 2023-02-08T00:18:56.733Z] INFO stdout          > 00000023  b8 ef be ad de                        mov $-0x21524111, %eax
[task 2023-02-08T00:18:56.733Z] INFO stdout          > 00000028  f3 0f 6f 45 18                        movdqux 0x18(%rbp), %xmm0
[task 2023-02-08T00:18:56.733Z] INFO stdout          > 0000002D  0f c2 05 50 d0 85 21 00               cmppsx $0x00, 0x000000002185D085, %xmm0
[task 2023-02-08T00:18:56.733Z] INFO stdout          > 00000035  5d                                    pop %rbp
[task 2023-02-08T00:18:56.733Z] INFO stdout          > 00000036  c3                                    ret
[task 2023-02-08T00:18:56.733Z] INFO stdout          > 
[task 2023-02-08T00:18:56.733Z] INFO stdout          > ---- expected (initial)
[task 2023-02-08T00:18:56.733Z] INFO stdout          > 
[task 2023-02-08T00:18:56.733Z] INFO stdout          > f3 0f 6f 45 [0-9a-fA-F]{2}            movdqux 0x[0-9a-fA-F]+\(%.bp\), %xmm0
[task 2023-02-08T00:18:56.733Z] INFO stdout          > 0f c2 05 [0-9a-fA-F]{2} [0-9a-fA-F]{2} [0-9a-fA-F]{2} [0-9a-fA-F]{2} 00   cmppsx \$0x00, 0x[0-9a-fA-F]+, %xmm0
[task 2023-02-08T00:18:56.733Z] INFO stdout          > ---- expected (as used)
[task 2023-02-08T00:18:56.733Z] INFO stdout          > (?:0x)?[0-9a-fA-F]+\s+8b\s+ec\s+mov\s+%esp,\s+%ebp(
[task 2023-02-08T00:18:56.733Z] INFO stdout          > (?:0x)?[0-9a-fA-F]+\s+b8\s+ef\s+be\s+ad\s+de\s+mov\s+\$0xDEADBEEF,\s+%eax)?
[task 2023-02-08T00:18:56.733Z] INFO stdout          > (?:0x)?[0-9a-fA-F]+\s+f3\s+0f\s+6f\s+45\s+[0-9a-fA-F]{2}\s+movdqux\s+0x[0-9a-fA-F]+\(%.bp\),\s+%xmm0
[task 2023-02-08T00:18:56.733Z] INFO stdout          > (?:0x)?[0-9a-fA-F]+\s+0f\s+c2\s+05\s+[0-9a-fA-F]{2}\s+[0-9a-fA-F]{2}\s+[0-9a-fA-F]{2}\s+[0-9a-fA-F]{2}\s+00\s+cmppsx\s+\$0x00,\s+0x[0-9a-fA-F]+,\s+%xmm0
[task 2023-02-08T00:18:56.733Z] INFO stdout          > (?:0x)?[0-9a-fA-F]+\s+5d\s+pop\s+%.bp
[task 2023-02-08T00:18:56.734Z] INFO stdout          > ----
[task 2023-02-08T00:18:56.734Z] INFO stderr         2> /builds/worker/checkouts/gecko/js/src/jit-test/lib/codegen-x86-test.js:80:13 Error: Assertion failed: got false, expected true
[task 2023-02-08T00:18:56.734Z] INFO stderr         2> Stack:
[task 2023-02-08T00:18:56.734Z] INFO stderr         2> codegenTestX86_adhoc@/builds/worker/checkouts/gecko/js/src/jit-test/lib/codegen-x86-test.js:80:13
[task 2023-02-08T00:18:56.734Z] INFO stderr         2> codegenTestX86_v128xLITERAL_v128@/builds/worker/checkouts/gecko/js/src/jit-test/lib/codegen-x86-test.js:35:29
[task 2023-02-08T00:18:56.734Z] INFO stderr         2> @/builds/worker/checkouts/gecko/js/src/jit-test/tests/wasm/simd/binop-x86-ion-codegen.js:3:33
[task 2023-02-08T00:18:56.735Z] TEST-PASS | js/src/jit-test/tests/wasm/simd/bitselect-x64-ion-codegen.js | Success (code 59, args "") [0.0 s]

Flags: needinfo?(ben)

Pulsebot

Comment 9

•

1 year ago

Pushed by rhunt@eqrion.net:
https://hg.mozilla.org/integration/autoland/rev/587167c314e2
Update Zydis to version 4.0.0. r=rhunt

Marian-Vasile Laza

Comment 10

•

1 year ago

bugherder

https://hg.mozilla.org/mozilla-central/rev/587167c314e2

Status: NEW → RESOLVED

Closed: 1 year ago

status-firefox111: --- → fixed

Resolution: --- → FIXED

Target Milestone: --- → 111 Branch

Ben Visness [:bvisness]

Assignee

Updated

•

1 year ago

Flags: needinfo?(ben)

Ryan VanderMeulen [:RyanVM]

Reporter

Comment 11

•

1 year ago

Thanks for finishing this off, Ben!

Ryan VanderMeulen [:RyanVM]

Reporter

Updated

•

2 months ago

Blocks: 1878581

Bugzilla

Quick Search

Update Zydis to version 4.0.0

Categories

(Core :: JavaScript: WebAssembly, task)

Tracking

()

People

(Reporter: RyanVM, Assigned: bvisness)

References

(
URL
)

Details

Crash Data

Security

(public)

User Story

Attachments

(1 file)

Description

Comment 1

Comment 2

Comment 3

Updated

Comment 4

Comment 5

Comment 6

Updated

Comment 7

Comment 8

Comment 9

Comment 10

Updated

Comment 11

Updated

Attachment

General

Description

File Name

Content Type