180158 - Non Latin1 folder name turns to dots in CreateUtf7ConvertedString

Status: RESOLVED FIXED

(MailNews Core :: Networking: IMAP, defect)

Description

[nhottanscp]

This happens when I select a folder with non Latin1 name.

The call to ToCString() converts non Latin1 characters into dots (and I get an
assertion).
Can we return UTF-8 instead? But I am not sure the following code can handle
UTF-8 or not.


CreateUtf7ConvertedString(const char * 0x04bafd18, int 0x00000000) line 94
nsImapProtocol::RefreshFolderACLView(const char * 0x04bafd18, nsIMAPNamespace *
0x042f1d48) line 5304 + 12 bytes
nsImapProtocol::RefreshACLForFolder(const char * 0x04bafd18) line 5281
nsImapProtocol::RefreshACLForFolderIfNecessary(const char * 0x04bafd18) line 5256
nsImapProtocol::ProcessSelectedStateURL() line 1914
nsImapProtocol::ProcessCurrentURL() line 1312
nsImapProtocol::ImapThreadMainLoop() line 1114 + 14 bytes
nsImapProtocol::Run(nsImapProtocol * const 0x04b15c04) line 908
nsThread::Main(void * 0x04755f18) line 120 + 26 bytes
_PR_NativeRunThread(void * 0x04970cf0) line 433 + 13 bytes
_threadstartex(void * 0x0446e158) line 212 + 13 bytes

Comment 1

[nhottanscp]

I don't see any visible problem.
David, what does this part of the code do?

Comment 2

[David :Bienvenu]

it refreshes the acl for the folder. Most likely, this won't have a visible
effect, unless there's some special acl set for the folder, like you've shared
the folder (highly unlikely).

I doubt utf8 is the right thing to do. The code is wrong as it is, though. Let
me check into the inputs and outputs. This is the only caller of that routine,
which is highly suspicious.

Comment 3

[David :Bienvenu]

Attachment: proposed fix

remove the conversion - we want the folder name to be in imap mod utf7, as it
is. Naoki, can you review? thx.

Comment 4

[(not reading, please use [e-mail] instead)]

Comment on attachment 106237 [details] [diff] [review]
proposed fix

sr=sspitzer

Comment 5

[David :Bienvenu]

fix checked in.

Comment 6

[esther]

changing qa this appears to be for the international qa